Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1561604670-11476-1-git-send-email-yang.bin18@zte.com.cn>
In-Reply-To: <1561604670-11476-1-git-send-email-yang.bin18@zte.com.cn>
From:   =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= <andreas.gruenbacher@gmail.com>
Date:   Thu, 27 Jun 2019 15:57:33 +0200
Message-ID: <CAHpGcM+6p_TtHh=YSa1Mxyjr+w+V5_8RR2TgnN-s5TbbHjGhng@mail.gmail.com>
Subject: Re: [PATCH] sub sd_rgrps When clear rgrp
To:     Yang Bin <yang.bin18@zte.com.cn>
Cc:     Bob Peterson <rpeterso@redhat.com>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        cluster-devel <cluster-devel@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        wang.yi59@zte.com.cn
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Yang Bin,

Am Do., 27. Juni 2019 um 05:08 Uhr schrieb Yang Bin <yang.bin18@zte.com.cn>:
> From: " Yang Bin "<yang.bin18@zte.com.cn>
>
> When clear rgrp,sub sd_rgrps after erased from rindex_tree

this patch isn't incorrect, but all it does it ensure that sd_rgrps
reaches zero before we destroy a struct gfs2_sbd. However, sd_rgrps is
only ever used when a filesystem is active, and while that is the
case, it can never decrease. It will grow when the filesystem is grown
though.

So what are you trying to achieve with this patch?

> Signed-off-by: Yang Bin <yang.bin18@zte.com.cn>
> ---
>  fs/gfs2/rgrp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
> index 15d6e32..a4b2e83
> --- a/fs/gfs2/rgrp.c
> +++ b/fs/gfs2/rgrp.c
> @@ -730,6 +730,7 @@ void gfs2_clear_rgrpd(struct gfs2_sbd *sdp)
>                 gl = rgd->rd_gl;
>
>                 rb_erase(n, &sdp->sd_rindex_tree);
> +               sdp->sd_rgrps--;
>
>                 if (gl) {
>                         glock_clear_object(gl, rgd);
> --
> 1.8.3.1
>

Thanks,
Andreas