Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Song Liu <songliubraving@fb.com>
To:     Allan Zhang <allanzhang@google.com>
CC:     Daniel Borkmann <daniel@iogearbox.net>,
        Alexei Starovoitov <ast@kernel.org>, Martin Lau <kafai@fb.com>,
        Yonghong Song <yhs@fb.com>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v7 1/2] bpf: Allow bpf_skb_event_output for a few
 prog types
Thread-Topic: [PATCH bpf-next v7 1/2] bpf: Allow bpf_skb_event_output for a
 few prog types
Thread-Index: AQHVLHsNLL4HKFmtjU6rKbDZjMCInKavs2uA
Date:   Thu, 27 Jun 2019 16:34:30 +0000
Message-ID: <F5F0362C-BAEE-404F-A65A-0CAE95BB0C67@fb.com>
References: <20190626235801.210508-1-allanzhang@google.com>
 <20190626235801.210508-2-allanzhang@google.com>
In-Reply-To: <20190626235801.210508-2-allanzhang@google.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F644A744302E454DB346AD09C375A5CE@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c01f768-3f85-4698-7de0-08d6fb1d5477
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2019 16:34:30.7763
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: songliubraving@fb.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1341
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-27_10:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1906270189
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jun 26, 2019, at 4:58 PM, Allan Zhang <allanzhang@google.com> wrote:
>=20
> From: allanzhang <allanzhang@google.com>
>=20
> Software event output is only enabled by a few prog types right now (TC,
> LWT out, XDP, sockops). Many other skb based prog types need
> bpf_skb_event_output to produce software event.
>=20
> Added socket_filter, cg_skb, sk_skb prog types to generate sw event.
>=20
> Test bpf code is generated from code snippet:
>=20
> struct TMP {
>    uint64_t tmp;
> } tt;
> tt.tmp =3D 5;
> bpf_perf_event_output(skb, &connection_tracking_event_map, 0,
>                      &tt, sizeof(tt));
> return 1;
>=20
> the bpf assembly from llvm is:
>       0:       b7 02 00 00 05 00 00 00         r2 =3D 5
>       1:       7b 2a f8 ff 00 00 00 00         *(u64 *)(r10 - 8) =3D r2
>       2:       bf a4 00 00 00 00 00 00         r4 =3D r10
>       3:       07 04 00 00 f8 ff ff ff         r4 +=3D -8
>       4:       18 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00    r2 =3D =
0ll
>       6:       b7 03 00 00 00 00 00 00         r3 =3D 0
>       7:       b7 05 00 00 08 00 00 00         r5 =3D 8
>       8:       85 00 00 00 19 00 00 00         call 25
>       9:       b7 00 00 00 01 00 00 00         r0 =3D 1
>      10:       95 00 00 00 00 00 00 00         exit
>=20
> Signed-off-by: Allan Zhang <allanzhang@google.com>

Acked-by: Song Liu <songliubraving@fb.com>

> ---
> net/core/filter.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>=20
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 2014d76e0d2a..b75fcf412628 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -5958,6 +5958,8 @@ sk_filter_func_proto(enum bpf_func_id func_id, cons=
t struct bpf_prog *prog)
> 		return &bpf_get_socket_cookie_proto;
> 	case BPF_FUNC_get_socket_uid:
> 		return &bpf_get_socket_uid_proto;
> +	case BPF_FUNC_perf_event_output:
> +		return &bpf_skb_event_output_proto;
> 	default:
> 		return bpf_base_func_proto(func_id);
> 	}
> @@ -5978,6 +5980,8 @@ cg_skb_func_proto(enum bpf_func_id func_id, const s=
truct bpf_prog *prog)
> 		return &bpf_sk_storage_get_proto;
> 	case BPF_FUNC_sk_storage_delete:
> 		return &bpf_sk_storage_delete_proto;
> +	case BPF_FUNC_perf_event_output:
> +		return &bpf_skb_event_output_proto;
> #ifdef CONFIG_SOCK_CGROUP_DATA
> 	case BPF_FUNC_skb_cgroup_id:
> 		return &bpf_skb_cgroup_id_proto;
> @@ -6226,6 +6230,8 @@ sk_skb_func_proto(enum bpf_func_id func_id, const s=
truct bpf_prog *prog)
> 		return &bpf_sk_redirect_map_proto;
> 	case BPF_FUNC_sk_redirect_hash:
> 		return &bpf_sk_redirect_hash_proto;
> +	case BPF_FUNC_perf_event_output:
> +		return &bpf_skb_event_output_proto;
> #ifdef CONFIG_INET
> 	case BPF_FUNC_sk_lookup_tcp:
> 		return &bpf_sk_lookup_tcp_proto;
> --=20
> 2.22.0.410.gd8fdbe21b5-goog
>=20