Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751248AbVK1QQH (ORCPT ); Mon, 28 Nov 2005 11:16:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751249AbVK1QQH (ORCPT ); Mon, 28 Nov 2005 11:16:07 -0500 Received: from e34.co.us.ibm.com ([32.97.110.152]:36786 "EHLO e34.co.us.ibm.com") by vger.kernel.org with ESMTP id S1751248AbVK1QQG (ORCPT ); Mon, 28 Nov 2005 11:16:06 -0500 Date: Mon, 28 Nov 2005 21:47:47 +0530 From: Dipankar Sarma To: Andi Kleen Cc: akpm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Allow lockless traversal of notifier lists Message-ID: <20051128161747.GA4359@in.ibm.com> Reply-To: dipankar@in.ibm.com References: <20051128133757.GQ20775@brahms.suse.de> <20051128160129.GA8478@in.ibm.com> <20051128160547.GA20775@brahms.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051128160547.GA20775@brahms.suse.de> User-Agent: Mutt/1.5.10i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 661 Lines: 24 On Mon, Nov 28, 2005 at 05:05:47PM +0100, Andi Kleen wrote: > * > * Returns zero on success, or %-ENOENT on failure. > */ > @@ -175,6 +181,7 @@ > There should be an smp_read_barrier_depends() here for the first dereferencing of the notifier block head, I think. > while(nb) > { > + smp_read_barrier_depends(); > ret=nb->notifier_call(nb,val,v); > if(ret&NOTIFY_STOP_MASK) > { Thanks Dipankar - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/