Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190617222034.10799-1-linux@rasmusvillemoes.dk>
 <20190617222034.10799-8-linux@rasmusvillemoes.dk> <CAKwvOdn5fhCTqtciKBwAj3vYQMhi06annzxcdC1GjKxri=dHnw@mail.gmail.com>
 <12bd1adc-2258-ad5d-f6c9-079fdf0821b8@rasmusvillemoes.dk> <CAKwvOdkqy8=V17qEM_SMDEAh=UX5Y2-nj9EUkC169nEiXc_JzA@mail.gmail.com>
 <70aa7b96-e19d-5f8b-1ff6-af15715623e5@rasmusvillemoes.dk> <CAKwvOdkWo5yG7LrtGL_ht-XHFgNqx_t6rP+hHhcPyb+Ud1N+HA@mail.gmail.com>
 <CAKwvOdnFt18ffO0BV-AZ9+mYuOBMroPObxrakXdV1v4iL3CS3Q@mail.gmail.com> <4e9d2103-2186-308b-c560-830c57ee3a6d@rasmusvillemoes.dk>
In-Reply-To: <4e9d2103-2186-308b-c560-830c57ee3a6d@rasmusvillemoes.dk>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Thu, 27 Jun 2019 11:03:23 -0700
Message-ID: <CAKwvOdkQ5FmaKNSfDR39aC7P7UdU5f8ktzoBJDk=1aAXtYLaNQ@mail.gmail.com>
Subject: Re: [PATCH v6 7/8] dynamic_debug: add asm-generic implementation for DYNAMIC_DEBUG_RELATIVE_POINTERS
To:     Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc:     Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jason Baron <jbaron@akamai.com>,
        Nathan Chancellor <natechancellor@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 26, 2019 at 4:52 PM Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
>
> On 27/06/2019 01.16, Nick Desaulniers wrote:
> > On Tue, Jun 25, 2019 at 3:18 PM Nick Desaulniers
> > <ndesaulniers@google.com> wrote:
> >
> > The prints should show up in dmesg right, assuming you do something to
> > trigger them?  Can you provide more details for a test case that's
> > easy to trip? What's an easy case to reproduce from a limited
> > buildroot env (basic shell/toybox)?
> >
>
> Hm, I seemed to remember that those kobject events triggered all the
> time. Oh well, try this one:
>
> echo 'file ping.c +p' > control
> ping localhost
> dmesg | grep ping

I don't have guest networking setup from QEMU to host, so there's no
network available to ping. :(

but:

(initramfs) echo 'file drivers/tty/*.c +p' > /dfs/dynamic_debug/control
(initramfs) grep tty /dfs/dynamic_debug/control
...
drivers/tty/serial/8250/8250_core.c:113 [8250]serial8250_interrupt =p
"%s(%d): start\012"
drivers/tty/serial/8250/8250_core.c:139 [8250]serial8250_interrupt =p
"%s(%d): end\012"
...
(initramfs) dmesg
...
[  134.895846] serial8250_interrupt(4): start
[  134.895967] serial8250_interrupt(4): end
[  134.895970] serial8250_interrupt(4): start
[  134.895981] serial8250_interrupt(4): end
[  134.895998] serial8250_interrupt(4): start
[  134.896053] serial8250_interrupt(4): end

I then verified that nothing new appears in dmesg related to these
traces after running:
(initramfs) echo 'file drivers/tty/*.c -p' > /dfs/dynamic_debug/control

so if that's good enough, then for the series:
Tested-by: Nick Desaulniers <ndesaulniers@google.com>

Thanks,
~Nick Desaulniers