Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Fuqian Huang <huangfq.daxian@gmail.com>
CC:     Damien Le Moal <Damien.LeMoal@wdc.com>,
        Jens Axboe <axboe@kernel.dk>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 10/87] block: skd_main.c: Remove call to memset after
 dma_alloc_coherent
Thread-Topic: [PATCH 10/87] block: skd_main.c: Remove call to memset after
 dma_alloc_coherent
Thread-Index: AQHVLQ61YUY2jSmYOkW/rXYnO0F8bg==
Date:   Thu, 27 Jun 2019 19:37:23 +0000
Message-ID: <BYAPR04MB574987E7A45552F8AD8AD6DE86FD0@BYAPR04MB5749.namprd04.prod.outlook.com>
References: <20190627173516.2351-1-huangfq.daxian@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4208cd15-4002-480b-3444-08d6fb36e0b8
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2019 19:37:23.4559
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Chaitanya.Kulkarni@wdc.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4664
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks good.=0A=
=0A=
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>=0A=
=0A=
On 06/27/2019 10:35 AM, Fuqian Huang wrote:=0A=
> In commit af7ddd8a627c=0A=
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-m=
apping"),=0A=
> dma_alloc_coherent has already zeroed the memory.=0A=
> So memset is not needed.=0A=
>=0A=
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>=0A=
> ---=0A=
>   drivers/block/skd_main.c | 1 -=0A=
>   1 file changed, 1 deletion(-)=0A=
>=0A=
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c=0A=
> index c479235862e5..51569c199a6c 100644=0A=
> --- a/drivers/block/skd_main.c=0A=
> +++ b/drivers/block/skd_main.c=0A=
> @@ -2694,7 +2694,6 @@ static int skd_cons_skmsg(struct skd_device *skdev)=
=0A=
>   		     (FIT_QCMD_ALIGN - 1),=0A=
>   		     "not aligned: msg_buf %p mb_dma_address %pad\n",=0A=
>   		     skmsg->msg_buf, &skmsg->mb_dma_address);=0A=
> -		memset(skmsg->msg_buf, 0, SKD_N_FITMSG_BYTES);=0A=
>   	}=0A=
>=0A=
>   err_out:=0A=
>=0A=
=0A=