Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190627214738.112614-1-rajatja@google.com>
In-Reply-To: <20190627214738.112614-1-rajatja@google.com>
From:   Gwendal Grignou <gwendal@google.com>
Date:   Thu, 27 Jun 2019 15:15:08 -0700
Message-ID: <CAMHSBOWrzQ6NEDEML-Jk8Y+M5iE6yHXn8FWpUP77VZAV7HGzhQ@mail.gmail.com>
Subject: Re: [PATCH] platform/chrome: lightbar: Get drvdata from parent in suspend/resume
To:     Rajat Jain <rajatja@google.com>
Cc:     Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        rajatxjain@gmail.com, Evan Green <evgreen@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Reviewed-by: Gwendal Grignou <gwendal@chromium.org>


On Thu, Jun 27, 2019 at 2:47 PM Rajat Jain <rajatja@google.com> wrote:
>
> The lightbar driver never assigned the drvdata in probe method, and
> thus there is nothing there. Need to get the ec_dev from the parent's
> drvdata.
>
> Signed-off-by: Rajat Jain <rajatja@google.com>
> ---
>  drivers/platform/chrome/cros_ec_lightbar.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
> index d30a6650b0b5..26117a8991b3 100644
> --- a/drivers/platform/chrome/cros_ec_lightbar.c
> +++ b/drivers/platform/chrome/cros_ec_lightbar.c
> @@ -600,7 +600,7 @@ static int cros_ec_lightbar_remove(struct platform_device *pd)
>
>  static int __maybe_unused cros_ec_lightbar_resume(struct device *dev)
>  {
> -       struct cros_ec_dev *ec_dev = dev_get_drvdata(dev);
> +       struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
>
>         if (userspace_control)
>                 return 0;
> @@ -610,7 +610,7 @@ static int __maybe_unused cros_ec_lightbar_resume(struct device *dev)
>
>  static int __maybe_unused cros_ec_lightbar_suspend(struct device *dev)
>  {
> -       struct cros_ec_dev *ec_dev = dev_get_drvdata(dev);
> +       struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
>
>         if (userspace_control)
>                 return 0;
> --
> 2.22.0.410.gd8fdbe21b5-goog
>