Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 27 Jun 2019 19:00:34 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Olof Johansson <olof@lixom.net>
Cc:     Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: Be lenient about -Wundef
Message-ID: <20190628000033.ipcypg4kny2whfz7@treble>
References: <20190619120337.78624-1-olof@lixom.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20190619120337.78624-1-olof@lixom.net>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 19, 2019 at 05:03:37AM -0700, Olof Johansson wrote:
> Some libelf versions use undefined macros, which combined with newer GCC
> makes for errors from system headers. This isn't overly useful to fail
> compiling objtool for.
> 
> Error as seen:
> 
> cc1: all warnings being treated as errors
> In file included from arch/x86/../../elf.h:10,
>                  from arch/x86/decode.c:14:
> /usr/include/libelf/gelf.h:25:5: error: "__LIBELF_INTERNAL__" is not defined, evaluates to 0 [-Werror=undef]
>  #if __LIBELF_INTERNAL__
>      ^~~~~~~~~~~~~~~~~~~
> 
> For this reason, skip -Wundef on objtool.
> 
> Signed-off-by: Olof Johansson <olof@lixom.net>

Sorry for the delay, I was out last week and I'm still getting caught
up.

Which libelf was this?  I'm guessing it's the old non-elfutils version
which has been unmaintained for 10 years (and which doesn't work with
objtool anyway).

It would be nice if we could figure out a way to detect that libelf and
report a more useful error for it.

-- 
Josh