Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 28 Jun 2019 03:10:13 +0200
From:   Frederic Weisbecker <frederic@kernel.org>
To:     Wanpeng Li <kernellwp@gmail.com>
Cc:     linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2] sched/nohz: Optimize get_nohz_timer_target()
Message-ID: <20190628011012.GA19488@lerouge>
References: <1561682593-12071-1-git-send-email-wanpengli@tencent.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1561682593-12071-1-git-send-email-wanpengli@tencent.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 28, 2019 at 08:43:12AM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <wanpengli@tencent.com>
> 
> On a machine, cpu 0 is used for housekeeping, the other 39 cpus in the 
> same socket are in nohz_full mode. We can observe huge time burn in the 
> loop for seaching nearest busy housekeeper cpu by ftrace.
> 
>   2)               |       get_nohz_timer_target() {
>   2)   0.240 us    |         housekeeping_test_cpu();
>   2)   0.458 us    |         housekeeping_test_cpu();
> 
>   ...
> 
>   2)   0.292 us    |         housekeeping_test_cpu();
>   2)   0.240 us    |         housekeeping_test_cpu();
>   2)   0.227 us    |         housekeeping_any_cpu();
>   2) + 43.460 us   |       }
>   
> This patch optimizes the searching logic by finding a nearest housekeeper
> cpu in the housekeeping cpumask, it can minimize the worst searching time 
> from ~44us to < 10us in my testing. In addition, the last iterated busy 
> housekeeper can become a random candidate while current CPU is a better 
> fallback if it is a housekeeper.
> 
> Cc: Ingo Molnar <mingo@redhat.com> 
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Frederic Weisbecker <frederic@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>

Reviewed-by: Frederic Weisbecker <frederic@kernel.org>

Thanks!