Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 27 Jun 2019 20:53:26 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Michael Forney <mforney@mforney.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org,
        elftoolchain-developers@lists.sourceforge.net
Subject: Re: [PATCH 1/2] objtool: Rename elf_open to prevent conflict with
 libelf from elftoolchain
Message-ID: <20190628015326.z64wbie7ex5pfs2v@treble>
References: <20190616231500.8572-1-mforney@mforney.org>
 <20190628002208.v6brs6b6hf7b6sth@treble>
 <CAGw6cBuaMoZQK-hV+Ztg5uFqPU3dY6L7um1bzsxVPQfaX4JA7g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAGw6cBuaMoZQK-hV+Ztg5uFqPU3dY6L7um1bzsxVPQfaX4JA7g@mail.gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 27, 2019 at 05:52:53PM -0700, Michael Forney wrote:
> On 2019-06-27, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > On Sun, Jun 16, 2019 at 04:14:59PM -0700, Michael Forney wrote:
> >> Signed-off-by: Michael Forney <mforney@mforney.org>
> >> ---
> >>  tools/objtool/check.c | 2 +-
> >>  tools/objtool/elf.c   | 2 +-
> >>  tools/objtool/elf.h   | 2 +-
> >>  3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > Sorry for the delay, I was out for a bit and I'm still trying to get
> > caught back up on email.
> 
> No worries :)
> 
> > These patches look fine.  I'll try to send them on to the -tip tree
> > shortly.
> 
> Thanks!
> 
> > Just curious, have you done much testing with the elftoolchain version
> > of libelf and objtool?  So far objtool has only been successfully used
> > with the elfutils version, so I'm just curious how compatible your
> > libelf is with the elfutils version.
> 
> I'm not affiliated with elftoolchain, I am just trying it out on my
> system as an alternative to elfutils libelf for its clean codebase
> that doesn't use many GNU C extensions.
> 
> I've done some basic testing to make sure that the .o files after
> being processed with `objtool generate --no-fp --retpoline` match
> between elfutils and elftoolchain. I noticed two differences, one of
> which was due to a bug in elftoolchain that has since been fixed, and
> the other is with the offset of SHT_NOBITS section after rewriting[0],
> which I think doesn't matter.

Awesome, that gives me a lot more confidence.  Thanks!

-- 
Josh