Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2777140ybd; Thu, 27 Jun 2019 19:41:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqxIzVVrweVcj8pQNEdUHo++TKHOZjI8RFstj9XnRML4CAdqUxknczts+WPGEy57JD87pI9M X-Received: by 2002:a17:902:e582:: with SMTP id cl2mr8683318plb.60.1561689697513; Thu, 27 Jun 2019 19:41:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561689697; cv=none; d=google.com; s=arc-20160816; b=e9qCyM588F8o84Tg2RIO68JrMqGFFlZcy61zJPVSuqu2UL1Ov/BidkqjgUHPZicqMg kbk3oBLEU6CRFwHzxuZEbrjN/JLmxlWOGhqjwyGNUFFDk7nHphM/4DH8EU6hR1X4CW0l 23LsWVJIvLCqH7P6X+TuJ74M5/N+2oD3+h15mUk5EReFBy9Kej2ZHbM6fl3HjcGsoWT/ LfoxxR2gLtl2VA0kPchofoHQ1PgPESiajAXK1tdtQr8aI40z6+UdC91SF0j2VzUhMvyU B1gy2+Yi939QAxUBK85kFzPdj+1MhMVoL9g5mIbHERwbhOekTMKCq/g1bYVetdmHwGDN 7SqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=ADqhvifrknPuzOYzjNxXRssrypRVqiE51aZTMCvODu0=; b=CiMa/ZPUpXFJQ8mMEVwuFE6+UgAtWVMcjkyIxPTF9G5gGmR3kHf5yJYsTKlZVo68tc djVEuVJEyz/z6bqFDjsXvGCmx9EvVe75XnNnCbqKq4LYYyuMJktQBMspRQW85j8YJg6N NUgftYbQ8QrfGoqIUv6NawjP3B8YrE5YQ8zrQqrJzulSL3goI9chft3mmqsLcfZDixl8 sGO9lv7a+AWEjHhsCMPRsuSI+Kr2hBoDANR+wb9fnt7+JkE1jPIFpVQQmN/KjbiMK6oo DBEHQ8R+DMfuW0mVur+1bUO3RcacpqWgcMDIGunuwRDLup0t3ErWjOi5HrkxJ3+rRO6G 8XFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@aj.id.au header.s=fm3 header.b=ZFUpCXQy; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b="TcvD6wq/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e65si830330pgc.454.2019.06.27.19.41.21; Thu, 27 Jun 2019 19:41:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@aj.id.au header.s=fm3 header.b=ZFUpCXQy; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b="TcvD6wq/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727031AbfF1Cjn (ORCPT + 99 others); Thu, 27 Jun 2019 22:39:43 -0400 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:50689 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726748AbfF1Cjm (ORCPT ); Thu, 27 Jun 2019 22:39:42 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 7E9093483; Thu, 27 Jun 2019 22:39:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 27 Jun 2019 22:39:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm3; bh=ADqhvifrknPuz OYzjNxXRssrypRVqiE51aZTMCvODu0=; b=ZFUpCXQy6B8uj0ca88kY34wx9NsTW nUjr5VFG7dhZvf8CVFBWzSbgULrOcaxoe9sNPrLvUaj+oL3FhA06vVh5xgVPsG8K 2j4bbWRrw3sheZhasI/Nw5SaE5C58EESA13xOH5kbckMjZIbSs8d50Tkoe5DMFjT GlVs7J1IgpNS6nWgcpVCz6EMZkLGatXOD/mjn4Pqzverr4M+aVDD63hs/SOwxeEV gdI7TTIuf4TEDXNdiJ3EdfRe/caTjxuRlT2lXEpnevJJ1IF5XgE/bDtgdJtjC0dM kIFhPUQOcC/3oHliOUQ2658UQwORvn33ROO/qzypdW3bMwgCvetbg5r/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=ADqhvifrknPuzOYzjNxXRssrypRVqiE51aZTMCvODu0=; b=TcvD6wq/ aS2ba3+jDjzka/vzn1IAo8Td4r8TE0/t1pxAaI4c5PRB6DYCbyNwz3cXMpGglyWB iz3OLf+Pd/LmyRKVkPL5Ib9Vs6expRxAJEArw7gWTuLoMiE+lJPwn6K4OpudHOoH FykfS3L496SpeQ4dyeNqOIUob3cTOln2H75YU2p5/BGgcf0FkL0r3qb/RBWojZlV Ie6aaPzonmsl3ViqvAvn90SeFDigpr75qT67pBCX9QcGMPX6NIfdQE4IAxwF9Iui +gSw43orPBJndzNTohgMwaLIxQ1dd62Q3+sZl2t0XM2P58/olpFkF07NwdtV1R/2 lzfTh3/QlwJbfQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudelgdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomheptehnughrvgif ucflvghffhgvrhihuceorghnughrvgifsegrjhdrihgurdgruheqnecukfhppedvtddvrd ekuddrudekrdeftdenucfrrghrrghmpehmrghilhhfrhhomheprghnughrvgifsegrjhdr ihgurdgruhenucevlhhushhtvghrufhiiigvpeef X-ME-Proxy: Received: from mistburn.au.ibm.com (bh02i525f01.au.ibm.com [202.81.18.30]) by mail.messagingengine.com (Postfix) with ESMTPA id 3F15A380074; Thu, 27 Jun 2019 22:39:37 -0400 (EDT) From: Andrew Jeffery To: linux-gpio@vger.kernel.org Cc: ryan_chen@aspeedtech.com, Andrew Jeffery , linus.walleij@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, joel@jms.id.au, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Johnny Huang Subject: [PATCH v2 6/8] pinctrl: aspeed: Clarify comment about strapping W1C Date: Fri, 28 Jun 2019 12:08:36 +0930 Message-Id: <20190628023838.15426-7-andrew@aj.id.au> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190628023838.15426-1-andrew@aj.id.au> References: <20190628023838.15426-1-andrew@aj.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Writes of 1 to SCU7C clear set bits in SCU70, the hardware strapping register. The information was correct if you squinted while reading, but hopefully switching the order of the registers as listed conveys it better. Cc: Johnny Huang Signed-off-by: Andrew Jeffery Acked-by: Joel Stanley --- drivers/pinctrl/aspeed/pinctrl-aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c b/drivers/pinctrl/aspeed/pinctrl-aspeed.c index 4c775b8ffdc4..b510bb475851 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c @@ -209,7 +209,7 @@ static int aspeed_sig_expr_set(const struct aspeed_sig_expr *expr, if (desc->ip == ASPEED_IP_SCU && desc->reg == HW_STRAP2) continue; - /* On AST2500, Set bits in SCU7C are cleared from SCU70 */ + /* On AST2500, Set bits in SCU70 are cleared from SCU7C */ if (desc->ip == ASPEED_IP_SCU && desc->reg == HW_STRAP1) { unsigned int rev_id; -- 2.20.1