Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2812328ybd; Thu, 27 Jun 2019 20:34:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqwtF9vdKs85P+ZTp+w4pLlTim25mU1UlchXbu/2lbdHf6KFbnXdr6XNewh1M8wgAuOdp9xG X-Received: by 2002:a17:902:724:: with SMTP id 33mr8608654pli.49.1561692866368; Thu, 27 Jun 2019 20:34:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561692866; cv=none; d=google.com; s=arc-20160816; b=ko/V+0QCog1BHUGrkfaLRrgvmztRVdaLZTYgtNp3jL8uxuO+khXdQIHpo9SmqBHKrO ZJ+E867U0C/ph5XUtSdkyL1SdU244KEDKVgLiZy3Fc8dm5AE7wh2E5qkDDsgxPt+mESt RnL1PchlDJ79Z7UeWo8UxmrPoq88HTRBg/W7YVWJbzvXpOWqp3miZkTynSFk1iI1AX25 WTmbjquzGYv0XdtTnsNAjNs2Hcb3JfbC5P3N+2DTN0+RyHXcLqyTcIO8ikkKbf79ThHu fRlhHxyF9FZw2w/rem+Ee3c6i9ru9qPTmK9d7FlNe9ly6Id7L5c+cCrnMzNFyDttz8DT GY2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=s1RS6E5PRN57yOy1tYlbByux0wGDN3f2cPvXBUEANB4=; b=uFHTKon04KryclXEIeEqNF+oamPX5+sTETSo/3ef+64aRevuKnjWk1prbCGI2NER+x 0UmBgWdK3Gl7+PPL/0DOvFi9HCyVPIqzEBkafuGj3ZiOGVIeyX0/SQ07qIRsFUsVGm5M Uw4U1Jq1Z7VvKHDlqPzixkiNKZc1ZOtrfso1mTnTRs9G58jIF7o3VCxHPcqPrP3BxR8c mSN4x2GDYaKBTR4lZlZPEaJXCDHm0uh5zFP2E0hlLyImwPUw2Bhhef+U24tdQUyO8NaD tqtAucTu2MBQcSHDjXUJ32CYHjPxFAZthWgY0ibExGuV8ARpsxMnxsKSu5XJp8yZJeub HP/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@endlessm-com.20150623.gappssmtp.com header.s=20150623 header.b="j3/vYyma"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1si967065pjw.85.2019.06.27.20.34.10; Thu, 27 Jun 2019 20:34:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@endlessm-com.20150623.gappssmtp.com header.s=20150623 header.b="j3/vYyma"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727131AbfF1Ddo (ORCPT + 99 others); Thu, 27 Jun 2019 23:33:44 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:41421 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726686AbfF1Ddo (ORCPT ); Thu, 27 Jun 2019 23:33:44 -0400 Received: by mail-qk1-f194.google.com with SMTP id c11so3651231qkk.8 for ; Thu, 27 Jun 2019 20:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessm-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s1RS6E5PRN57yOy1tYlbByux0wGDN3f2cPvXBUEANB4=; b=j3/vYymaGTY9IcV7GL0KLyubMvndda1C3iUYZ0W7l9Rp3vx498JPcHm+V8Tu9f62K7 AevWXDphCYvjoCdVwStXWF1ZNysAQbovt5ya3UZbmERkHpXc0qKLuHLhuTUNfeim+4uZ zKE3k8KMtKLAxa7YO4+w8rYo9FMTk+8D8/MxuetQHwoJZLWOGiiAokkwr2kvLWrnpl67 o+bHa6cPsnMxQlhsLgdQFXT4AWL4yP8tyZv5M4MOfGj8CSqMwJorqgOwMIv5tKR+VaId qxHV7+Ax2NfcB7fPSPvEzsloH0l5angQ5LoykG1rms61R+yfD+kyKF+OT7y9Gc91HcLN zMRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s1RS6E5PRN57yOy1tYlbByux0wGDN3f2cPvXBUEANB4=; b=Me3PjbpsXiIJMI4EyOEGpZR2X2IjFIfffY4+hf0QwyKD8c21UKLvpANNnodrotKF60 CaQKJYNkMmBy+LVCfc+Mjt+pv502acvcuRn7UjwjXWWaRHlJ3v86Ko37pLoaN867g7vd NqIpsKEYReFKmNduckNV0mOdzVjAqTG1FzHFniefov+K5YAc5FMntmhs0Uk6ACzNPJrK 8Y4LcVc2iJFPpGRQDagS4iWi7YiDfvcSHY+rd33+9Hdpl5BMHvQZfoO/EDuDe66NN5+Q taUFThcBkIgSnDQYLK6NCNobefkS2TUTzT45vraWsFOzAfANWEX7IIuMeJUhO4gQbISb d2hw== X-Gm-Message-State: APjAAAW1RwdtmBgxZf6n40y9iezspcBVN/+ecL7Q3rdl+TJL2h4H4BnQ u2I2u9g/PxonTmkcBHeFD61ajzctF0hw0CtrDUKF4Q== X-Received: by 2002:a37:9c88:: with SMTP id f130mr6652703qke.457.1561692822897; Thu, 27 Jun 2019 20:33:42 -0700 (PDT) MIME-Version: 1.0 References: <20190627085419.27854-1-drake@endlessm.com> In-Reply-To: From: Daniel Drake Date: Fri, 28 Jun 2019 11:33:31 +0800 Message-ID: Subject: Re: No 8254 PIT & no HPET on new Intel N3350 platforms causes kernel panic during early boot To: Thomas Gleixner Cc: Linux Kernel , Ingo Molnar , Borislav Petkov , Hans de Goede , david.e.box@linux.intel.com, Linux Upstreaming Team , "Wysocki, Rafael J" , x86@kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 27, 2019 at 10:07 PM Thomas Gleixner wrote: > Nah. That extra timer works thing is just another bandaid. > > What I had in mind is something like the below. That's on top of > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/apic > > Be warned. It's neither compiled nor tested, so keep a fire extinguisher > handy. If it explodes you own the pieces. Thanks, it works, and makes sense! I'll add a commit message and send it as a patch, just one quick function naming question... did you mean apic_and_tsc_needs_pit() or apic_needs_pit()? That's the only compile fix needed. Daniel