Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1561624486-22867-1-git-send-email-yash.shah@sifive.com> <alpine.DEB.2.21.9999.1906270911270.12689@viisi.sifive.com>
In-Reply-To: <alpine.DEB.2.21.9999.1906270911270.12689@viisi.sifive.com>
From:   Yash Shah <yash.shah@sifive.com>
Date:   Fri, 28 Jun 2019 10:25:47 +0530
Message-ID: <CAJ2_jOGVJotV73YP9JTr4hDDWgH-Jr6Cfn2Pscx49wR78JocNg@mail.gmail.com>
Subject: Re: [PATCH] riscv: ccache: Remove unused variable
To:     Paul Walmsley <paul.walmsley@sifive.com>
Cc:     linux-riscv@lists.infradead.org,
        "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>,
        Palmer Dabbelt <palmer@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Sachin Ghadi <sachin.ghadi@sifive.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 27, 2019 at 9:43 PM Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
> On Thu, 27 Jun 2019, Yash Shah wrote:
>
> > Reading the count register clears the interrupt signal. Currently, the
> > count registers are read into 'regval' variable but the variable is
> > never used. Therefore remove it.
> >
> > Signed-off-by: Yash Shah <yash.shah@sifive.com>
>
> This is a good start.  Could you also add comments in the code that
> describe what those reads are doing, as you did in the patch description?
> Otherwise they look pretty mysterious.
>

Sure, will add comments and send v2

>
> - Paul