Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2903840ybd; Thu, 27 Jun 2019 22:48:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqzeApKKXmO5l7Up60mhnqh8+5IilH53SC1jwfOueqNFXVgTuWtmmay1yVdKrlUAFRKGS/Je X-Received: by 2002:a63:10a:: with SMTP id 10mr7681792pgb.263.1561700907280; Thu, 27 Jun 2019 22:48:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561700907; cv=none; d=google.com; s=arc-20160816; b=K0jSk6jpGTceJqy4tJ3FEWnU3oqI30c+TPx64iE3o1TEiACtaapz1/4HdDu7xjd9Hg LIlhcqsgR3GRWGlnkT7TUaVXPKF2fQizxcHScpByFrYsVHxGfluN1Kn7hnDsUZY7UWdW 6fxb8ZYoRw200ZIQ4MJCaiCFGajIbwRlwM4DGnQgw+MHfH2z/rvxZQTv9ajtAf5g/Ql8 BpEunHgk2xU6Ylcf7paidU8oTG+3aBjlMPqbhdlXodMLfut5oRZhpn+uEQANZ28emNlt SfkHDmm7Dy5xhgwS4S3XBHrvyK3A6m6z6g15k5PC7USwHSCHMuw201Zfd2PQ2r1jnLeM rCkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=JonNVAGavnRlJhh68LVsFtVqprQdtcLj2PTjdYw2e9k=; b=XoQUyPWUVSE/VOfV50i5EQhPwYLeplDywvnJQTC4BxJRpXA3Fh+cp+XkGmP0Q2dcLd x4z5YRS9ih9E1ccb8ir7JTXAxnOEzkRnZ30nJvCo/dBq4vtqrJStM/e0hX01gn7VzrBe YCz4n93FkvVG4n3iNndw+pROBgc6NuuzWocKF69uo2iAfFC297hDZjkLzoCaNcOOKd+B I4Fd5gKRHDjvvEsA1qRoA202lkgrJyfpDUu0aMzpGKdXlhPad2CCH5SYS+weAj9xeEGK s1QIR9+z6UmNqdrTeXE6/EhlgxCNGJxrYpHjJSbeavml4NrIPXjhvldVJo+qpf8kFCno GbRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=lmpx8dS8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w9si1107055pgr.250.2019.06.27.22.48.10; Thu, 27 Jun 2019 22:48:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=lmpx8dS8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727015AbfF1Frj (ORCPT + 99 others); Fri, 28 Jun 2019 01:47:39 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:43484 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726645AbfF1Frj (ORCPT ); Fri, 28 Jun 2019 01:47:39 -0400 Received: by mail-io1-f65.google.com with SMTP id k20so9964914ios.10 for ; Thu, 27 Jun 2019 22:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=JonNVAGavnRlJhh68LVsFtVqprQdtcLj2PTjdYw2e9k=; b=lmpx8dS8SmmI+bod4CIGHygIhMfXqrGVR8dl/YJdRJFestIpTr/2lSxlvkarvtECIz jx6ZaHJ4aIqG/48rZvDj+pl6lnRoAg9OZ9mxYeLRu+N9SYpUGe3wfh4MU68CNNoASNHc CGNxA2syIdCf+HG0oxmfLEi5SFjUdX3hg9TniJxA+g7sQYNxfgMtpYyJie9GQC9bxwvC cReJnEEoKLA8nTHOoZ5SvxX9pXWN/Xc6nNnzVxLP0Q0BGFsjFwe1RkKw61gfOyGVyCmv qoJTVQu/+2v//+Sk7Cwc3qJ9hw8ZgudhaYDERLiqQNqOdyIAwuu6iSAeKjQ6bW/nLZQu bTRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=JonNVAGavnRlJhh68LVsFtVqprQdtcLj2PTjdYw2e9k=; b=YBY9kA8rJSU72AXWq7YRR47CMl1H51LDfIU8c4o5kT7YwSkWEtZkEsQJ19HHwlD6Cy G7D9fCAZ8VG77/YhE5+Ah/5RptCEhmSS8uV67rjIxWUl+mLncAINyIUHtXBQP5huNasO 7JBdQulTgV+rFvUjm+hpOothBOJTn5+LRSGRAH8tDl8XxHb6LI8r7GtssvYWZ1W/akeb /gHSTat4+x4kQvQGsYSM8GOyHA5IQ2LN42EGiPMCk+xltoY4kzQgx6OgZHJXO9uN2tRm tlRjtgMsWjSF8xfl1gQ/i2gaD3cfL7HRuIKyP1TmnUnnOX/OYkcu7wywnDSVUUV+ERu+ V81A== X-Gm-Message-State: APjAAAUgSAkdJrA4zVi72nKvjl8sKS3YNnMsMBQW80lG3lE3aJspf9qV XC5RxOA8Jw8EmGZbMfaBFWHHIA== X-Received: by 2002:a5d:8195:: with SMTP id u21mr9407119ion.260.1561700858671; Thu, 27 Jun 2019 22:47:38 -0700 (PDT) Received: from localhost (c-73-95-159-87.hsd1.co.comcast.net. [73.95.159.87]) by smtp.gmail.com with ESMTPSA id t4sm1064999ioj.26.2019.06.27.22.47.38 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 27 Jun 2019 22:47:38 -0700 (PDT) Date: Thu, 27 Jun 2019 22:47:37 -0700 (PDT) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: Atish Patra , Ingo Molnar cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Albert Ou , Thomas Gleixner , Kees Cook , Changbin Du , Anup Patel , Palmer Dabbelt , "maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT" , linux-mm@kvack.org, Borislav Petkov , Vlastimil Babka , Gary Guo , "H. Peter Anvin" , Andrew Morton , linux-riscv@lists.infradead.org, Luc Van Oostenryck Subject: Re: [PATCH v3 1/3] x86: Move DEBUG_TLBFLUSH option. In-Reply-To: <20190429212750.26165-2-atish.patra@wdc.com> Message-ID: References: <20190429212750.26165-1-atish.patra@wdc.com> <20190429212750.26165-2-atish.patra@wdc.com> User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Apr 2019, Atish Patra wrote: > CONFIG_DEBUG_TLBFLUSH was added in > > 'commit 3df3212f9722 ("x86/tlb: add tlb_flushall_shift knob into debugfs")' > to support tlb_flushall_shift knob. The knob was removed in > > 'commit e9f4e0a9fe27 ("x86/mm: Rip out complicated, out-of-date, buggy > TLB flushing")'. > However, the debug option was never removed from Kconfig. It was reused > in commit > > '9824cf9753ec ("mm: vmstats: tlb flush counters")' > but the commit text was never updated accordingly. > > Update the Kconfig option description as per its current usage. > > Take this opportunity to make this kconfig option a common option as it > touches the common vmstat code. Introduce another arch specific config > HAVE_ARCH_DEBUG_TLBFLUSH that can be selected to enable this config. Looks like this one still needs to be merged or acked by one of the x86 maintainers? - Paul