Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2962947ybd; Fri, 28 Jun 2019 00:05:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqziZvxmaXfo2rPilimwAWWfTZEul+ALocHAXWmCQjfp8oR9vgAHtyXQU1/T0T60Lsn0gtYy X-Received: by 2002:a63:4c46:: with SMTP id m6mr8019276pgl.59.1561705550172; Fri, 28 Jun 2019 00:05:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561705550; cv=none; d=google.com; s=arc-20160816; b=X3iLB8aUSPQ5FF3U7YMA4WqUM650xYSeJmbGuqTPv6aVfFxKoKJ3bSFQsywbbeMXoK 3M2xyK+kPjHrMWLfft165d+rtSf9Nirm3431zprXsSZXYijby8G1m+wqzKDTkh8f8ZNQ DVOCv7tMcIH3qA7XdvCxte6xtokKt/GCv3dGOfHNn3elVgxAhBYtFPUQTkN3IKYWFTWQ rEF8BNGa1zoTOVACkSyrHqUIBdchM00BOXR1wqH9uFCfgSFv4siLxKmysFVLu0tS5QOL L2aRNEBpP8w+RJAy8NvNwr5uedjSlHMdm0LWA7DlhWhJ6nw5Mhkq4CJqWyFpfaXnlnsA Uy0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=35mxTyFUTGV4FdEESvJ+H8/XumncAvi6y3GQ0TEdL7s=; b=LCVkLueI/B/Ihg42XGSEx/Ger0feQBOFtAJC0l+pZuH+6K0ouvHh6xpWaVM3wuV/yf ZnLmbNdCexXu86b/5s2V1+wtoYuqGBB+eEA6sokUaywGZbn1KVsNmTnbGIfu2FWfA4LB dMwfUH5Jvj0xjjGnGG/pK7/MIN4kuFzo1TFG8VnTzMaDxv4UxJSKx85sobpVa6ODwltu YwK0vVS5JRGD7yOaVFgVMOswl6akNhb1i2OBlD+zZ4tXW3DTRJqjM9OacRwUCbXVIl9a xcv/+qjrQZU6S7wLntikKtcrpfHg8tFYBOO5fJ8DtwIQZetvuiRxjWqOvStrTB7BQyp3 t2Vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NN+rYYnl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z61si1332214plb.19.2019.06.28.00.05.33; Fri, 28 Jun 2019 00:05:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NN+rYYnl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727100AbfF1HFM (ORCPT + 99 others); Fri, 28 Jun 2019 03:05:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:38876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726648AbfF1HFM (ORCPT ); Fri, 28 Jun 2019 03:05:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75CCA204EC; Fri, 28 Jun 2019 07:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561705511; bh=5fkzHE/or/BO94Lut0W45FpjZpard5Gpc23HG0C1h6o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NN+rYYnlxvQr/pH2B8u53CEDmV68MlIT++3BNUr+YE7CvnRFQXtFrYK/xl82nlId+ c7rUEEImQUxLdARAmWxSCm1/gAbE2JuybZtf00IDL7ben/NUWXKpePorOD8cX8d4bc 1LvWrApkYFMWxcKH3hMMxk3aydWQaP/lnukwt6lI= Date: Fri, 28 Jun 2019 09:05:07 +0200 From: Greg KH To: Harsh Jain Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, harshjain.prof@gmail.com Subject: Re: [PATCH] staging:kpc2000:Fix sparse warnings Message-ID: <20190628070507.GA10932@kroah.com> References: <20190627185138.26214-1-harshjain32@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190627185138.26214-1-harshjain32@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 28, 2019 at 12:21:38AM +0530, Harsh Jain wrote: > From: root Interesting user name :) > Fix following sparse warning > symbol was not declared. Should it be static? > Using plain integer as NULL pointer Don't do multiple things in the same patch. Please break thsi up into two different patches and fix up your email address. Also never do kernel development as root on your system, it's easy to break things... thanks, greg k-h