Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 28 Jun 2019 08:44:38 +0000
From:   Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To:     Wanpeng Li <kernellwp@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Frederic Weisbecker <frederic@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH RESEND v3] sched/isolation: Prefer housekeeping cpu in
 local node
Reply-To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
References: <1561682593-12071-1-git-send-email-wanpengli@tencent.com>
 <1561682593-12071-2-git-send-email-wanpengli@tencent.com>
 <20190628065802.GA27699@linux.vnet.ibm.com>
 <CANRm+Cz4R5OOga34DDepCP_yOtXXCqTxD8bs_rvgtQbjS8d1hw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <CANRm+Cz4R5OOga34DDepCP_yOtXXCqTxD8bs_rvgtQbjS8d1hw@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Message-Id: <20190628084438.GA22550@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> 
> -#endif /* CONFIG_NUMA */
> -
>  /*
>   * sched_numa_find_closest() - given the NUMA topology, find the cpu
>   *                             closest to @cpu from @cpumask.
>   * cpumask: cpumask to find a cpu from
>   * cpu: cpu to be close to
>   *
> - * returns: cpu, or >= nr_cpu_ids when nothing found (or !NUMA).
> + * returns: cpu, or nr_cpu_ids when nothing found.
>   */
>  int sched_numa_find_closest(const struct cpumask *cpus, int cpu)
>  {
> -#ifdef CONFIG_NUMA
>      int i, j = cpu_to_node(cpu);
> 
>      for (i = 0; i < sched_domains_numa_levels; i++) {
> @@ -1754,10 +1751,11 @@ int sched_numa_find_closest(const struct
> cpumask *cpus, int cpu)
>          if (cpu < nr_cpu_ids)
>              return cpu;
>      }
> -#endif
>      return nr_cpu_ids;
>  }
> 
> +#endif /* CONFIG_NUMA */
> +
>  static int __sdt_alloc(const struct cpumask *cpu_map)
>  {
>      struct sched_domain_topology_level *tl;
> 

Looks good to me.

Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

-- 
Thanks and Regards
Srikar Dronamraju