Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190621111352.22976-1-pawel.mikolaj.chmiel@gmail.com>
In-Reply-To: <20190621111352.22976-1-pawel.mikolaj.chmiel@gmail.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Fri, 28 Jun 2019 11:28:11 +0100
Message-ID: <CACRpkdYD7Z7XX9wXFtBehJG_4NCt=m_MNsR5cESPRnO3tomKmQ@mail.gmail.com>
Subject: Re: [PATCH v2 0/2] extcon: Add fsa9480 extcon driver
To:     =?UTF-8?Q?Pawe=C5=82_Chmiel?= <pawel.mikolaj.chmiel@gmail.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Donggeun Kim <dg77.kim@samsung.com>
Cc:     MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 21, 2019 at 12:14 PM Pawe=C5=82 Chmiel
<pawel.mikolaj.chmiel@gmail.com> wrote:

> This small patchset adds support for Fairchild Semiconductor FSA9480
> microUSB switch.
>
> It has been tested on Samsung Galaxy S and Samsung Fascinate 4G,
> but it can be found also on other Samsung Aries (s5pv210) based devices.
>
> Tomasz Figa (2):
>   dt-bindings: extcon: Add support for fsa9480 switch
>   extcon: Add fsa9480 extcon driver

This is surely an important driver since almost all elder Samsung
mobiles use this kind of switch. So
Acked-by: Linus Walleij <linus.walleij@linaro.org>

This driver I see is already sent to Greg for inclusion in the next kernel.
I just wonder if you guys are even aware of this driver for the same
hardware added by Donggeun Kim in 2011:
drivers/misc/fsa9480.c

That said I am all for pulling in this new driver because it is surely
better and supports device tree.

But can we please also send Greg a patch to delete the old driver
so we don't have two of them now?

The old driver have no in-tree users so it can be deleted without
side effects. Out-of-tree users can certainly adapt to the new
extcon driver.

If you want I can send a deletion patch for the misc driver?

Yours,
Linus Walleij