Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] platform/chrome: lightbar: Get drvdata from parent in
 suspend/resume
To:     Rajat Jain <rajatja@google.com>,
        Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        linux-kernel@vger.kernel.org, rajatxjain@gmail.com,
        evgreen@google.com, gwendal@google.com
References: <20190627214738.112614-1-rajatja@google.com>
From:   Enric Balletbo i Serra <enric.balletbo@collabora.com>
Message-ID: <b34fb026-7924-204c-99ed-7e2a5a8ebc87@collabora.com>
Date:   Fri, 28 Jun 2019 12:50:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.1
MIME-Version: 1.0
In-Reply-To: <20190627214738.112614-1-rajatja@google.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 27/6/19 23:47, Rajat Jain wrote:
> The lightbar driver never assigned the drvdata in probe method, and
> thus there is nothing there. Need to get the ec_dev from the parent's
> drvdata.
> 
> Signed-off-by: Rajat Jain <rajatja@google.com>

Queued for 5.3

Thanks,
~ Enric

> ---
>  drivers/platform/chrome/cros_ec_lightbar.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
> index d30a6650b0b5..26117a8991b3 100644
> --- a/drivers/platform/chrome/cros_ec_lightbar.c
> +++ b/drivers/platform/chrome/cros_ec_lightbar.c
> @@ -600,7 +600,7 @@ static int cros_ec_lightbar_remove(struct platform_device *pd)
>  
>  static int __maybe_unused cros_ec_lightbar_resume(struct device *dev)
>  {
> -	struct cros_ec_dev *ec_dev = dev_get_drvdata(dev);
> +	struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
>  
>  	if (userspace_control)
>  		return 0;
> @@ -610,7 +610,7 @@ static int __maybe_unused cros_ec_lightbar_resume(struct device *dev)
>  
>  static int __maybe_unused cros_ec_lightbar_suspend(struct device *dev)
>  {
> -	struct cros_ec_dev *ec_dev = dev_get_drvdata(dev);
> +	struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
>  
>  	if (userspace_control)
>  		return 0;
>