Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3286032ybd; Fri, 28 Jun 2019 06:07:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqwFnJESXTUbyF9dSRTScw0BmhsryaCRIo/pSwfpxzCrL5B1FTWImgagpdAeSava6C8a4mU4 X-Received: by 2002:a17:902:27a8:: with SMTP id d37mr11516142plb.150.1561727258760; Fri, 28 Jun 2019 06:07:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561727258; cv=none; d=google.com; s=arc-20160816; b=KHlhvUUx0t0vEN732Fdy0nznL4vRmCC1K8e5VoMvOko5n7sQ5dS6JbI1kT4Xoqq7OO nAk2wm6fvAi6FNbRQfAGizw8imxpTOEiktqkYzAbjoAg/bL7NzLHFbAPiYVgDaj2lQMu G8VRNjwjL7k2JF8tEVHsWrT4CM8LVE6yWLvVKHWJ8bBUp8bl20VEOFM9YOeuQWoNPEeD ND8EGS8RZ4ni89PnwGhH+mfA0yY24iQ8aurxEzQrLR8Sm3+dfYGJGPN0bozlOjMDKgV4 kr4E1ADlX7jZjSWkZl0uOtXtWJr5jJL4NQu5lBk2shlG18BZxYpAZ/iaxjnDeN2QTVvd 4fKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:cms-type :content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:cc:to:subject:dkim-signature :dkim-filter; bh=rWxubnWiCrnKKpD3KuP7hRM5Nr2cC/zOuIm0vZ7Q72E=; b=hfYQy1QbTOHdpfGQf3BO+UOUxOEWxDd9oyJveWI+hsHM5l3mDpLZQIUtdZVmsS5FWh jOKfIGg1zWlN9lWkUUX6CdGeOV4bXbKPpLiZnBnAD98BlIAWOr4cqnPNsV4EJUtm/81C iGAkYKvFXU7YAyYk6QgDmsInRCjR0hBLHkdXn6UMhxWCBNfdWhCVtMCV2oeXB+X15otN Yutm95r+JX4m29j7oh8GvXUG9PVpuKGKaj406vg80kwGejahEcQF0R4PMjHI7llYP09G MscHb6luCHEPkvVjrZ5mwkWzKsH7Ds7O0u1BljvDNfIgR3H/03n5TypyTxZ6brbuwDjR 9iAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=ekyMNEE3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g6si2454606plj.110.2019.06.28.06.07.09; Fri, 28 Jun 2019 06:07:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=ekyMNEE3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727154AbfF1NFa (ORCPT + 99 others); Fri, 28 Jun 2019 09:05:30 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:32888 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726889AbfF1NF3 (ORCPT ); Fri, 28 Jun 2019 09:05:29 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190628130528euoutp02442e43bbd5e014d883ba971640bfaa0a~sXoyE2c4s1239512395euoutp02G for ; Fri, 28 Jun 2019 13:05:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190628130528euoutp02442e43bbd5e014d883ba971640bfaa0a~sXoyE2c4s1239512395euoutp02G DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1561727128; bh=rWxubnWiCrnKKpD3KuP7hRM5Nr2cC/zOuIm0vZ7Q72E=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=ekyMNEE3qwH48oqMn3kkjdgCtSpQJkl/7JLHNkjwUkMYUA5TZBvw6OAg4EoiplkSo yvEaVvivaqoM60I2VKdwy6vVLhGXDEKjcQs3tJT0tZtzKFNN3UI6O7R4KdO3eFl09p RihX30ge6CKBqE9/fSFZNjTCuaY5d4KtOC/m7fts= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190628130527eucas1p1b29f1b6f0c5e551d2bdd2a587f007d90~sXoxbp7q10066100661eucas1p1h; Fri, 28 Jun 2019 13:05:27 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id D6.96.04298.790161D5; Fri, 28 Jun 2019 14:05:27 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20190628130526eucas1p148997ada085ac993a52e762731705bcf~sXowpVQqC1655616556eucas1p1-; Fri, 28 Jun 2019 13:05:26 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190628130526eusmtrp1b77d1985ada884e62637836f7f110899~sXowosGgn2135421354eusmtrp1n; Fri, 28 Jun 2019 13:05:26 +0000 (GMT) X-AuditID: cbfec7f2-f2dff700000010ca-d6-5d161097c05a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id E0.5C.04146.690161D5; Fri, 28 Jun 2019 14:05:26 +0100 (BST) Received: from [106.120.51.71] (unknown [106.120.51.71]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190628130526eusmtip1c02cdefee6234ed3f9e46e109bd12d01~sXowApqw-1221012210eusmtip1z; Fri, 28 Jun 2019 13:05:26 +0000 (GMT) Subject: Re: [PATCH 11/12] fbdev: da8xx-fb: drop a redundant if To: Bartosz Golaszewski Cc: Sekhar Nori , Kevin Hilman , Lee Jones , Daniel Thompson , Jingoo Han , David Lechner , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Bartosz Golaszewski From: Bartlomiej Zolnierkiewicz Message-ID: <9ee5e4f8-8f26-1f3e-cc16-8d10f17431e9@samsung.com> Date: Fri, 28 Jun 2019 15:05:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190625163434.13620-12-brgl@bgdev.pl> Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTcRTH/e3e3V1Xt35N3Y5pRYOKgjRB4pI9LPzjQhRCQVGNWnVR0ans qqVBaWGPWVn5ymVmD7OsVGZp2sOa6arFtAyTUudjSkaW5MweJrndHv73OY/v+Z4DhyYUXdKZ dFRsAq+P1caoKTlZ1fi9aXEeVmqWFNtUrPP8c5Kt7aqi2BcfO2TspVQl+3rkM8Vec+bL2L7K XglrH2lAbPZYiYQ19bZK2acnh6RsS20BxdadqJCEMtzntnQZd7n1nZSrMXbIOFPpMYr7kvlM yrW33qc4e4ZFwlVeOcBZ2qol3LBpdrh8i3z5bj4mKonXB67cIY9sOn4OxaeRe7sKH6NUdJ0w IE8acDA4DqXJDEhOK/A1BLb+cokYOBE4bmaRYjCMoPiV/Z/kx5N60sUKXILgTAEjNg0iGBr5 ilwFL7wKzDmFUhd74wVQVNbpHkvgBgIGWm5QrgKFl8HpI6VuAYNXwlBvultA4nlgNHW62Qdv BntjhVTsmQHP8h1uZ8+JLTorz7rzBFbBW8cFichzoHqwgHCZAU6j4Y61RyauHQa1P2+SInvB B8vtP3l/sGYdJ0VBGYJfR9//UVcjKMkap8SuEKi3vJywoycsFkJ5baALAa8G632NiNOgbXCG uMM0OFOVR4hpBo4eVogz5kPF1Qrqr6uh5jpxCqmNky4zTrrGOOka43/bIkSWIhWfKOgieCEo lt8TIGh1QmJsRMCuOJ0JTfydddzy5S4aebXTjDCN1FOZb1OVGoVUmyQk68wIaELtzfjavDUK Zrc2OYXXx23XJ8bwghn50aRaxezz6NqqwBHaBD6a5+N5/d+qhPacmYrqtvdvLaRvrf80Kzgj e8zj0v6N+CP0XCkuc0QXdT+892vteXs/RikHN959s+GkT1zwgtBRW156oK04Jbehz+5fmtPd MODXXvfgRUh5dr6z5oFS8Ps0XaPaZFg9ahk8YtZNCc8I22ZdOndNpfZDbiajVK5rfuTrXPGj uSOyPCzookFNCpHaoEWEXtD+Bgd0BIlzAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsVy+t/xu7rTBMRiDe626Vl8mXuKxWLXg21s Fmfe3GW3WNQgZnHl63s2ixVfZrJbPN38mMni/tejjBZT/ixnstj0+BqrxYm+D6wWl3fNYbPY 37uByYHX4/2NVnaPxddus3rsnHWX3WPTqk42j0/9J1k97lzbw+Zxv/s4k8fmJfUex29sZ/L4 vEkugCtKz6Yov7QkVSEjv7jEVina0MJIz9DSQs/IxFLP0Ng81srIVEnfziYlNSezLLVI3y5B L+N8z2zGgkaWigfzDjI2MK5k7mLk5JAQMJH4deQwSxcjF4eQwFJGiX1Xu4ASHEAJGYnj68sg aoQl/lzrYoOoec0osePJNVaQhLCAvcShqfPAbBEBdYkF6+4xgRQxCxxnllj4YgpUxwZGiXMv G9hBqtgErCQmtq9iBLF5BewkPjxuBetmEVCVmLXpHpgtKhAhceb9ChaIGkGJkzOfgNmcQKfe 2zwDrIYZaNufeZeYIWxxiVtP5jNB2PIS29/OYZ7AKDQLSfssJC2zkLTMQtKygJFlFaNIamlx bnpusaFecWJucWleul5yfu4mRmCEbzv2c/MOxksbgw8xCnAwKvHwLuASixViTSwrrsw9xCjB wawkwit5TiRWiDclsbIqtSg/vqg0J7X4EKMp0HMTmaVEk/OBySevJN7Q1NDcwtLQ3Njc2MxC SZy3Q+BgjJBAemJJanZqakFqEUwfEwenVAPjxJCcpL8r/HxW5wVu4hU4bPOtalXDj5shT6P2 sjv2vDKdJxyy5sXdr+7mCXNPfLZZ8NXsgiiL3IKO0B3toi2r3ztI/a1YXCs+X/rJza+59gwf 0l81H8iTiyll1J4qtjxn0oENGrsC96ccbe+YIGxzw1Zl0Y1Hkbck79XvOL5v0cewXLUVExft U2Ipzkg01GIuKk4EAK+9F4kGAwAA X-CMS-MailID: 20190628130526eucas1p148997ada085ac993a52e762731705bcf X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190625163508epcas2p1cb472d2ebee0023d5efd777feced0991 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190625163508epcas2p1cb472d2ebee0023d5efd777feced0991 References: <20190625163434.13620-1-brgl@bgdev.pl> <20190625163434.13620-12-brgl@bgdev.pl> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/25/19 6:34 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The driver data is always set in probe. The remove() callback won't be > called if probe failed which is the only way for it to be NULL. Remove > the redundant if. > > Signed-off-by: Bartosz Golaszewski Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics