Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3497973ybd; Fri, 28 Jun 2019 09:36:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqwjdwzAM0Xx9ooRCN6Wd/70PjR7KNhCIJUCHSbuQ288qjEYfuN2OmfSGtWzSANb7j0iiFXn X-Received: by 2002:a17:90a:b883:: with SMTP id o3mr14212676pjr.50.1561739802110; Fri, 28 Jun 2019 09:36:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561739802; cv=none; d=google.com; s=arc-20160816; b=pluhGO3rlviCJClCkZb4U8OAO74PSh5/laJhWWjCsWcprZwQc65WhH6XV7ncOTUaIb 6PkVOqiOJT5opv6QwR1aweSolZyAwoBx8wnS+PMsYQS4PNphlZFcHfTMCH5jk4CBWypm 3OTzRFWIA6qX+yKaVLKQ5sH2aaB6zNFBcdmBD48i/d2KCyJQHAwEl94ShTxsZ/9u0EW2 VxQaLDSxm+5yMUpAoEbuFwrAFo/bRDwis0eTl3o1m4Wtsvm/z8u2Nihh06BtNiipoJK0 S3j77S+N7+WwTHGJ5KthXRxxMcRaUmJ9Xg6kosBcmJKLu+4IUbMA19D59M8LHVlIXnTn d8gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=kgLM0I1GBL7VRZqixmy2RgEKXs0Aiq7xjyuXkidpDIA=; b=tLbuDazB6QNHyZyOzEomxYdUdE+cD9k2AzxeE7CsBlOv3acyrd26F1Wwcwwi5fw3tx oNNjWKinllQwgNerX3OB0Hlqw7DIOaoE7G4MuGK7RTl2Qsh7GYg8mInWX4ET9rKtNupV NCiIJXJ9aQHsU6cfFqdRoLNzcgpAGjcrrDeb07n3Mc2B3RZqqS1E/vAp4CSfP2OuYVZz jItSfGjjPy+3Bna0N1Cz2hnTu0rywlhEnA1e0KMvMZ3YrujEkjqody683LytH4cEm7Rb dENadmXkYYvTqtUOG0BrMPV9yjpiPwYPBVonYyg82L3aTpHdv+jx3oaiP1kQb3/BOeqS 2PUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r13si2358172pgp.214.2019.06.28.09.36.26; Fri, 28 Jun 2019 09:36:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726866AbfF1QgQ (ORCPT + 99 others); Fri, 28 Jun 2019 12:36:16 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:53235 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726687AbfF1QgQ (ORCPT ); Fri, 28 Jun 2019 12:36:16 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 45b2T752xSz1rbl1; Fri, 28 Jun 2019 18:36:11 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 45b2T73RcSz1qqkS; Fri, 28 Jun 2019 18:36:11 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id n7J9Kz3WHeh7; Fri, 28 Jun 2019 18:36:10 +0200 (CEST) X-Auth-Info: FbI/r/p3yKWuGrAJhFwnTdgCUcRVkGegtTm0TfgwdMIrmWt2MpT/uULs66KQ1B9c Received: from igel.home (ppp-46-244-173-158.dynamic.mnet-online.de [46.244.173.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 28 Jun 2019 18:36:10 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 8F21D2C0C61; Fri, 28 Jun 2019 18:36:08 +0200 (CEST) From: Andreas Schwab To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , mikey@neuling.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH v2 02/12] powerpc/ptrace: drop unnecessary #ifdefs CONFIG_PPC64 References: <34af3942cd27f6b5365caae772fb8e0af44763d5.1561735587.git.christophe.leroy@c-s.fr> X-Yow: LBJ, LBJ, how many JOKES did you tell today??! Date: Fri, 28 Jun 2019 18:36:08 +0200 In-Reply-To: <34af3942cd27f6b5365caae772fb8e0af44763d5.1561735587.git.christophe.leroy@c-s.fr> (Christophe Leroy's message of "Fri, 28 Jun 2019 15:47:51 +0000 (UTC)") Message-ID: <874l49mzuv.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jun 28 2019, Christophe Leroy wrote: > diff --git a/arch/powerpc/include/uapi/asm/ptrace.h b/arch/powerpc/include/uapi/asm/ptrace.h > index f5f1ccc740fc..37d7befbb8dc 100644 > --- a/arch/powerpc/include/uapi/asm/ptrace.h > +++ b/arch/powerpc/include/uapi/asm/ptrace.h > @@ -43,12 +43,11 @@ struct pt_regs > unsigned long link; > unsigned long xer; > unsigned long ccr; > -#ifdef __powerpc64__ > - unsigned long softe; /* Soft enabled/disabled */ > -#else > - unsigned long mq; /* 601 only (not used at present) */ > + union { > + unsigned long softe; /* Soft enabled/disabled */ > + unsigned long mq; /* 601 only (not used at present) */ > /* Used on APUS to hold IPL value. */ > -#endif > + }; Anonymous unions are a C11 feature. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."