Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3501563ybd; Fri, 28 Jun 2019 09:40:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqwLeL2IHftjKwLVnRPfaAHWr7uS7v+N6ULVMCWFXkbSvrf6KHZeYhOHbO1LKRAaUkSs3p1D X-Received: by 2002:a17:902:7087:: with SMTP id z7mr12608832plk.184.1561740023930; Fri, 28 Jun 2019 09:40:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561740023; cv=none; d=google.com; s=arc-20160816; b=SufL4ePmIy07r86xj/W1pvKahtRphmKozpci3MrC0n6fDbEHCY+/J12UVn65JYvHEZ 2rM37TmWIZP6KRjElr7+FrksNSx4QCu8bgtRUxgxeAj6OlC89mnpBGYL9muf8uGnjnvH KfcxI8HsH5HaZOnZlfIaS/bzS+BAcHqRStetdSnHHil+DTA29NZvdm4RRuwp3bX99EBX Xc6EF8SHpbik97kwsghDzQ0R4nz8MLB/CaOVLBKSg7hUVNkFp60VfXSRESPSjfYGEFab lGYIWnZeeJd/qU2UZj+Mst3f1uiZO981SRtZ/j7o7xWSFBpv1hrwmIr6hZ30s2Cp//Gp ykQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=uppHxiv76x3DLKs7pLhlu/yXbeshcJ3XT1kuNUTvaPI=; b=uyOA//mu7TTpx0Fr9jlFqtJaIUbD3AL213N8eA+ebFALgK+ZQYDQKZzcLc94OFsmSn JCimShySAHSESQ2L/9jJ1sTg0PuSR95LDVjZLP5e2D66ESPNZBatuy1dY18PpnV+pPdY 3msCY/rvKNPx69SdCSaKL4Hb/0DkaeGrTDzxoutD4jom5fQTqvRXTyAN0PYxFawW3dO/ 4rejX2XO3bB1gONi7eiU3koG+C8BBNsKmIL7uY1Hg+IQQQNYeRUVZzbj1tFjc8P5ZDDt vLm4Ph6DGYYi+r+dUJccQdqgn5Fjsa6jjXI3CpSUwms9IskuHrIvXzMK5cGrwTyVj/qu S0mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=pVKePB43; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r13si2358172pgp.214.2019.06.28.09.40.07; Fri, 28 Jun 2019 09:40:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=pVKePB43; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726873AbfF1Qjz (ORCPT + 99 others); Fri, 28 Jun 2019 12:39:55 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:8807 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726605AbfF1Qjz (ORCPT ); Fri, 28 Jun 2019 12:39:55 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 45b2YN3C52zB09Zb; Fri, 28 Jun 2019 18:39:52 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=pVKePB43; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id YV9INxoLhf96; Fri, 28 Jun 2019 18:39:52 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 45b2YN1sxvzB09ZZ; Fri, 28 Jun 2019 18:39:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1561739992; bh=uppHxiv76x3DLKs7pLhlu/yXbeshcJ3XT1kuNUTvaPI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=pVKePB433jkcqO4D8bb2+BUMLdTABMAkxqnveFnbO1rdXjkO3/uFx5gQgU0imVgrU dvssKi2YNnNQ3gtKgdjNuKSxGeQ6f/FNCC+HAwKyiyzSAQB1hKEZbaCljM48zle36I jaJoCycDiu/lUGojW6IdvtaWngvG9AthpyWo2nl4= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id E5B5E8B975; Fri, 28 Jun 2019 18:39:53 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id f00KyCZdoUwa; Fri, 28 Jun 2019 18:39:53 +0200 (CEST) Received: from [172.25.230.101] (po15451.idsi0.si.c-s.fr [172.25.230.101]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C2B188B955; Fri, 28 Jun 2019 18:39:53 +0200 (CEST) Subject: Re: [RFC PATCH v2 02/12] powerpc/ptrace: drop unnecessary #ifdefs CONFIG_PPC64 To: Andreas Schwab Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , mikey@neuling.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <34af3942cd27f6b5365caae772fb8e0af44763d5.1561735587.git.christophe.leroy@c-s.fr> <874l49mzuv.fsf@igel.home> From: Christophe Leroy Message-ID: <7dd19eae-793e-b334-e621-7681998ddf2e@c-s.fr> Date: Fri, 28 Jun 2019 18:39:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <874l49mzuv.fsf@igel.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 28/06/2019 à 18:36, Andreas Schwab a écrit : > On Jun 28 2019, Christophe Leroy wrote: > >> diff --git a/arch/powerpc/include/uapi/asm/ptrace.h b/arch/powerpc/include/uapi/asm/ptrace.h >> index f5f1ccc740fc..37d7befbb8dc 100644 >> --- a/arch/powerpc/include/uapi/asm/ptrace.h >> +++ b/arch/powerpc/include/uapi/asm/ptrace.h >> @@ -43,12 +43,11 @@ struct pt_regs >> unsigned long link; >> unsigned long xer; >> unsigned long ccr; >> -#ifdef __powerpc64__ >> - unsigned long softe; /* Soft enabled/disabled */ >> -#else >> - unsigned long mq; /* 601 only (not used at present) */ >> + union { >> + unsigned long softe; /* Soft enabled/disabled */ >> + unsigned long mq; /* 601 only (not used at present) */ >> /* Used on APUS to hold IPL value. */ >> -#endif >> + }; > > Anonymous unions are a C11 feature. > Is that a problem ? Kernel has a minimum GCC requirement of version 4.6, doesn't 4.6 support C11 ? Christophe