Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3517095ybd; Fri, 28 Jun 2019 09:58:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqw8tmBQO/Kyec6x1wYWTizvykVNn5MHc97PgTpEc5f4oJjDzcUzv3wtdo1gMmWwBs6gbVgs X-Received: by 2002:a63:e0d:: with SMTP id d13mr9762841pgl.5.1561741120105; Fri, 28 Jun 2019 09:58:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561741120; cv=none; d=google.com; s=arc-20160816; b=Vj+ly9Urga9hzztJ0eh+l9nNVAqGp9mQaq3gnXmkZGyIotb4oUnJ+FdaPCFxg3M9ys Q0LkZcFMoKW0ZoTmeOcSjgKFX+HANr7nz46LGXWCdPkbueGCi4KSfw68f0LgOfzcUhcN i9HIxfsIopbX412boDg4cGO9chNBtecvm/HBi91jTvWFW5Px76n0+ir9wUtBFxRYJ4Qv dNVRqMORPxcO1LZNDm57mbeSKDMI3mLFkIOBX5Kq0RL5ruvt13adHi18BLOHnJVQqh5V 8nmWsAQP7Vox6Uc69rYRmPrW1AdSthXV48/xNzNvE6FsneIEHdTpPpYOyqwvtRr6szrp uSYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=lK0iOan3AVtLl5dzxhYffiHPtchPL13jyFaUkzzdnGY=; b=SwHFb/2YWk9Ox2WEsD1NgMJcD7n7Evh/xJ2v+zbTQ6+3QX/vNEC1mNp2DYaxvZt+q1 aGlEb2HFEW2KX3A3ZxhNuA1dilr3G/kWBJU5a/tq2odV2iaYTmEJGMABSx7u/GO5f408 TiHM0t0QFt5C78uKWkcmuo/ja5zPT3ODfiRefzE9ik7yQWoqvZywLI743fkpElJxYRs8 f4vJCcUaHr89UUPpMTlkKMHcnIJpzLENutT9N1EsB8OkLvJLHZ/v1SSdXtf6h79p8G+H w1b8Kjyln90sKgL3AHVDG8R51ma4HJqNR9Zn7pCGi6u9fFi6FR142ZlV1Ldcztv46pLN 4jwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=obVpWn5M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q7si2564074pgs.97.2019.06.28.09.58.24; Fri, 28 Jun 2019 09:58:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=obVpWn5M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726667AbfF1Q4m (ORCPT + 99 others); Fri, 28 Jun 2019 12:56:42 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:42618 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726964AbfF1Q4k (ORCPT ); Fri, 28 Jun 2019 12:56:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=lK0iOan3AVtLl5dzxhYffiHPtchPL13jyFaUkzzdnGY=; b=obVpWn5MXCPj xsB7YM7Fl/AleM+yoj8xzMyX8MH6l9FGSrYsiLhtQYDHnbihQfnQNAgHQGSJBYYa7isdgs+zog5xP sYNtslMjaYfQNaLjcglfBmSQi1qZ1FR7Hrhy3qyFSnQK5kZv9FeLJ54GeO8tvR3xlSrkSfuuMrhMU /kTLo=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=finisterre.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hguAs-0007D3-B1; Fri, 28 Jun 2019 16:56:34 +0000 Received: by finisterre.sirena.org.uk (Postfix, from userid 1000) id E5C44440046; Fri, 28 Jun 2019 17:56:33 +0100 (BST) From: Mark Brown To: Ludovic Barre Cc: Alexandre Torgue , Boris Brezillon , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Marek Vasut , Mark Brown , Maxime Coquelin , Rob Herring Subject: Applied "spi: stm32-qspi: remove signal sensitive on completion" to the spi tree In-Reply-To: <1561621439-7305-2-git-send-email-ludovic.Barre@st.com> X-Patchwork-Hint: ignore Message-Id: <20190628165633.E5C44440046@finisterre.sirena.org.uk> Date: Fri, 28 Jun 2019 17:56:33 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch spi: stm32-qspi: remove signal sensitive on completion has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 775c4c0032c408b8a57a3fc2695eeda101da003a Mon Sep 17 00:00:00 2001 From: Ludovic Barre Date: Thu, 27 Jun 2019 09:43:59 +0200 Subject: [PATCH] spi: stm32-qspi: remove signal sensitive on completion On umount step a sigkill signal is set (without user specific action), due to sigkill signal the completion will be interrupted and the data transfer can't be finished if a sync is needed. Signed-off-by: Ludovic Barre Signed-off-by: Mark Brown --- drivers/spi/spi-stm32-qspi.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index 42f8e3c6aa1f..0b07182f5660 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -245,12 +245,8 @@ static int stm32_qspi_tx_dma(struct stm32_qspi *qspi, writel_relaxed(cr | CR_DMAEN, qspi->io_base + QSPI_CR); t_out = sgt.nents * STM32_COMP_TIMEOUT_MS; - if (!wait_for_completion_interruptible_timeout(&qspi->dma_completion, - msecs_to_jiffies(t_out))) - err = -ETIMEDOUT; - - if (dma_async_is_tx_complete(dma_ch, cookie, - NULL, NULL) != DMA_COMPLETE) + if (!wait_for_completion_timeout(&qspi->dma_completion, + msecs_to_jiffies(t_out))) err = -ETIMEDOUT; if (err) @@ -304,7 +300,7 @@ static int stm32_qspi_wait_cmd(struct stm32_qspi *qspi, cr = readl_relaxed(qspi->io_base + QSPI_CR); writel_relaxed(cr | CR_TCIE | CR_TEIE, qspi->io_base + QSPI_CR); - if (!wait_for_completion_interruptible_timeout(&qspi->data_completion, + if (!wait_for_completion_timeout(&qspi->data_completion, msecs_to_jiffies(STM32_COMP_TIMEOUT_MS))) { err = -ETIMEDOUT; } else { -- 2.20.1