Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andreas Schwab <schwab@linux-m68k.org>
To:     Christophe Leroy <christophe.leroy@c-s.fr>
Cc:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>, mikey@neuling.org,
        linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH v2 02/12] powerpc/ptrace: drop unnecessary #ifdefs CONFIG_PPC64
References: <cover.1561735587.git.christophe.leroy@c-s.fr>
        <34af3942cd27f6b5365caae772fb8e0af44763d5.1561735587.git.christophe.leroy@c-s.fr>
        <874l49mzuv.fsf@igel.home>
        <7dd19eae-793e-b334-e621-7681998ddf2e@c-s.fr>
Date:   Fri, 28 Jun 2019 19:08:55 +0200
In-Reply-To: <7dd19eae-793e-b334-e621-7681998ddf2e@c-s.fr> (Christophe Leroy's
        message of "Fri, 28 Jun 2019 18:39:53 +0200")
Message-ID: <87zhm1ljrs.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Jun 28 2019, Christophe Leroy <christophe.leroy@c-s.fr> wrote:

> Le 28/06/2019 à 18:36, Andreas Schwab a écrit :
>> On Jun 28 2019, Christophe Leroy <christophe.leroy@c-s.fr> wrote:
>>
>>> diff --git a/arch/powerpc/include/uapi/asm/ptrace.h b/arch/powerpc/include/uapi/asm/ptrace.h
>>> index f5f1ccc740fc..37d7befbb8dc 100644
>>> --- a/arch/powerpc/include/uapi/asm/ptrace.h
>>> +++ b/arch/powerpc/include/uapi/asm/ptrace.h
>>> @@ -43,12 +43,11 @@ struct pt_regs
>>>   	unsigned long link;
>>>   	unsigned long xer;
>>>   	unsigned long ccr;
>>> -#ifdef __powerpc64__
>>> -	unsigned long softe;		/* Soft enabled/disabled */
>>> -#else
>>> -	unsigned long mq;		/* 601 only (not used at present) */
>>> +	union {
>>> +		unsigned long softe;	/* Soft enabled/disabled */
>>> +		unsigned long mq;	/* 601 only (not used at present) */
>>>   					/* Used on APUS to hold IPL value. */
>>> -#endif
>>> +	};
>>
>> Anonymous unions are a C11 feature.
>>
>
> Is that a problem ?

Yes, this is a UAPI header.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."