Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3609476ybd; Fri, 28 Jun 2019 11:37:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqyUcFcBGArUbrbf6ZRF5EMm7/Sfko4JQkkigUblk8FUmxQe4wfSZn074JQWWJvVKpzef7L+ X-Received: by 2002:a63:4518:: with SMTP id s24mr10824476pga.123.1561747056995; Fri, 28 Jun 2019 11:37:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561747056; cv=none; d=google.com; s=arc-20160816; b=Rk05LtW12FLtkUh9IZ56gzKFEnwpQ8nOn+aIO9ReNcwGBl6joml1QM/m5lV5zmS8jd DecibOZL9MbYcsUH/4S+3nfLbGf0urMet2oa7rY6XeVojnSsmGE1eHXvxPaW3DXh7yJO yRPDQ7DqCRc576q0w7mOdY0PoVx4APFcxXTUve4rcvkZ2s/1ATMtEUjQlv4gIWCxlJzA nDHJhF2QQRipc1EyDTg8d1k8iqWE4ex3TNTz4QuZrAcajMrJXOUm9krEshzY1Q/T8dYU 4HpAimVs5s0gbj0znTbPOx8pQ9Fn3Hs2/frBBCsAaNqtN6lVmQ6E8X/QrOpoWukdWEhn /MPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=LHhxFxKIHD+OTLCZOIvPN4S0Qfysk7ZWS3cs8pdQTog=; b=gDG2LAaRBez4LcPhsFM4mVx/lcHbsLGs+qYagDKTLSP4J7DBgkLkiPCcs26Rl8kQZs hXz/XeVHWlmCiGMk8oP/NP/WYDMAd/IXVGT5DT1awYI85r7t8g/QbWGFKvyiNuPPIGgA IeMrENMEK/M12tJ5/dJF5rxqpvCoqd4h8XKhTSiJ73DUqt3EAIOMtpUIicQ5P/0fpJZb wnc5E6bQYW37/UlgEzwca2SVadpu49S0hjvnikLZZbulv7CFcHAHGkQDaAKJzp9y4vLh LLC9av24MK9Hn2+Ae8VPHWY+4yBNc/R+67ouGJGIOrUJAh4aAs9/KCjBhuCtxYvxflum zFgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x17si3179425plm.410.2019.06.28.11.37.21; Fri, 28 Jun 2019 11:37:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726990AbfF1ShS (ORCPT + 99 others); Fri, 28 Jun 2019 14:37:18 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:59869 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726658AbfF1ShS (ORCPT ); Fri, 28 Jun 2019 14:37:18 -0400 X-Originating-IP: 81.185.164.234 Received: from localhost.localdomain (234.164.185.81.rev.sfr.net [81.185.164.234]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 27CB420006; Fri, 28 Jun 2019 18:37:06 +0000 (UTC) From: Miquel Raynal To: liaoweixiong , Miquel Raynal , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Vignesh Raghavendra , Boris Brezillon , Frieder Schrempf , Peter Pan , Jeff Kletsky , Schrempf Frieder Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] mtd: spinand: read return badly if the last page has bitflips Date: Fri, 28 Jun 2019 20:36:56 +0200 Message-Id: <20190628183656.18875-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <1561695286-19265-1-git-send-email-liaoweixiong@allwinnertech.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b83408b580eccf8d2797cd6cb9ae42c2a28656a7 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-06-28 at 04:14:46 UTC, liaoweixiong wrote: > In case of the last page containing bitflips (ret > 0), > spinand_mtd_read() will return that number of bitflips for the last > page. But to me it looks like it should instead return max_bitflips like > it does when the last page read returns with 0. > > Signed-off-by: Weixiong Liao > Reviewed-by: Boris Brezillon > Reviewed-by: Frieder Schrempf > Cc: stable@vger.kernel.org > Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel