Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3621179ybd; Fri, 28 Jun 2019 11:52:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+OzkHXCnVeD2NSXehTvFAS/gp1MzXMttkMw/2JYkx/c6QUhwbWUTSKaGGrzsqZZofcWxC X-Received: by 2002:a17:902:724:: with SMTP id 33mr13089995pli.49.1561747936252; Fri, 28 Jun 2019 11:52:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561747936; cv=none; d=google.com; s=arc-20160816; b=tUXbiLejjj1wvJZquc27XN54JLRbBLrNi3YUzV/e+16jk7iypDHL6aQJyiRue8/KKv f87TYSticpPBrj1zMklAZsph39QZC8CYRGae0e4+5evCeneELH7lGIjJ57KOLqR5KVjG 8mu8xoyMnIMjUL3XdBAkh7UUG0QVDvfAlAa/t1kAGVKcOLObPqX0fUwVcny62UWRk125 W1ishV6pkbG/kzH5KXPyasv2+JW4yJq2zcS+5gKbF7FRXvEMrLfzb6wYu1MdFCs2P9re A6EA77UpyAOKnE8qBo1bxJYOfDNinQB4tvKLtcuaAG5kR3bcjek1nIVYCc+VzB5pO2JZ oA+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=m9Owh7//UnvaH+s5QKM74IMhbp1YkFS0XfYHCY1rN2o=; b=j3GLCI+HpDdQ983soqPb/WiqkPensF9zMad6olA/d1pE8h+vb2/Fepp9RYiHQ0t0oD fd7aW65EEkOk4yNqXpZQjKjf/LbriNdkJAWxUKR+8Qk/kQBwIabNeSMl9YG7nTNW7S6v C/T7Ap1lRXMJcdj1jN7/pw08DxL7ZgznxLIGORKL6NTXGQlYF9uJ8LmPTj+VlpNIdJ3C uAAtRx+8H49uISnKGYe8QZpnfa8geKqa8h49tUfTBal21kKEi6nF1MBUAizoqJgRaUQb w8QQwHswkbD0b0yptobBGPgOTpy+PhXVrf+c3mH1yIXLco7rTd0P66aIPZyaJ9eAyQJS MUNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q85si3220114pfc.85.2019.06.28.11.51.59; Fri, 28 Jun 2019 11:52:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726812AbfF1Sv4 (ORCPT + 99 others); Fri, 28 Jun 2019 14:51:56 -0400 Received: from verein.lst.de ([213.95.11.211]:40863 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726563AbfF1Svz (ORCPT ); Fri, 28 Jun 2019 14:51:55 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id EDD11227A81; Fri, 28 Jun 2019 20:51:52 +0200 (CEST) Date: Fri, 28 Jun 2019 20:51:52 +0200 From: Christoph Hellwig To: Dan Williams Cc: Jason Gunthorpe , Christoph Hellwig , =?iso-8859-1?B?Suly9G1l?= Glisse , Ben Skeggs , "linux-mm@kvack.org" , "nouveau@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-nvdimm@lists.01.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH 16/25] device-dax: use the dev_pagemap internal refcount Message-ID: <20190628185152.GA9117@lst.de> References: <20190626122724.13313-1-hch@lst.de> <20190626122724.13313-17-hch@lst.de> <20190628153827.GA5373@mellanox.com> <20190628170219.GA3608@mellanox.com> <20190628182922.GA15242@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 28, 2019 at 11:44:35AM -0700, Dan Williams wrote: > There is a problem with the series in CH's tree. It removes the > ->page_free() callback from the release_pages() path because it goes > too far and removes the put_devmap_managed_page() call. release_pages only called put_devmap_managed_page for device public pages. So I can't see how that is in any way a problem.