Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp87013ybd; Fri, 28 Jun 2019 15:07:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqx9LEQNGJ5T33sviZi15LY/jdmKDtQjr95Evn0x7NhLl6l3cmqlvECqre1ymPZ/Flf7t4/H X-Received: by 2002:a17:90a:9289:: with SMTP id n9mr16032088pjo.35.1561759668077; Fri, 28 Jun 2019 15:07:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561759668; cv=none; d=google.com; s=arc-20160816; b=Krs1XMirW6LUzxdRj7Bvtk9SVDufyKyH7OUYJwjju1SD8DYMel+0UYuyWC4AciDxqy 64WwtoXHKI/qbBwq9XHYjHAeFUHIDNCARuvlTEc6v/v3TDAnm84nCTPwEBJKAKs82VfM iKZKoOsI4+bV8qERvVPMggQO1RP55o8Q8fVZwTx6pAlsTMIuhe4pZH5CZJgr0SW+hum+ CcDGG2wPI3AFTKf7hPXln50JheKug/ojAd++RQA6f+EUVklSbow8a91KKNLzh5yjE/a1 vn0XSFFPyOqMZwsTPOtrvetmKux/Wb+j/HveFLBN49wI+NjyfO5QU3Qf9bLr3uAoSMOc Euig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=74OPjw61WfkdZEzSLsys8fgk6PifSSbknmVm2NEw5mE=; b=gvGDctJpctf6KwbW4R3IG2GCGKVQm2NuupM7KUy+8UUjwB0imhIeIADLz20TJFQ/GV DNskNNZ8fKMa+oDuGWVZbr0+7DiOUuM3bmfQ2NpqudO+id3bTiX1/Y9h31irGyd6PwdB DDOBdMqmaUesOXeYgI3CeePhhIqs69RLzXEIcPBNk2ERgJ3WecyVf5FvH6riES5Xs5Yp dBOdSlhn5pI9cVFQEaV+k2KiuUal1MA8ZHp2KF2Bcfe3UyJOnKUYbKSmsKtsoAQHkCKm B3PHToT634h8FsHdpgVAib1S3ne/oNANoKj3MbQ/6wsuobJQoSwXcSGU/uBAAweOS56u bNZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=tBV36za1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r4si2935788pgv.195.2019.06.28.15.07.30; Fri, 28 Jun 2019 15:07:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=tBV36za1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726643AbfF1WHU (ORCPT + 99 others); Fri, 28 Jun 2019 18:07:20 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:35729 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725783AbfF1WHU (ORCPT ); Fri, 28 Jun 2019 18:07:20 -0400 Received: by mail-vs1-f68.google.com with SMTP id u124so5063002vsu.2 for ; Fri, 28 Jun 2019 15:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=74OPjw61WfkdZEzSLsys8fgk6PifSSbknmVm2NEw5mE=; b=tBV36za12EawEv+1kbBGR9K45WvHbqKoMnvnBxWlnxnKqTayTKKBcageg21+paIXxV No38B6UUFmHsPBIHSfqd7vqJbd4VTh2HkjSNwJRIWqU3Zti8tNUIy7eaYfkiY8IQp+/t tAsWyQAbKtw9eu/3jOA4d6asamy7qXNdkO6MR2cz+VauhTtNO2WIWCh2aH/bdxTXxQse aJVPi1C12NEKeaggLsETQ/4BEZ/jGjE+aDz4s8IiyD4u2qhEPDjnGho74HjhYhXvF/nW wVipQaRl8ifcIxPTB17H9x2nqOhqEHQkhWpiQcewmEbSRnKPork3BN0A5uCOBdovIChP Eyww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=74OPjw61WfkdZEzSLsys8fgk6PifSSbknmVm2NEw5mE=; b=oBqhN0mbu+HvNKVjcVuqBjCopMiqA3QGVjR8lE2F0Kx9jc89PJHc7Y3VjHTMqfhweI 9TV+CtUgR8uq1wRHiOqe5985WsfSc+WbaCcCsqT42nY6o3jAkBoNbrQ/A3Rt0dVc+Nba TIedQ4stw1LS0GnPOYsvcRyPGb241WA4fWzGpLOf1jxwmwcxuVDuBqalKiwDC+SjvwxB a90xaOD0mjA4ujN1iXLcUnM99Hum83mcWKzAijN+MDmm8t/N6kR08Iou6hEx6m0oGX/4 K2bXS2jf54J6rFb9WJHip/BesNY9Rj7Iwgnv07uhrp2nLFZjbXbLNcntogatu3Zp4Sgn 5Qrw== X-Gm-Message-State: APjAAAWTaW6vsgnibWapTSIHjLPzz2nO4UZ7AK/RXCOpCtVg3qRBZInV +hhI37CbHgrNgwuvM13F8PbkLpnM9JsqyefsSUbExA== X-Received: by 2002:a67:e98f:: with SMTP id b15mr7973070vso.209.1561759638724; Fri, 28 Jun 2019 15:07:18 -0700 (PDT) MIME-Version: 1.0 References: <20190628045008.39926-1-walken@google.com> <20190628165642.r754xozttawmg5yh@linux-r8p5> In-Reply-To: <20190628165642.r754xozttawmg5yh@linux-r8p5> From: Michel Lespinasse Date: Fri, 28 Jun 2019 15:07:06 -0700 Message-ID: Subject: Re: [PATCH] rbtree: avoid generating code twice for the cached versions To: Davidlohr Bueso Cc: Peter Zijlstra , David Howells , Andrew Morton , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Davidlohr, On Fri, Jun 28, 2019 at 9:56 AM Davidlohr Bueso wrote: > I think this makes sense, and is more along the lines of the augmented > cached doing the static inline instead of separate instantiations of the > calls. Thanks for the review. > >Change-Id: I0cb62be774fc0138b81188e6ae81d5f1da64578d > what is this? Gerrit code review insists on having this footer on every commit. I forgot to remove it before submitting. Please ignore it :) -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.