Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp87952ybd; Fri, 28 Jun 2019 15:08:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqwIWfSSTSSUcy+1VXSn9jo4GFLFyVCY0gCzkqUf1qGTIwaD+a/t0fXVqrlMHGcEBrya/zgx X-Received: by 2002:a63:607:: with SMTP id 7mr8934201pgg.240.1561759738363; Fri, 28 Jun 2019 15:08:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561759738; cv=none; d=google.com; s=arc-20160816; b=VDadcQ4zRqOWUggjx7tnp6KwMboN9EqLWpoEUrnyo0P1Ee7jZXZwjihYCeN+ZqeKoN Gk2Griid1rhQ7S6AqJcDJfGoDZt4VteI1AoaW/CsyfLsMLRW9yyynmK2Kj9YwUMGN7gH CCqC3mmTG5qNZIfIftRk72RL3cwPcLZIY3ZHq5qLxUjAJ5xZPU1BL6DShvIcFBDIvPge rPg4idY6yOvRknUM4u3FkCnS+PLfvTGP/y20f+vJwRvqSyrTjWZHfjKJ1fxc8Jf1R/cm RfA3bBDDWpELwKyui19HwR8mCnlQBcOUy9oAVYHbwyG9jKqEdTrkpMfy2iKFM9fWCsnl Benw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8QkjP+v3VNd46CcScOVVrmwjaHGpcTtlTlR7LtlUUTw=; b=pIBoer3fq8FaErXVBu5HOf2HeZ74bmMIQkB2PdGqvAFCIzqKXFqyr0QcpKvdSOxbGJ CWuxxj3rh3WB3LaQEIyrU6VYz+uCLdgyBAQlVWLJ2LGwg2h7G6RpGPgIxd/cOsk46HtM UaSPbhWEWE/hHE+A4x+h58A8PmREuMyKCY8wicBz4dX9Mo3u8SEt3X6egex2O0gmNsmR YzJ03SGn2GshTRAMoDd9pO4Z0O0PXEwce9Ck/xn20ZYCTWOXdAaPKsmB4dZooFvtCZEO m3sxgjg1PNYRWrkbbV7AqPya+iz3SOaE1+9y9pNtMP1nElpazw6jzvyrK5NIxYhBts28 d7CA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 65si3594485pfg.241.2019.06.28.15.08.42; Fri, 28 Jun 2019 15:08:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726891AbfF1WHy (ORCPT + 99 others); Fri, 28 Jun 2019 18:07:54 -0400 Received: from mga17.intel.com ([192.55.52.151]:44146 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbfF1WHr (ORCPT ); Fri, 28 Jun 2019 18:07:47 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2019 15:07:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,429,1557212400"; d="scan'208";a="338031188" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.137]) by orsmga005.jf.intel.com with ESMTP; 28 Jun 2019 15:07:46 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id 5D8D230054C; Fri, 28 Jun 2019 15:07:46 -0700 (PDT) From: Andi Kleen To: acme@kernel.org Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: [PATCH 2/3] perf list: Avoid extra : for --raw metrics Date: Fri, 28 Jun 2019 15:07:36 -0700 Message-Id: <20190628220737.13259-2-andi@firstfloor.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190628220737.13259-1-andi@firstfloor.org> References: <20190628220737.13259-1-andi@firstfloor.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen When printing the metrics raw, don't print : after the metricgroups. This helps the command line completion to complete those too. Signed-off-by: Andi Kleen --- tools/perf/util/metricgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c index fabdb6dde88e..1c85c9624c58 100644 --- a/tools/perf/util/metricgroup.c +++ b/tools/perf/util/metricgroup.c @@ -376,7 +376,7 @@ void metricgroup__print(bool metrics, bool metricgroups, char *filter, struct mep *me = container_of(node, struct mep, nd); if (metricgroups) - printf("%s%s%s", me->name, metrics ? ":" : "", raw ? " " : "\n"); + printf("%s%s%s", me->name, metrics && !raw ? ":" : "", raw ? " " : "\n"); if (metrics) metricgroup__print_strlist(me->metrics, raw); next = rb_next(node); -- 2.20.1