Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp254413ybd; Fri, 28 Jun 2019 19:04:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxXCIpUoZXwyElOg+DjphTEIYhyhTn3gi3AavTsdoKJvyur4bkqiOXag9RatEgQb/c+/qoQ X-Received: by 2002:a17:90a:d814:: with SMTP id a20mr16917523pjv.48.1561773855143; Fri, 28 Jun 2019 19:04:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561773855; cv=none; d=google.com; s=arc-20160816; b=fKd9tHVsTMzJwHBKXBklJc9jyojAATayA50ZIbUjYqQ2OHLn7h1lzYqyMEcdGeq8qk h6q5p3Z6Dao3HvRFZaschHHfw/NQoUZ/4XVr3QGItHcUoLUi/1MGk4UL1VvUFag3tVf0 P87WA4T+tHgSZgYZA1yE+Pp7Ibg76GKC/8VG9NZcFtA1MiAKbll1eha6NnKUA++45zPX WJnPB39hJBzVsftx8KLHosSxpVKaMeONAGiMnOBhX3WJ1yU7gCtcbsBhRKaRGXmcn8xU lVysPTgEbnNoisa2FR5OZDtVenJzSQojHwsvrlgguxcLDpJrYa7y20aG/Hvq585gNCny Qlpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=PxNura2FtwVYOyi81GbViu2+hM88Pn+e9x0rTuDTcoQ=; b=d8iH0Q1v0uXKyU4KAk4Hibq4XyjrIh5wllx1YhQwlSivLYa3VXqL5gMMTLdNd5v+q2 b6iFgo2ro6gNpCwyda1nnNQQQNvLVJJ/G8IdFSQJupNZ5cdt+ZLXVNE/oVwkjeGS3LJX FYSZsX5/TZMWvQ7EPbrtVY3WmBXaruhZhiQ6ugTLfPDG98U0SnB41L/G0V8PW8DGt71Z qQCjwum6OdOz6St0M4GVRb7b+MRQ+stdixJ6TSb4i9lbo4Lo/YSiB6J1HAXdoKPwf+6i 0cH8Ax+Bem5cU6sTdsdOqp+ww4yhqWqBPUjILytEkxbm5ZMkmoabHcVKYq0IsCws19uK TG2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@appneta.com header.s=google header.b=Bkw8E8uP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=appneta.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si3242410pgl.402.2019.06.28.19.03.46; Fri, 28 Jun 2019 19:04:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@appneta.com header.s=google header.b=Bkw8E8uP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=appneta.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726863AbfF2CDE (ORCPT + 99 others); Fri, 28 Jun 2019 22:03:04 -0400 Received: from mail-pf1-f175.google.com ([209.85.210.175]:43439 "EHLO mail-pf1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726819AbfF2CDE (ORCPT ); Fri, 28 Jun 2019 22:03:04 -0400 Received: by mail-pf1-f175.google.com with SMTP id i189so3831379pfg.10 for ; Fri, 28 Jun 2019 19:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=appneta.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=PxNura2FtwVYOyi81GbViu2+hM88Pn+e9x0rTuDTcoQ=; b=Bkw8E8uPLA9IENhj0LHLfwCv6/akD+dFdPBMlt6PSHTSEtAaUiCESMuCkaQPmwYlr8 lcz3ffzW0bLvjRMVdmokrkJgUgUAPNzyWWHyJ+sVfS0n+61kHGaIufPvdEo2ISwHQLOm 9rFcypdFd1rCxsXuuwaEcrzwjE7Fz2AsD6GXQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=PxNura2FtwVYOyi81GbViu2+hM88Pn+e9x0rTuDTcoQ=; b=XARshyE5VtnzwM0HIOcAc9rkQarloLiNEIdMfpJp1afgv8Non9u0UVndzIVuWE9rCk 64bVP0Si+3JwKBbOKgEQcjKuCl217BL1ofYXScQOBhNCsFmWzrANoxCI/Xo5IY42WSzD MsQ80u3s6SX0L5edLtvbos7ML4V7/OHW/49naC3SBLqE/UkUJfo+AxOfTyem9/y7cXY+ l5OdC9HsijI0dsTkTVK30ZafjUNHSAuJt/FG4J4giuAYe6HzXtKRS12vcz+FN1XJo40D kF034dUvVbG12sisSbJudLc7GhmMsW+fvJaPcEV70OIfSefVI7Oq4JbXHryaTyfkqEOF sPiA== X-Gm-Message-State: APjAAAUqwwUJ4i/Og4oCs8Ud37G/y3WkGFVjzGgfAmYC9nYBtewwjB/h MkwVTSO/AI30t/qNKucPa7iw X-Received: by 2002:a63:e53:: with SMTP id 19mr12025624pgo.137.1561773783541; Fri, 28 Jun 2019 19:03:03 -0700 (PDT) Received: from [192.168.1.144] (64-46-6-129.dyn.novuscom.net. [64.46.6.129]) by smtp.gmail.com with ESMTPSA id v3sm3399769pfm.188.2019.06.28.19.03.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jun 2019 19:03:02 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: net: check before dereferencing netdev_ops during busy poll From: Josh Elsasser In-Reply-To: <20190628225533.GJ11506@sasha-vm> Date: Fri, 28 Jun 2019 19:03:01 -0700 Cc: Matteo Croce , stable@vger.kernel.org, Greg Kroah-Hartman , netdev , LKML , David Miller Content-Transfer-Encoding: 7bit Message-Id: <1560226F-F2C0-440D-9C58-D664DE3C7322@appneta.com> References: <20190628225533.GJ11506@sasha-vm> To: Sasha Levin X-Mailer: Apple Mail (2.3445.104.11) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jun 28, 2019, at 3:55 PM, Sasha Levin wrote: > What's the upstream commit id? The commit wasn't needed upstream, as I only sent the original patch after 79e7fff47b7b ("net: remove support for per driver ndo_busy_poll()") had made the fix unnecessary in Linus' tree. May've gotten lost in the shuffle due to my poor Fixes tags. The patch in question applied only on top of the 4.9 stable release at the time, but the actual NPE had been around in some form since 3.11 / 0602129286705 ("net: add low latency socket poll"). Josh