Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 0/3] block: sed-opal: add support for shadow MBR done
 flag and write
To:     Scott Bauer <sbauer@plzdonthack.me>
Cc:     jonathan.derrick@intel.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "zub@linux.fjfi.cvut.cz" <zub@linux.fjfi.cvut.cz>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "jonas.rabenstein@studium.uni-erlangen.de" 
        <jonas.rabenstein@studium.uni-erlangen.de>
References: <1558471606-25139-1-git-send-email-zub@linux.fjfi.cvut.cz>
 <7ee5d705c12d770bf7566bce7d664bf733b25206.camel@intel.com>
 <20190629161947.GA20127@hacktheplanet>
 <d3074ee1-0506-511d-c29c-44effb4eda97@kernel.dk>
 <20190629162835.GA21042@hacktheplanet>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <cb37028f-bff9-92a6-4ecd-efe938274d24@kernel.dk>
Date:   Sat, 29 Jun 2019 10:35:30 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.1
MIME-Version: 1.0
In-Reply-To: <20190629162835.GA21042@hacktheplanet>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 6/29/19 10:28 AM, Scott Bauer wrote:
> On Sat, Jun 29, 2019 at 10:26:52AM -0600, Jens Axboe wrote:
>> On 6/29/19 10:19 AM, Scott Bauer wrote:
>>>
>>> Hey Jens,
>>>
>>> Can you please stage these for 5.3 aswell?
>>
>> Yes, looks fine to me. But it conflicts with the psid revert in terms
>> of ioctl numbering. You fine with me renumbering IOC_OPAL_MBR_DONE to:
>>
>> #define IOC_OPAL_MBR_DONE           _IOW('p', 233, struct opal_mbr_done)
> 
> Sorry for the conflict. That's fine. I'll fix up userland tooling.

Renamed 232 -> 233, and 233 -> 234, for the two conflicts. So now we have:

#define IOC_OPAL_PSID_REVERT_TPR    _IOW('p', 232, struct opal_key)
#define IOC_OPAL_MBR_DONE           _IOW('p', 233, struct opal_mbr_done)
#define IOC_OPAL_WRITE_SHADOW_MBR   _IOW('p', 234, struct opal_shadow_mbr)

-- 
Jens Axboe