Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp303854ybi; Sat, 29 Jun 2019 11:07:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqzDQyDuPcnG6OjCs3tzmwdPpW4sly7aQsL2YN8BoYcu1eO/sVkDbXfhQy0Z95R5IS35+QfU X-Received: by 2002:a63:2c43:: with SMTP id s64mr15486172pgs.50.1561831634516; Sat, 29 Jun 2019 11:07:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561831634; cv=none; d=google.com; s=arc-20160816; b=xMCLqPgXfb/6zd0D0RF+3h308NV3n4UMDvhB6Og7Y2Mgnn2KMUf5Ra4jr3MaT0CsVA D4M9RFajwjTD7CuhINwyFYfUokfQ8BPIOdWuQ1KbP4UlFXAFvm1V2ETiL3RtMk5EOfui eG3hyaPY14SNRZZFwodW0nc/eM2tYqWsqXjBU8CN3KJ3sr4rXR/KrFfUV9JKQJ8Tph22 lrkniHZZwWok3KQG0KTFmKsUyIeJZYDI2PZAtBjzyqKCDlt3+lZbGQ/O1e784f7QxYB/ Gs1FPjxvj/38IL8O6a/N5PbO9BWnXB+Gwrqum0jjZgXORNoRWxXBxsHBnvSjeS/qaOcx 1S8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=oFrgxr11K3ynHSV5X36UHY9D+CmNpZDK/35s4drBhdQ=; b=A9FAgDImCz/AVBJzUrLsbXH734SGdLhK8ZplEluQ89LsUFE+8MOWuoPSbBadnFrHWV Y/rIuXIOWnW+0H7fEJzjCrHG2Sy5he8gHTkHT1+W12iayW7ndtHKxOmCnDQ7vyykSK+T fZnoL+WK/LspVnmWqBWfIupypLIno6rNDCTkPWzyI9fZPIP9i90fchiumzHb/Mre8lM0 DayG2HYbwdG43b1hwgKssXp3j2gIAqOC61U9xDKEi9M1+kYwHiVjy3WvY3Tz54cfE5xU D64DeDWU9IHYVpHC1yJmQsbAyW6DPUh8TUPur5UeBiYbhDS1N1Y0e8eYIIaJCJt5fRXt Kebg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h36si5148006plb.199.2019.06.29.11.06.45; Sat, 29 Jun 2019 11:07:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726923AbfF2SGm (ORCPT + 99 others); Sat, 29 Jun 2019 14:06:42 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:38388 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726864AbfF2SGl (ORCPT ); Sat, 29 Jun 2019 14:06:41 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 41DA914B8DAC4; Sat, 29 Jun 2019 11:06:41 -0700 (PDT) Date: Sat, 29 Jun 2019 11:06:40 -0700 (PDT) Message-Id: <20190629.110640.41970452437281023.davem@davemloft.net> To: c0d1n61at3@gmail.com Cc: skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift From: David Miller In-Reply-To: <20190627032532.18374-2-c0d1n61at3@gmail.com> References: <20190627010137.5612-1-c0d1n61at3@gmail.com> <20190627032532.18374-2-c0d1n61at3@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 29 Jun 2019 11:06:41 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiunn Chang Date: Wed, 26 Jun 2019 22:25:30 -0500 > Shifting signed 32-bit value by 31 bits is undefined. Changing most > significant bit to unsigned. > > Changes included in v2: > - use subsystem specific subject lines > - CC required mailing lists > > Signed-off-by: Jiunn Chang Applied.