Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1687913ybi; Sun, 30 Jun 2019 22:02:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqzf6CFFXbBApHsXPfdMj3dNMV7PYUNNKMJUE6z3Sq+oyUdUUbzjHVwx+60j610iXEsmma/o X-Received: by 2002:a17:902:be10:: with SMTP id r16mr26142693pls.294.1561957353202; Sun, 30 Jun 2019 22:02:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561957353; cv=none; d=google.com; s=arc-20160816; b=Bim6169VcBHbSgULa+H2SBB9madTfNWCoWS8vNhY5q4AsZNqgIbw1yDm2YsrxqFwND hUlj14NbCLSnRq0oDvwqSWzmdyZTifVGTBp8i6Gm69tl/DDJgYZVsR1/rX0WZBs9MZZy 7RIi+Vk+QIls9KkiUvUGyk7EK+nR9RWVZZlHEB7QLAaRJSVzFu6j1S8QO3F/cp76u0IB oz5BHg6TtTfCmnYv7yUNz98enVtDy9f+s8GXsfWFqSs9CDm2mRKfVMyK6CHNtXCQZMn/ vCeuU4Lri4HRDIGMbgOcD8ioOS9/sKu+pyqzOTCiftRkHK6KgHDes9nuZmqlAk019Mth c+GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=qybcP71evSZ3Czn0uZ7CwmogDfy9EhMz13IGHYQ9cik=; b=GruOwWvbizGJDiF51Z9F85wErtCcyKLobyyU54SIogXDyT5VjNQdHhclgAlMuWtmS+ tSffdViEZ7KWOvGuvTFHVDw5sPbozRg/7SLCxtMOydlbyM8OgDdS2ehpp7l49gKLUr+w gqKcHqminWQt0d79mEaB4/cXvvBwfYA1XboAC6cVVWxMw8UD5THosx15xz5F0qkvtnTq 3bGGrgEfuGn5He+nQax40O0eR9O0qMmW5tNKbeDjRlFUj3C0eFvVaSniBZmoJwPoYmeT L9X9L7sAY6EaxsjlzdqkRlCt2NU5NPo2338vVh//21NOfY0YgI+G0i1rBb2XnlRPdeNH UTYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b="v/51NHIU"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s7si8887172plq.246.2019.06.30.22.02.17; Sun, 30 Jun 2019 22:02:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b="v/51NHIU"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727258AbfGAEEW (ORCPT + 99 others); Mon, 1 Jul 2019 00:04:22 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:38959 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727047AbfGAEEW (ORCPT ); Mon, 1 Jul 2019 00:04:22 -0400 Received: by mail-pl1-f196.google.com with SMTP id b7so6598024pls.6 for ; Sun, 30 Jun 2019 21:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qybcP71evSZ3Czn0uZ7CwmogDfy9EhMz13IGHYQ9cik=; b=v/51NHIUki6YLjlvVPl3Jkfy7LUXWmK+iv3xk/Yp5JXZfN1742/jzEvBIYfRQKD8nZ ZAoHAoVAOPwhteWQ+O8bq5IIwUuoqa5AaYkLo+24ZtRhoUoQkVBZADwqS64JFYX6WytD X0ReoI/87B2gO5zL342T39V9EKj51eCT+uqLc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qybcP71evSZ3Czn0uZ7CwmogDfy9EhMz13IGHYQ9cik=; b=kiUkbySgJ40Y/nEmENTaEqa9YQvVJdgDpM/eOr8NWEpLl9BCA/0vwkDIdXyi1ILKWZ lnXcqDG+8rLqr/nxmJHPVAGRyz/jlKNHGJMOGFphXbvZhyMTRkhPEEheASAZY2kqZlsa EVI02DdtNJm8oa/7CXGczj+UPwO6r+b7hizomRmfF+JG3ughIw0FBEcV97qA8hQqGRnH Hx4oms+/5QPD7ZpIfDSeZVcfL345TLnUH0owgi55tXsmv4a6r2C5LTm3FveNSaV/J8m7 jDvdu/Y+8fRdwUUB5pGfroSMnp0Ex7LETPGOlx/+OPYsbrw4aHlp7ObijAg5iUMj+apx NlpQ== X-Gm-Message-State: APjAAAUs2VvTlJx8z+LJlNv5DntOzTdAPKW7TQToC3wWaniKsnc8DPOl s1bB0k6ujESMyXLzgCrGfh5vm7uSFd8= X-Received: by 2002:a17:902:70c3:: with SMTP id l3mr26445926plt.248.1561953860960; Sun, 30 Jun 2019 21:04:20 -0700 (PDT) Received: from joelaf.cam.corp.google.com ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id w1sm10841305pjt.30.2019.06.30.21.04.18 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 30 Jun 2019 21:04:20 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Josh Triplett , kernel-team@android.com, Lai Jiangshan , linux-kselftest@vger.kernel.org, Mathieu Desnoyers , "Paul E. McKenney" , rcu@vger.kernel.org, Sebastian Andrzej Siewior , Shuah Khan , Steven Rostedt Subject: [RFC 1/3] rcu: Expedite the rcu quiescent state reporting if help needed Date: Mon, 1 Jul 2019 00:04:13 -0400 Message-Id: <20190701040415.219001-1-joel@joelfernandes.org> X-Mailer: git-send-email 2.22.0.410.gd8fdbe21b5-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The t->rcu_read_unlock_special union's need_qs bit can be set by the scheduler tick (in rcu_flavor_sched_clock_irq) to indicate that help is needed from the rcu_read_unlock path. When this help arrives however, we can do better to speed up the quiescent state reporting which if rcu_read_unlock_special::need_qs is set might be quite urgent. Make use of this information in deciding when to do heavy-weight softirq raising where possible. Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/tree_plugin.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h index c588ef98efd3..bff6410fac06 100644 --- a/kernel/rcu/tree_plugin.h +++ b/kernel/rcu/tree_plugin.h @@ -622,7 +622,8 @@ static void rcu_read_unlock_special(struct task_struct *t) t->rcu_read_unlock_special.b.exp_hint = false; exp = (t->rcu_blocked_node && t->rcu_blocked_node->exp_tasks) || (rdp->grpmask & rnp->expmask) || - tick_nohz_full_cpu(rdp->cpu); + tick_nohz_full_cpu(rdp->cpu) || + t->rcu_read_unlock_special.b.need_qs; // Need to defer quiescent state until everything is enabled. if (irqs_were_disabled && use_softirq && (in_interrupt() || -- 2.22.0.410.gd8fdbe21b5-goog