Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1823151ybi; Mon, 1 Jul 2019 00:50:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqyF/DDFY6r6SwIMz4LShqlbB3/+PkEQjBThpVBHFP3uPAaC4aiZvrGLyiG7MfDUhkcONooU X-Received: by 2002:a17:902:294a:: with SMTP id g68mr28117025plb.169.1561967418857; Mon, 01 Jul 2019 00:50:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561967418; cv=none; d=google.com; s=arc-20160816; b=GTCMk3+WwAER2WxUHrAHVX+9f74gNlT1YAHMTORnos7FhwoHnZAkR9FOXs+bl0Zqwr +/g03ceUy6DsyI99ej09N63oXV2oRJVmsBebjalFAuyMpx9NSYlQVEJ71kUoGN2ybYpI Q8U2t0RK+KFEGJk5L4j4sHd81KqBFq36OixYyZgph4nsJ0st/9ePARYyZw7H2S82UWlr rMlKCcJ3D+EVpqOAbUeSzQtur8WiJOuwQOpaeujpYDXc+3PWAf1DTF/fqZFItqWJ0EYj 1zZ+TU5Nu3U9kntkmdbQSlSbIgjB5BoULGAE3+ZkRCLmGISjiVjgYRFULzrxlnMipBm8 6Wrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=yGNH6q7up5V7ER2PzNmaJMoYq9Surm2ZJz4aJExmkx8=; b=UlIB61g+DmvNlag6w9RCn49Udygi3MX3FRhAOpY4iFeTt3WNiZez3eE5/m4mE70Z79 5SB05H9W1TUFcPmJjf9HCMM4ZXQeq2XLrBQ6F1JpQh6JkhcRYdB5emsBslohnnAfuhXy KHEeSpTa12Sl3bIm8UAu2BWefIifCxzlEzC8NlRG6WhtO78i5PtCY0j56r/Qu0Y7c9Vd n/g1IqE6OdBSZxnlYe6pqZoJGQp7MFeJi7++5qmOn5VpFN35FEcSwDDIk/6ngUPrF0qe NSDOD5d0qL1GZOELx/8aiKAOS67mm4M5Ih+ihgmeIt8yj/ugRneiXolV6SPdL9UgmH30 2UOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y92si337895plb.209.2019.07.01.00.50.03; Mon, 01 Jul 2019 00:50:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727773AbfGAHOD (ORCPT + 99 others); Mon, 1 Jul 2019 03:14:03 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:39710 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727723AbfGAHOC (ORCPT ); Mon, 1 Jul 2019 03:14:02 -0400 Received: from pd9ef1cb8.dip0.t-ipconnect.de ([217.239.28.184] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hhqVf-0007zg-BT; Mon, 01 Jul 2019 09:13:55 +0200 Date: Mon, 1 Jul 2019 09:13:54 +0200 (CEST) From: Thomas Gleixner To: Feng Tang cc: "Chen, Rong A" , "tipbuild@zytor.com" , Ingo Molnar , "lkp@01.org" , LKML , "H. Peter Anvin" , x86@kernel.org Subject: Re: [LKP] [x86/hotplug] e1056a25da: WARNING:at_arch/x86/kernel/apic/apic.c:#setup_local_APIC In-Reply-To: Message-ID: References: <20190620021856.GP7221@shao2-debian> <58ea508f-dc2e-8537-fe96-49cca0a7c799@intel.com> <20190628063231.GA7766@shbuild999.sh.intel.com> <20190630130347.GB93752@shbuild999.sh.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Feng, On Sun, 30 Jun 2019, Thomas Gleixner wrote: > On Sun, 30 Jun 2019, Feng Tang wrote: > > On Sun, Jun 30, 2019 at 01:35:39PM +0200, Thomas Gleixner wrote: > > > On Sat, 29 Jun 2019, Thomas Gleixner wrote: > > > > On Fri, 28 Jun 2019, Thomas Gleixner wrote: > > > > > On Fri, 28 Jun 2019, Feng Tang wrote: > > > > > That function just 'works' by chance not by design. I'll stare into it and > > > > > fix it up for real. > > > > > > > > > > Thank you very much for that information. Your debug was spot on! > > > > > > > > I rewrote that function so it actually handles that case correctly along > > > > with some other things which were broken and force pushed the WIP.x86/ipi > > > > branch. > > > > > > > > Can you please run exactly that test again against that new version and > > > > verify that this is fixed now? > > > > > > Just found another issue with that thing. Don't waste your time on it. I'll > > > come back to you when I'm done. > > > > Ok. I noticed that the ipi branch has been merged to tip/master. > > Yes, but it will be zapped there as well. In case you still have your debug version (that old tree which triggered the warn) around, could you please run that again and add 'lapic=notscdeadline' to the kernel command line please? Thanks, tglx