Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1974123ybi; Mon, 1 Jul 2019 03:56:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqw3Q6x5ArGwF5qo4B8runUKvATg6OpDMZVrVNxlIZa7jWl7ATOSX5QK/rN6r2y8mwC9FJxN X-Received: by 2002:a17:90a:8a15:: with SMTP id w21mr30648819pjn.134.1561978567014; Mon, 01 Jul 2019 03:56:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561978567; cv=none; d=google.com; s=arc-20160816; b=adnoCCgEbbbcxn7BmjxSc/cokG5RZQaNnTODIn7MjFJxvaYihSa3L2Dxv6WR9ITmSw 8wqHBH/ToSLO07QGsI7GeJFDIFDj1gAcOtIOMa/wAOvaOow+pCvjSrofazqXk+L4rh6p GfVavt0BtW51AfvQDPCsSpz9qZg6xJFdZncqBCTMNpK4X5RCR5qI+W08dLEU3ZRoa8Ta eabq3V1vqSPVkEqRXH3yvR++1hI/HX6X/5HvDWg12FKu+hahMSWDzN2gmXTVresylF+P GX1qVZ6t2N/MK8J330lx2/WhM0ibgEAFHP/NjeGoQ+dpd7q9xD6H4oV5og8vpXgSNoTc 5kMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=1paeMvaB6sFj7F79uNkQYX9SLk9cdU3WGOl41iOzPks=; b=bCIcplDaUChtOllPSVIzY/p6LcoN/OD5Z8k04ebXhhKwsTGB0QT+8/hb1GN3SHvKwi 5a6gUBkQAvPZ7pYtLqNiDasZ/q+pWWr45mwmJkoEAwEkEDKKdCaOwpO8kSrU7NwtCSVf UIm9JnUjF7Xa4SCJqKZV0MjHmuJqTCFCo/Xcl8jfsz4GZwnLBpS9EljsOOAAojhkeDxb tb+Ok2wUgSiL433JaSZSEyIbmIsEsLeJIrpV/C+vGtpigFvKAOx+CDbtYRV7+zMwdUDV IRKTi6v9FoPmlD+LVnZ00aEyFDw+pQkyxfpwEzQnqo9FJabU+clMXQk4Qs0lYTal7Gom pKBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q5si9505509pgp.111.2019.07.01.03.55.51; Mon, 01 Jul 2019 03:56:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728547AbfGAJrn (ORCPT + 99 others); Mon, 1 Jul 2019 05:47:43 -0400 Received: from inva021.nxp.com ([92.121.34.21]:59520 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726652AbfGAJrm (ORCPT ); Mon, 1 Jul 2019 05:47:42 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id D60CE200910; Mon, 1 Jul 2019 11:47:39 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id DAD13200015; Mon, 1 Jul 2019 11:47:28 +0200 (CEST) Received: from titan.ap.freescale.net (TITAN.ap.freescale.net [10.192.208.233]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id D34AF40297; Mon, 1 Jul 2019 17:47:15 +0800 (SGT) From: Anson.Huang@nxp.com To: daniel.lezcano@linaro.org, tglx@linutronix.de, robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, leonard.crestez@nxp.com, viresh.kumar@linaro.org, daniel.baluta@nxp.com, ping.bai@nxp.com, l.stach@pengutronix.de, abel.vesa@nxp.com, andrew.smirnov@gmail.com, ccaione@baylibre.com, angus@akkea.ca, agx@sigxcpu.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Linux-imx@nxp.com Subject: [PATCH V4 1/5] clocksource: timer-of: Support getting clock frequency from DT Date: Mon, 1 Jul 2019 17:38:22 +0800 Message-Id: <20190701093826.5472-1-Anson.Huang@nxp.com> X-Mailer: git-send-email 2.14.1 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anson Huang More and more platforms use platform driver model for clock driver, so the clock driver is NOT ready during timer initialization phase, it will cause timer initialization failed. To support those platforms with upper scenario, introducing a new flag TIMER_OF_CLOCK_FREQUENCY which is mutually exclusive with TIMER_OF_CLOCK flag to support getting timer clock frequency from DT's timer node, the property name should be "clock-frequency", then of_clk operations can be skipped. User needs to select either TIMER_OF_CLOCK_FREQUENCY or TIMER_OF_CLOCK flag if want to use timer-of driver to initialize the clock rate. Signed-off-by: Anson Huang --- Changes since V3: - use hardcoded "clock-frequency" instead of adding new variable prop_name; - add pre-condition check for TIMER_OF_CLOCK and TIMER_OF_CLOCK_FREQUENCY, they MUST be exclusive. --- drivers/clocksource/timer-of.c | 29 +++++++++++++++++++++++++++++ drivers/clocksource/timer-of.h | 7 ++++--- 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/drivers/clocksource/timer-of.c b/drivers/clocksource/timer-of.c index 8054228..ab155cc 100644 --- a/drivers/clocksource/timer-of.c +++ b/drivers/clocksource/timer-of.c @@ -161,11 +161,30 @@ static __init int timer_of_base_init(struct device_node *np, return 0; } +static __init int timer_of_clk_frequency_init(struct device_node *np, + struct of_timer_clk *of_clk) +{ + int ret; + u32 rate; + + ret = of_property_read_u32(np, "clock-frequency", &rate); + if (!ret) { + of_clk->rate = rate; + of_clk->period = DIV_ROUND_UP(rate, HZ); + } + + return ret; +} + int __init timer_of_init(struct device_node *np, struct timer_of *to) { + unsigned long clock_flags = TIMER_OF_CLOCK | TIMER_OF_CLOCK_FREQUENCY; int ret = -EINVAL; int flags = 0; + if (to->flags & clock_flags == clock_flags) + return ret; + if (to->flags & TIMER_OF_BASE) { ret = timer_of_base_init(np, &to->of_base); if (ret) @@ -180,6 +199,13 @@ int __init timer_of_init(struct device_node *np, struct timer_of *to) flags |= TIMER_OF_CLOCK; } + if (to->flags & TIMER_OF_CLOCK_FREQUENCY) { + ret = timer_of_clk_frequency_init(np, &to->of_clk); + if (ret) + goto out_fail; + flags |= TIMER_OF_CLOCK_FREQUENCY; + } + if (to->flags & TIMER_OF_IRQ) { ret = timer_of_irq_init(np, &to->of_irq); if (ret) @@ -201,6 +227,9 @@ int __init timer_of_init(struct device_node *np, struct timer_of *to) if (flags & TIMER_OF_CLOCK) timer_of_clk_exit(&to->of_clk); + if (flags & TIMER_OF_CLOCK_FREQUENCY) + to->of_clk.rate = 0; + if (flags & TIMER_OF_BASE) timer_of_base_exit(&to->of_base); return ret; diff --git a/drivers/clocksource/timer-of.h b/drivers/clocksource/timer-of.h index a5478f3..a08e108 100644 --- a/drivers/clocksource/timer-of.h +++ b/drivers/clocksource/timer-of.h @@ -4,9 +4,10 @@ #include -#define TIMER_OF_BASE 0x1 -#define TIMER_OF_CLOCK 0x2 -#define TIMER_OF_IRQ 0x4 +#define TIMER_OF_BASE 0x1 +#define TIMER_OF_CLOCK 0x2 +#define TIMER_OF_IRQ 0x4 +#define TIMER_OF_CLOCK_FREQUENCY 0x8 struct of_timer_irq { int irq; -- 2.7.4