Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2072392ybi; Mon, 1 Jul 2019 05:45:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqxahuP2+B+aK7mCjSFt5WKLlMZyEILBRL45QFY4SAkIXFv14PfEo/IgMldA52P126iEPcvP X-Received: by 2002:a17:902:2ae8:: with SMTP id j95mr26549207plb.276.1561985107322; Mon, 01 Jul 2019 05:45:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561985107; cv=none; d=google.com; s=arc-20160816; b=OdWfn0vZavv9GovzLjk3OQpdS3ycpr1EsgE1TKITLI8wM5SSvXzCCliLIBObCEeUrp C/j6NhuzQagdcgaCG8c8znOM+kGmNBz0jRX6kE0pV5Kh8duLgLoDC8S4bVZAu5AFyUOP dtjVH7E6gK3/SE2yHqtemueIntSdkoIlaYLJfhYZ/kF7EnGhOTtJA3YOj/dLwxhARlfW KTeqh7X0MP6y4DJrR6+5UvQq1vqLYqrkWszUAX+DYB4GQCatk2CrThF8g3Wjy2agjS+c Hra+NSS/aC3yg1PXIRANTROn+Bm9rU+SrDPr2OtER/1ZFPNzkuf3VsjOMinwbZRtI83f LKVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=q8qXk/n+3rdVBDEavtXjY7etsHzDiYEiRL3WTtVL85Y=; b=FvsaqZoI7w8iuqaPYuE0/B150H+Kj+BPtiC3hEdfsKuuM0Gw9spDNtbPBBiCplDPx2 fDRIWPl/BtzeL/0tZvIfVdqk81QqoIv3aSEkbtHe6WZdd7QRb0VsvPRLouu6O+WkrMdh qIkjd20iqYPl+zkEDx1zkzezY5pzuUmy4+8WGg0fUgXadZHTdcfscd22KI1VQgC1AAR0 hGpq9GhoRC3KD2gJaK7EVUFF+05GTZn72BH7dSVJcQ49lCgAuQ9X7te0XI8YUtuwFHvx icSgw9jHj+WxcRR///j7dfH81QatMvV7tqSpoTHRZOEwPMokRd/hhs35M1mqOgVeNS8P g+9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="qYcY/7lQ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g185si9959220pgc.240.2019.07.01.05.44.51; Mon, 01 Jul 2019 05:45:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="qYcY/7lQ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728914AbfGAMhU (ORCPT + 99 others); Mon, 1 Jul 2019 08:37:20 -0400 Received: from mail-ua1-f66.google.com ([209.85.222.66]:39047 "EHLO mail-ua1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727372AbfGAMhU (ORCPT ); Mon, 1 Jul 2019 08:37:20 -0400 Received: by mail-ua1-f66.google.com with SMTP id j8so4979326uan.6; Mon, 01 Jul 2019 05:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q8qXk/n+3rdVBDEavtXjY7etsHzDiYEiRL3WTtVL85Y=; b=qYcY/7lQy1CgNd8mir2T92J/oON5i+/nuKlFXZbwntSuvuJwOcgd5/nbtSfY9c5wyK 68U+Qg0FMSB07vB2zreh5uJ0/057ANxLNDTzaNtIrRod8+E8PUmEPV8zB+CyzVbpetdi 7iLYej+bNrBSeIEdu8AAmmE5MKztobYW4JAHWauvGIyDL+MwSB+suBGxZWFFm7GNDOsR S21Vix2PC5KtrjI8V2uUHvM9QtzqcruXKJNC+NJa45roazBRj7xNp/nyhnu4HpBejhjt d/giHHUifsBkWTZgsFQ8ijJ0gfMLmtv6aEYpOpU1sK5cz5fRdo/cjdLoRrpsbiD15LSf DNTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q8qXk/n+3rdVBDEavtXjY7etsHzDiYEiRL3WTtVL85Y=; b=Gql5f/tFtNM1yPkVJFZjrcSsIYGuQqWVobVKxS7FD1JEfN4LigmSvgbK7T+vy3e0Hc ViyERjieNMbspAF1Ir+neETA1i4q8Y2jSgvM9TnvjebfiLO2hvy7t0V0oxXIBpkqHSaV baY9hlPWIB3/hxwsiiOUgi/7t83ds0gKr+42HjR+k4knmP8PHWx3FXm54Kgf+V+7MsTY Xbe6tKuWF9iyZW1A0IBMyuaJjvMzGdIR67aQb3GJwuFYVexVCm2I8UztBWfS/j5BzAij seOe7Hw10VxR/3iqEp59amVMyhyo+JrzJxUU4GGWXJVcUdOJgu7gD5/tQAq+NSEhym8b m7Sg== X-Gm-Message-State: APjAAAVSIJ2aUlTxXGdDO8HYFqWsKq0nxEhVM3wZ72ZI8HTZVixRMJL+ CdyPvZ/0fyjN0GNc8iT9XTx/9RbX0GANQVfRag4= X-Received: by 2002:ab0:5973:: with SMTP id o48mr5077380uad.19.1561984639288; Mon, 01 Jul 2019 05:37:19 -0700 (PDT) MIME-Version: 1.0 References: <20190701032245.25906-1-huangfq.daxian@gmail.com> In-Reply-To: <20190701032245.25906-1-huangfq.daxian@gmail.com> From: Emil Velikov Date: Mon, 1 Jul 2019 13:37:33 +0100 Message-ID: Subject: Re: [PATCH 1/4] gpu: Use dev_get_drvdata() To: Fuqian Huang Cc: David Airlie , ML dri-devel , Chandan Uddaraju , Laurent Pinchart , Jonathan Marek , Sebastian Reichel , Mamta Shukla , Tomi Valkeinen , Sibi Sankar , freedreno@lists.freedesktop.org, Rajesh Yadav , linux-arm-msm , Abhinav Kumar , Bruce Wang , Thomas Gleixner , Sean Paul , Tomeu Vizoso , Greg Kroah-Hartman , "Linux-Kernel@Vger. Kernel. Org" , Daniel Mack , Enrico Weigelt , Sravanthi Kollukuduru Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fuqian, On Mon, 1 Jul 2019 at 08:13, Fuqian Huang wrote: > > Using dev_get_drvdata directly. > > Signed-off-by: Fuqian Huang > --- > drivers/gpu/drm/msm/adreno/adreno_device.c | 6 ++---- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 13 +++++-------- > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 6 ++---- > drivers/gpu/drm/msm/dsi/dsi_host.c | 6 ++---- > drivers/gpu/drm/msm/msm_drv.c | 3 +-- > drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 15 +++++---------- > drivers/gpu/drm/panfrost/panfrost_device.c | 6 ++---- As far as i can see the patch is spot on, thanks for that. Can you split this in three since it covers 3 separate drivers. For each one you can get a smaller CC list - patches with 20+ people tend to get blocked :-( We can pick the PANFROST entries from the get_maintainer.pl output, and add them to the commit message. Thus git send-email will parse the commit message and automatically CC the people ;-) Cc: Rob Herring (supporter:ARM MALI PANFROST DRM DRIVER) Cc: Tomeu Vizoso (supporter:ARM MALI PANFROST DRM DRIVER) Cc: dri-devel@lists.freedesktop.org (open list:ARM MALI PANFROST DRM DRIVER) HTH -Emil