To: Adrian Bunk <bunk@stusta.de>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
       mshefty@ichips.intel.com, halr@voltaire.com, openib-general@openib.org,
       linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/infiniband/core/mad.c: fix a NULL pointer
 dereference
References: <20051126233736.GE3988@stusta.de> <52irud4pki.fsf@cisco.com>
	<20051128002523.GA31395@stusta.de> <52psok1wne.fsf@cisco.com>
	<20051129123052.GF31395@stusta.de>
From: Roland Dreier <rolandd@cisco.com>
Date: Tue, 29 Nov 2005 09:07:58 -0800
In-Reply-To: <20051129123052.GF31395@stusta.de> (Adrian Bunk's message of
 "Tue, 29 Nov 2005 13:30:52 +0100")
Message-ID: <52veybwff5.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.17 (Jumbo Shrimp, linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 915
Lines: 22

    Roland> Is this really important enough for the stable tree?

    Adrian> You said it fixed a crash for you.

To trigger the patch, you have to hit the error path, which in
practical terms requires buggy code calling into the function.  And
you also have to either be running with CONFIG_DEBUG_SLAB=y or be
extremely unlucky.  So I don't think anyone who's not developing IB
driver code could ever hit the crash, and any developers are going to
be running the latest tree anyway.

    Adrian> Besides this, it's a small and easy to verify change.

Sure, I don't mind it going into the stable tree.  I'm just not sure
it's worth spending everyone's time on it.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/