Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2271589ybi; Mon, 1 Jul 2019 09:07:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqz76TCv0NUaSFPP5kFi2GPxGR25TBIvpD5BNyQlw6Apm7mIHkCO1BaUg+H5ADVBSS79fAna X-Received: by 2002:a17:90b:d82:: with SMTP id bg2mr22035pjb.87.1561997226303; Mon, 01 Jul 2019 09:07:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561997226; cv=none; d=google.com; s=arc-20160816; b=br8LuSCKrqdObTeYR9sK41FC4QRHeD2xDAvFOtI5UggcXjRoks//GA/F1bVdK4kBOF zsJkDlvzThFtQcNoEdgPfyn8K0hFzN6/kOY64v/XlqJns5Kc69NAQmvTsqF74VJT2u1p /j83s8+xWFBdITUzU4Loquf8TrhGSgrmfN7C9Vfma+VXzGHsCkIa4XsAKhItgE7GA4i8 I20KkEfRRK6zPgJV05Iam9yGunJsriRPHnYcc9uQvYYibfEurMe3IT8ab6HSZ3XryetD 9b2dkpa2XgligUnMZ0378FFIvpMtsrZH3PEFO+uE9kE/uKob8zMsE6vTGJadTr88gfWZ RXTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=NTP79L4cfaJkzK//wnWLwy4euQgPkxVf2LmYZb6jqAo=; b=EM6yXkfABdvZfIgEzRK2ctqg+C+hXfhUC7CM27zqPoYx3T943vAOk3Skoqf8lWAzAb 8M8Ha01V7cteZEuSjz4cD0GuzN7fepuRH8lItJP2gbb3qmILVQcYk6UvZmKeFNDJ0wkm fi+bkUvqnc8ZdYCU7X7K+4IuUelO3+j9Whf2gkMA4QsQ+7g5sYSrFt757dBC5w1X8m/N rCRsO8ctaubQ9NFzGzJHa37OkkFs+KGld14H8414jZV3nfLbFwhpURwvbwkzZAU0blb3 4N7rMuphnJpTL0I5Pa48V0zAZkCtmAzYa6PutdjuOqIMrkEqXVh3EoqLFi88UxkPeQ97 iKVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eiiDwTWv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o8si9837048pgp.568.2019.07.01.09.06.49; Mon, 01 Jul 2019 09:07:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eiiDwTWv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728821AbfGAP0K (ORCPT + 99 others); Mon, 1 Jul 2019 11:26:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:38172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727810AbfGAP0K (ORCPT ); Mon, 1 Jul 2019 11:26:10 -0400 Received: from localhost (unknown [122.167.76.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 87AEA208E4; Mon, 1 Jul 2019 15:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561994769; bh=f6Vhp2JOFVYPly+oy0IG8d1NArRJ8kNupx/z8r2urwo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eiiDwTWvFvNOl3K8T00Vo2UnctJIxYxlt6zhzuO7ORU54jGeuPKdtwfTUf5502fzU 0wu7iTvRGN0MoLWVhliMIZI5Osqz8gGpVyrbVSI5pLOCVSjzOUQT5o7qHplOxU2XtV pSXSQoMsD4jqvZzQDUJcb4yQzOVu4b5WFN72xhFo= Date: Mon, 1 Jul 2019 20:52:57 +0530 From: Vinod Koul To: Jorge Ramirez-Ortiz Cc: agross@kernel.org, adrian.hunter@intel.com, ulf.hansson@linaro.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, khasim.mohammed@linaro.org Subject: Re: [PATCH v2] mmc: sdhci-msm: fix mutex while in spinlock Message-ID: <20190701152257.GM2911@vkoul-mobl> References: <20190701150125.2602-1-jorge.ramirez-ortiz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190701150125.2602-1-jorge.ramirez-ortiz@linaro.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01-07-19, 17:01, Jorge Ramirez-Ortiz wrote: > mutexes can sleep and therefore should not be taken while holding a > spinlock. move clk_get_rate (can sleep) outside the spinlock protected > region. Reviewed-by: Vinod Koul -- ~Vinod