Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190701032245.25906-1-huangfq.daxian@gmail.com> <CACvgo52N7c3mtAvfH-98pkgHC6UpdKPNH+cYozb4yRsMetMhkg@mail.gmail.com>
In-Reply-To: <CACvgo52N7c3mtAvfH-98pkgHC6UpdKPNH+cYozb4yRsMetMhkg@mail.gmail.com>
From:   Emil Velikov <emil.l.velikov@gmail.com>
Date:   Mon, 1 Jul 2019 17:56:02 +0100
Message-ID: <CACvgo525gKG1xok-O-AmTLT4OgupB2FCoO=qeBqS=DXK5vhFOg@mail.gmail.com>
Subject: Re: [PATCH 1/4] gpu: Use dev_get_drvdata()
To:     Fuqian Huang <huangfq.daxian@gmail.com>
Cc:     David Airlie <airlied@linux.ie>,
        ML dri-devel <dri-devel@lists.freedesktop.org>,
        Chandan Uddaraju <chandanu@codeaurora.org>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Jonathan Marek <jonathan@marek.ca>,
        Sebastian Reichel <sebastian.reichel@collabora.com>,
        Mamta Shukla <mamtashukla555@gmail.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Sibi Sankar <sibis@codeaurora.org>,
        freedreno@lists.freedesktop.org,
        Rajesh Yadav <ryadav@codeaurora.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Abhinav Kumar <abhinavk@codeaurora.org>,
        Bruce Wang <bzwang@chromium.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sean Paul <sean@poorly.run>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        Daniel Mack <daniel@zonque.org>,
        Enrico Weigelt <info@metux.net>,
        Sravanthi Kollukuduru <skolluku@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 1 Jul 2019 at 13:37, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>
> Hi Fuqian,
>
> On Mon, 1 Jul 2019 at 08:13, Fuqian Huang <huangfq.daxian@gmail.com> wrote:
> >
> > Using dev_get_drvdata directly.
> >
> > Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> > ---
> >  drivers/gpu/drm/msm/adreno/adreno_device.c      |  6 ++----
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c         | 13 +++++--------
> >  drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c        |  6 ++----
> >  drivers/gpu/drm/msm/dsi/dsi_host.c              |  6 ++----
> >  drivers/gpu/drm/msm/msm_drv.c                   |  3 +--
> >  drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 15 +++++----------
> >  drivers/gpu/drm/panfrost/panfrost_device.c      |  6 ++----
> As far as i can see the patch is spot on, thanks for that.
>
> Can you split this in three since it covers 3 separate drivers.

Quick grep for "platform_get_drvdata(to_platform_device" showed a few
instances through various drivers - exynos, msm, etc.
If you can address those with v2 that would be great.

-Emil