Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2404117ybi; Mon, 1 Jul 2019 11:25:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqzv//slYO8Xn8n2cL3dKvNDQPFO1BdvZbE2s6KD5nTPoYS709K/AUShctkYnfZKCSi9ozo3 X-Received: by 2002:a63:24c1:: with SMTP id k184mr26719853pgk.120.1562005506789; Mon, 01 Jul 2019 11:25:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562005506; cv=none; d=google.com; s=arc-20160816; b=xikCXrdTeQVfWlILHdBUDtMwhHEryFKgBiAYCl+TNKm//En77XnU9E4wrfEsbSnbUl KftxBDAM5orUJd+ez0821lh5J2HSD6ro8qHaILderCbB7HxK6+mm4ulT7JLbzf2Nk4xN TrhP3F/TMfVxqQVmSxg2bg6A2csDFvaBpuK3C08hUkCJlEo5wW5yjNcCDHeGU0jHRFfY 8JEeGG6oApQbuq+GaCslX795jUqSVvrKJBG9bmY1ao+HGjNZDndMOlz/Hgpnb5XXKmQH YZDy8YXbFLps10x1dmJgiGcJnu0njssBfl5ZBEM7eASsC7YtLPSyj9A2fy7vyVvbUYTm QGsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:to:subject:dkim-signature; bh=lSeGwgb7OCHIZ0lDpAKilpMUUcD2EKTAejOKK6LikFQ=; b=pFGAFwuSykBBnYyGMK5WHEwf1sgXq4jmBw4323jBqBpiyOF9iuYv4f3fvidSv75Dvr T1csgaYn/iDA1JSLel4/U3Xz7YaU9yPqNMbaGpvmH58HM17wXzvlYVBmmYImT7MZTlFP WIsPN8IaqoOCd4u0Al9bPClv94hejYvPr/I2LyLc4En+Tr/Osu+dh4DMNXSqWpySRVvx PRiCmbjqWiudaPnfi8E5vRkPANfWA8zoUUdZ4RFAvA5aCH9bvhjuAiTl8m0zkbrgBifi TToUwY0WQm8BtGULXX+2Pvvr1CBG0XptVQYeCabjZgOWMN7UD5f54Eew1cTeHOIkmR7h 9jYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=e77hRdek; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n6si9330743pgp.424.2019.07.01.11.24.52; Mon, 01 Jul 2019 11:25:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=e77hRdek; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727255AbfGASWP (ORCPT + 99 others); Mon, 1 Jul 2019 14:22:15 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:45115 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726987AbfGASWO (ORCPT ); Mon, 1 Jul 2019 14:22:14 -0400 Received: by mail-lf1-f68.google.com with SMTP id u10so9415192lfm.12 for ; Mon, 01 Jul 2019 11:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:organization:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lSeGwgb7OCHIZ0lDpAKilpMUUcD2EKTAejOKK6LikFQ=; b=e77hRdekb5Ksd1Rsj0fXd4QUcYSQWip33lsHjZwlobtp8hSu+bdm8BuUoQZg2SmIuJ HcgNgRizUQQRYmcssGQ0o5S8HyGblr9QKslVYYOZYOWRleFBchsDhgMg6/uztcIKPHyD Zrqsxt2BdK9G6bp0t5QftvWtOn650n+KpKpZtRUrmueqjheTJ+yOQqxddQGG4Z/60lKF 45EIuSgi3v65Olqm0cCe4f3EkrSXZ+BedxDj4YNnubY8xsSOhrSrBw916twRg8mw7pt0 ppKZCyVm1FZ9ojqssfg/Lup17kvQnUIdyqzVF+2oT3ZB4rQUK9TvIhbX4HarDNW+6t/D duYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=lSeGwgb7OCHIZ0lDpAKilpMUUcD2EKTAejOKK6LikFQ=; b=fUE2xSeDlMAqDrOd21ROGrCqj5LinuJ0hqG7VH1crmkMwj6cP1i2ThY2WozE2aXJef 86sS/fin+HfX5DKqlAywv3cEXWeppLPJTBJNDG5VQb5OoJfIVQN9RdGOVvrztoUZB1as nDwMlFg3q4BrAOIHntuTBG/VLHi43x94VghWc6K0GB4WINJtYyfCbVAmWHRhQOHOAZNr hBMU3Auc0ceA9U0xFWWkoIaOmZtgcst9F5tAUTrgXu/8o48GuPrtt3wXTFLxs6U2ly9q y2ZF80KyKoXa2mSk+Vbifu03rQf0Se6w+vVgSqYFQksMdQ/jU2t+2G3T4eibojhrfAfi n9Ww== X-Gm-Message-State: APjAAAX6/HDJc/ko2GvohNaYUjofg2Dkh77Ya7rDv0DZ6nd2uOave4OQ 3aTdYytXnaJma3cp1Xb8P0Vr51idP5I= X-Received: by 2002:ac2:482d:: with SMTP id 13mr12078669lft.132.1562005332513; Mon, 01 Jul 2019 11:22:12 -0700 (PDT) Received: from wasted.cogentembedded.com ([2a00:1fa0:87f:4d67:ad95:f728:cfaa:94d0]) by smtp.gmail.com with ESMTPSA id p15sm3440617lji.80.2019.07.01.11.22.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Jul 2019 11:22:11 -0700 (PDT) Subject: Re: [PATCH] USB: gadget: function: fix issue Unneeded variable: "value" To: Hariprasad Kelam , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190701182031.GA10455@hari-Inspiron-1545> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <746df16a-0e8d-bae7-36ff-5827610dfd99@cogentembedded.com> Date: Mon, 1 Jul 2019 21:22:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20190701182031.GA10455@hari-Inspiron-1545> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 07/01/2019 09:20 PM, Hariprasad Kelam wrote: > fix below issue reported by coccicheck > drivers/usb/gadget/function/f_eem.c:169:7-12: Unneeded variable: > "value". Return "- EOPNOTSUPP" on line 179 > > We can not change return type of eem_setup as its registed with callback Registered. > function > > Signed-off-by: Hariprasad Kelam [...] MBR, Sergei