Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2418105ybi; Mon, 1 Jul 2019 11:41:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqxsVCbJou+Y5gKYcGECqYaPCaQOrSou2Vqyc190YH48kJjNSIZKWqjX8xRD3GMjuUG2IxIz X-Received: by 2002:a17:902:112c:: with SMTP id d41mr30127350pla.33.1562006471797; Mon, 01 Jul 2019 11:41:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562006471; cv=none; d=google.com; s=arc-20160816; b=CNIh/LF7b6fLJQfwCICcjXGv9Tv/ciFI81v/z2qBr/aoAGF1iNfe8jjvByIulkx5S+ ZJVHn8HyvxUW74KuaRY+iQsEgYeOqcpmpC+rK1Wib1zmEMXJRuaUMTStyLZJu6hERt6z o1xrzcPZtGP7reJWzzwdLUNtow29K1Hjs7CnxfgM5/ut4+MouZGCMSVTCvA4P4EnQTqd C0sbrcwgKHhIkpN27rrQoY25bkV772grJ+Gl44EiZX9BgXQGN9JfQzfU/HDH3viqsORI zc63nlsTkkYM/1atjbxLV/cK86QPC5kvH9s780HGX6qvlOpR7Y65BWlZoK4SW7gSGejC Zx/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature; bh=vDdwaBRsvizkPRqGLfxX1uU9+xVc5oKW4WR2FazXdXA=; b=KVoEC5CVtykrIQbgzxLQYGxqSoTMSx0+nSdh0w1EG8oPeH2AAqLaf0BeecZF0utBlR YLS4Z7FThlANuHSKvnIfIMrz6W1P5YH6YxGTbM1tqeeAz5eUM8tTQzOHWbVwOAHXHil2 t247r+0hQ2clM5BinI8o17tJ1C4/MxZmpvUbKnFxrRl9EmibqEFR7ENk+SRBp9bmEDMM k75S7tzSs0Gb1li268+a6ChtrWMvT0NZ6RclNLxk9V9VDvizApPW7UDvVYSd+iThCKx6 aUserR2/93iAyIWRT/dpZ9q9aPNicRUxFY/yOltxw+IbutX6JICEgvMKMGBXM86Pg2WN oX1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="K/7usMny"; dkim=pass header.i=@codeaurora.org header.s=default header.b=OlYrV+PU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m11si7722419pfa.0.2019.07.01.11.40.57; Mon, 01 Jul 2019 11:41:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="K/7usMny"; dkim=pass header.i=@codeaurora.org header.s=default header.b=OlYrV+PU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726960AbfGASjx (ORCPT + 99 others); Mon, 1 Jul 2019 14:39:53 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52586 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726316AbfGASjx (ORCPT ); Mon, 1 Jul 2019 14:39:53 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8C0E36028D; Mon, 1 Jul 2019 18:39:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1562006392; bh=ecZCP0Nl2MvYdNc2PJ+G+AX8dhZHCBiv1DZ4bQurLhc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=K/7usMnyAV2CIYxBNfXpgHdLeUMcCsknMVpBP35DHG2V+UP+hO6D8curADy8aiAft Biu1fmmU9WljiNeyT/cLwG5iLPqK5kqaB/H4nusUnygVqhPI3PtNMPrIK7+/N5IFZW jRWgCBNuydCHB+iRf1NFKq/nLZBES/g5zvsrkysw= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from [10.226.58.28] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jhugo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 940AD6028D; Mon, 1 Jul 2019 18:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1562006391; bh=ecZCP0Nl2MvYdNc2PJ+G+AX8dhZHCBiv1DZ4bQurLhc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=OlYrV+PUD/QozjpxBy2p/EieCA4QwtgFpf13ybP2lZ1OJzn7NTcA4yuynVe5574ii Iqwo5W9FnzbP1OnSrgw4D0AjS7DcxVksD6f56ry8riJziBcSajIse6WrviiA8RxFn9 sBdm4CuecGHdplapbI7tQsVpd006yMuIWj0OknR0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 940AD6028D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jhugo@codeaurora.org Subject: Re: [PATCH 5/5] drm/bridge: ti-sn65dsi86: support booloader enabled display To: Rob Clark , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Cc: freedreno@lists.freedesktop.org, aarch64-laptops@lists.linaro.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Rob Clark , Andrzej Hajda , Laurent Pinchart , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org References: <20190630150230.7878-1-robdclark@gmail.com> <20190630150230.7878-6-robdclark@gmail.com> From: Jeffrey Hugo Message-ID: Date: Mon, 1 Jul 2019 12:39:49 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190630150230.7878-6-robdclark@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/30/2019 9:01 AM, Rob Clark wrote: > From: Rob Clark > > Request the enable gpio ASIS to avoid disabling bridge during probe, if > already enabled. And if already enabled, defer enabling runpm until > attach to avoid cutting off the power to the bridge. > > Once we get to attach, we know panel and drm driver are probed > successfully, so at this point it i s safe to enable runpm and reset the is? > bridge. If we do it earlier, we kill efifb (in the case that panel or > drm driver do not probe successfully, giving the user no way to see what > is going on. Where should the missing ")" be?