Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2560597ybi; Mon, 1 Jul 2019 14:16:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqxM7bb1NRXjGo1x6q6scAyexOzvwllgL81nRmKo0JHi4dJ3dNrBBT3gGN3/MRnX+dQjwry/ X-Received: by 2002:a65:44c8:: with SMTP id g8mr26548118pgs.443.1562015790141; Mon, 01 Jul 2019 14:16:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562015790; cv=none; d=google.com; s=arc-20160816; b=fGI1ykeec68xa/Nkv8e3aazFf/8y8WF5JO+Kd0hYuxzFr1VU5v2BBiumSv2QNEWGr5 lUmz8qqtqpD5ClSRMAPGmpJTXVZSJUl/PZHqpkao+spK9BT3jU47R+ldLnQJvVrp4OYR o0FQ5+L0GM1w/KBQeC8V0+WtGDNVV7S5R4kvx6474T5NAuU1/BBiCX/5oBS69mAxp6aM QagV4wmNijrGTdvAlXLQAUVzdyjTG/Mf5VbzC5TvumywHHrdPGwhu9TaqwHdUJXCkbfY 0/UCIX7LHcZv6ZK3DWfMswNueGC1m6l0q7mFZOEUf26H4PXzib1awE30EderuLcBF5DK l2mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=a5ZhSFhZxBdLju3tQkiTCWkSZRpiCbvjfP/tPOAL/Uk=; b=v/JBkuU42V5tz62iYEgeL/LnGgQq9B8fIkCgAl8A/g4owLRbGI8fbRLt2Gnk1v0NZ1 bYB5bVmp/y22ZPLE5/oxvGAPTrXVX2uQb105Fxu1wJU7/8bLHV0+cnoPhP1iY02dAVhQ qumuqggHgE26cNLYh5yshOZkrk8VbdZgdNEENXahBvrek2coEtaRVBZmE9iDZAKZeIqr 3U+wNQY/Yj502KkGlE5E95o7dm8CB3xQHxg60mqmy2blAxz9HZ1xkyr+odOnai0RfLvj DvjCgLD5n8sNzPqW+3nEw3VQfq3iGf8ADOnaMizqC9KBcXhelN9VrLLugr2K8/b2a9Dr QtcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=fnCLpA3P; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v133si11117590pgb.262.2019.07.01.14.16.15; Mon, 01 Jul 2019 14:16:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=fnCLpA3P; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726838AbfGAVPx (ORCPT + 99 others); Mon, 1 Jul 2019 17:15:53 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:45622 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726509AbfGAVPx (ORCPT ); Mon, 1 Jul 2019 17:15:53 -0400 Received: by mail-io1-f65.google.com with SMTP id e3so32066505ioc.12 for ; Mon, 01 Jul 2019 14:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=a5ZhSFhZxBdLju3tQkiTCWkSZRpiCbvjfP/tPOAL/Uk=; b=fnCLpA3PG2kMCVNRsV6ZrFzmWBf/K1XrjTfF4DFj/YjSu0P7yFq7p5Bsw02q15l3b2 R3yN4d+nVuuGDO890+ttIDI17Z7soQWZZZNzZys9acpTJwCPADRZzRKNEPsFHDX2yGzp 7DNtbWErvgh1YS+jP4YFCik0PcunOIXXPzQ/QGTeg0Ac58Z/UpfX8wkdJJ4d3oLjY8c4 DSFVr6g1uzfCYnyL/0qqIwalVnIaOyLRRXrhQwl/z/O0WDFUFmrq25B8r9W1x1O3iNzN CBCJuVCh4pvN5Jtmkk25cmLISrDGEfR/1rJ++eq8jqmSIDBg0H8VUF7vsG9HjBNTh3wv PpQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=a5ZhSFhZxBdLju3tQkiTCWkSZRpiCbvjfP/tPOAL/Uk=; b=lnHJOfQN5ul+u6HIsKVikC2OGEdwOqI0G/stPfiFw+6gLB2ZfysObVp4a/R+oXpXVv 52ZWgIDvnDvs4Osba4Z1rVFZQepdTNxdxAW40EwnP4XItm90FWsP6SLgx6IUpxVRb17P P5mxtJ9XMjyREwdrpcqZF6lEf69YBx35+QkpikefKABnvW1oksc13c0F0crvedA6+xiE wenyfdIaWAftsdFLJ8X3elgfydzsuqReBlgT/4l7ieJwKTwQIsk231wMLuCpGNz05i0/ w1aJ0/kM8UNLyq8KBjm5PP84ibD9/a0uAZzKJJDuqCbuOPvV87y9nfte7OvZlve09L0+ xnxw== X-Gm-Message-State: APjAAAWqryFC19usnUyZSdpNUhyVs2yKN5otWrHtwGdroVSQhXOAobkU X38ruxGbqsE7XpVwMhlSPycP7w== X-Received: by 2002:a02:554a:: with SMTP id e71mr30796296jab.144.1562015751321; Mon, 01 Jul 2019 14:15:51 -0700 (PDT) Received: from localhost (c-73-95-159-87.hsd1.co.comcast.net. [73.95.159.87]) by smtp.gmail.com with ESMTPSA id m25sm14605769ion.35.2019.07.01.14.15.50 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 01 Jul 2019 14:15:50 -0700 (PDT) Date: Mon, 1 Jul 2019 14:15:50 -0700 (PDT) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: Yash Shah cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, palmer@sifive.com, aou@eecs.berkeley.edu, sachin.ghadi@sifive.com Subject: Re: [PATCH v2] riscv: ccache: Remove unused variable In-Reply-To: <1561977630-32309-1-git-send-email-yash.shah@sifive.com> Message-ID: References: <1561977630-32309-1-git-send-email-yash.shah@sifive.com> User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Jul 2019, Yash Shah wrote: > Reading the count register clears the interrupt signal. Currently, the > count registers are read into 'regval' variable but the variable is > never used. Therefore remove it. V2 of this patch add comments to > justify the readl calls without checking the return value. > > Signed-off-by: Yash Shah Thanks, will try to queue this for v5.2-rc - otherwise, v5.3. - Paul