Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2762273ybi; Mon, 1 Jul 2019 18:36:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqxD932VsexscRsdswoA8JANVR+VHMvw+6zqj7y+RZKKI2EtXQZPF/aU/rLk4gXoBuQnExu/ X-Received: by 2002:a17:902:b20d:: with SMTP id t13mr30702362plr.229.1562031404695; Mon, 01 Jul 2019 18:36:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562031404; cv=none; d=google.com; s=arc-20160816; b=ZYjQ1K0JAjaGM89EsIRpYzNEbvJ8unyrkoqKypfC4uqu8VrxOWQSPSN2iewaogpaME 7wE990yPwGqF1VeyPTxfmxV9O4VW5Pr+eXp6mcejQalP7rj1xmwmgk/1mEVg3hj81wms j+SrSIL35VS0rBgEjGlkpBzI7vwGFhX0T63n54fyr82+LrXj4G5vuyG8r3YoLqQIwXvX 5PoYMVvyJ9Br3RnOZ5EjrBErja52HEvlqawhhKwepRqQTZh0R77E2t6YYtHqM/PJdBdJ iPXnLxWXQtTkBGvjpmXEOUljS8mdnrq5Pv/sNCgYNom2LDkLvqzBkba3YzK0kj64QGZR Rwtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=viPOG1ZmdIuC37acxpxEY4t8Fo8sZXp+mUjvttia1pw=; b=aAwsTJmvbDJlycEla2txJqI/rUKKM4TdSanpG9xy0crUdGa34mx5RLITyk6qTRqZWJ KpRZOZ/dUCgzZ5E/jljx8vXyreo26yjwz6ujTg/zs0CeudHDeufluXbxNzWdQ6GjisiX XmsLmciXmAOQqUqwZzFFRlJnZNXaL2H4VEWR0dv5ijBgKonssG6UPkuVzqK94AEHIPH/ w36buwWQ4GeOJuCO1e0ruzjtxjg/Y5zkWKnp6on55dyll8bzYVPDG6msTeaRrAAJV/oY q4bDyMFJ5/WU+m67saEilLxo1N1V9V4+Dj/v8cwCTMkYzeWCQ3hmzPAXDLgPeOQM2pLD kSog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u62si11143600pgu.334.2019.07.01.18.36.29; Mon, 01 Jul 2019 18:36:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726990AbfGBBgH convert rfc822-to-8bit (ORCPT + 99 others); Mon, 1 Jul 2019 21:36:07 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:2961 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726688AbfGBBgH (ORCPT ); Mon, 1 Jul 2019 21:36:07 -0400 Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.56]) by Forcepoint Email with ESMTP id 689A3440031BAAE7975D; Tue, 2 Jul 2019 09:36:04 +0800 (CST) Received: from dggeme766-chm.china.huawei.com (10.3.19.112) by DGGEMM403-HUB.china.huawei.com (10.3.20.211) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 2 Jul 2019 09:36:03 +0800 Received: from dggeme763-chm.china.huawei.com (10.3.19.109) by dggeme766-chm.china.huawei.com (10.3.19.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Tue, 2 Jul 2019 09:36:03 +0800 Received: from dggeme763-chm.china.huawei.com ([10.6.66.36]) by dggeme763-chm.china.huawei.com ([10.6.66.36]) with mapi id 15.01.1591.008; Tue, 2 Jul 2019 09:36:03 +0800 From: linmiaohe To: Pablo Neira Ayuso CC: David Ahern , "kadlec@blackhole.kfki.hu" , "fw@strlen.de" , "davem@davemloft.net" , "kuznet@ms2.inr.ac.ru" , "yoshfuji@linux-ipv6.org" , "netfilter-devel@vger.kernel.org" , "coreteam@netfilter.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mingfangsen Subject: Re: Re: [PATCH v4] net: netfilter: Fix rpfilter dropping vrf packets by mistake Thread-Topic: Re: [PATCH v4] net: netfilter: Fix rpfilter dropping vrf packets by mistake Thread-Index: AdUwdbuw7kxy122jSLKo2Pj9ldiskw== Date: Tue, 2 Jul 2019 01:36:03 +0000 Message-ID: Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.184.189.20] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, July 2, 2019 at 02:02:59AM, Pablo wrote: > > Probably this? > > } else if (netif_is_l3_master(dev) || netif_is_l3_slave(dev) || > (flags & XT_RPFILTER_LOOSE) == 0) { > fl6.flowi6_oif = dev->ifindex; > } > > Thanks. I would send patch v5 according to this. Many Thanks. Have a nice day. Best wishes.