Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2783848ybi; Mon, 1 Jul 2019 19:07:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqzAhVFaPnrpK4UuWOvQ0ncm9vPiXHcEp4eHDe8LHWd5mamWSDPAaePHM5+wwX8IhHexw7JC X-Received: by 2002:a17:90a:cd04:: with SMTP id d4mr2726790pju.128.1562033240445; Mon, 01 Jul 2019 19:07:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562033240; cv=none; d=google.com; s=arc-20160816; b=in7SIidXzXueqtA002wzW7R7jut2gPf8m9WZfluwnvMwjXFSSZxtkNsoPb9DZnSIuy Hi16R3mJ89xaJHaAhLQu9Q8vCQhW7w98x/IPCAvHwUBM+5DtBtlqJ9K3rbynfKJIM/g2 0axAIynSm3xDXhfoO/nQRMVIuomSd00bH1NsGVifAJQRLSET725VHbqYr54cqRSoyudv tfb03sej6FUOpLYyTwTEpeiDTLKcINQ5Ycx95Y+1OwlDCuQ8I+L0ZszvbGu9qLjdhMuA Kyygb9HrEmRl3nAeA8KRe7vYbodgPQNFAa5m0OMjDncGADWJOAx/bkE4JaUYmLA1KSv7 Tg9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=zuCfc1aM4wzo7uMNxavFkBNMueeqnDTPw7fLe3D2GS8=; b=KbwM3X5D34Hzw1QKcrXU8NCf03083eEfs2Q0SlwYPiljRw354H5j66ah9sljlEQEeV pa6PcLUG5PdXb37x3Vrj4NzJJumenV1SBlO43Xq3eqx6K1iGuPtM2F5NLZDngDX3xH1J L3O/k5gfhqGC7p4Ng6GbFZATeqVAr8DtAoLlgizr1lCyRO45eiWPQBTDXKO4O6zM/Ya/ wHjdz1/YNoa5uSwgncwy0RSSTQFkaJOL/p2PpTowg8oAloyFeIWnLZiCsCVE2/2uPt/K 6DuVR5+aSQudbiRITqajPcOVlOfVqBR+BRo58Du7WNWtV6k4A9MsWBNdsN01VwJtgskq N2rg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u12si12087690pfh.256.2019.07.01.19.07.05; Mon, 01 Jul 2019 19:07:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727093AbfGBCFJ (ORCPT + 99 others); Mon, 1 Jul 2019 22:05:09 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:53828 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726362AbfGBCFJ (ORCPT ); Mon, 1 Jul 2019 22:05:09 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9F94514DE97A1; Mon, 1 Jul 2019 19:05:08 -0700 (PDT) Date: Mon, 01 Jul 2019 19:05:08 -0700 (PDT) Message-Id: <20190701.190508.1610025995462719506.davem@davemloft.net> To: devel@etsukata.com Cc: edumazet@google.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net/ipv6: Fix misuse of proc_dointvec "flowlabel_reflect" From: David Miller In-Reply-To: <20190628023714.1923-1-devel@etsukata.com> References: <20190628023714.1923-1-devel@etsukata.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Jul 2019 19:05:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eiichi Tsukata Date: Fri, 28 Jun 2019 11:37:14 +0900 > /proc/sys/net/ipv6/flowlabel_reflect assumes written value to be in the > range of 0 to 3. Use proc_dointvec_minmax instead of proc_dointvec. > > Fixes: 323a53c41292 ("ipv6: tcp: enable flowlabel reflection in some RST packets") > Signed-off-by: Eiichi Tsukata Applied, thanks.