Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2817946ybi; Mon, 1 Jul 2019 19:59:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqySiJHJy5JiRhgOoo3hpk41S2K35cf4oKUqSBRsLpQZ2+vj0OqEfxMuhwxTI7Rr+qJJYUfV X-Received: by 2002:a63:2a8d:: with SMTP id q135mr28014780pgq.46.1562036368460; Mon, 01 Jul 2019 19:59:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562036368; cv=none; d=google.com; s=arc-20160816; b=zi7NjclF/8kNmRzomrc1grNowa8W7/H+dAvbRCxMgxhjud2yhklEmKrxSZb4VQSGKo lRS8YzsrzDRFnLveAmkSu7kpakeG19gAQYbUi50Yhk82UaC9xBHJYQtI/cU017nXR14Z LCINw4fjcNQ06pPy9mGi1bl0W5jJMQZUVfOnLZZsmyCML7rO5sqVv7deI9R6AyaHPVWn DFls2UFnWsYZWQmymJkofUM6Z5wCGBkNZXzypAuDFuSu+rZU+Yw9Q5qbPDV4FT03LSyR 2uKFb2EK4r3tNwVcvWfeTVoCe/sII/6WKJfRw4O3gH3scECSLogybLOiwcLYQaGlyZAu 8SqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=/7tczepEzqTlmdybJcXMyIiLXAAIYH2wxpVMMpPnygI=; b=DKNllI8+WLPo/PL4BXz/mb0ezBu3nOjSb4aGXUrO9jab8Fed+lkaxuUYh6duFFPjxK bFkcQ9xY07JitG9m36FpAe6+ICrKmNR8ZsZk0XWl4QFlQucyzhiM3fiE2dap6k/f5Hka dg2OhX45TWetVzqu73jhwjgDCfCRJ4OMDPQUEt8+9U5KyBXvK6NKBnF9PlC4oBjOpOD0 LUK9Zu9tN170YUF7Yvb8wNv1JcMTZC9wYnh+0HwLsIigELs07hKeQSqMIN6tdh7wLhMX WFKQysIGsTh3EfAKvrxNgMimQxY7lyKN6f5SUHxLHlZno4g6JhDqeTYZLC6uw40+AiGM 8zVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YeKCuuuf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l97si1158792pje.6.2019.07.01.19.59.12; Mon, 01 Jul 2019 19:59:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YeKCuuuf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726830AbfGBC6q (ORCPT + 99 others); Mon, 1 Jul 2019 22:58:46 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:33297 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726362AbfGBC6p (ORCPT ); Mon, 1 Jul 2019 22:58:45 -0400 Received: by mail-pg1-f196.google.com with SMTP id m4so6944933pgk.0 for ; Mon, 01 Jul 2019 19:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=/7tczepEzqTlmdybJcXMyIiLXAAIYH2wxpVMMpPnygI=; b=YeKCuuufxt1rPwf9tFm3JoYgmAoX8/7P77uCZJXLc34ku8ooPUW6fm90JBYOr7fonU Ec9Th7cAjR+DQOigpd7hJnJmSLu0cOtx1uyOAuNSPE/JBg0hDPhlena8qQNlhW0TW+cf jV0gQMltaEN3EWijsKA5MjLkCYgimin7zrHkZN7HipFBIKEQ4mZW7pvVbdTOcf/q4Zcy +8zftBaFi4ny41YIfIp7UGh1JQVwoGDoxA3fyhln1QGOlx+2NFWYYuGKFCwdV8m+e/ZR b9pPgJIHL86/YaD5/NNB42cjlsBPYnTfenXY+14o15yMX4F8QW1FwEjn/6cKy0UdB5M7 E5yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/7tczepEzqTlmdybJcXMyIiLXAAIYH2wxpVMMpPnygI=; b=mhP1SxHzXYqoqcnmtTqTNQy13qGElJjF9CamWvn/K4V1CS+t0AH0Rt7VLYm67LvLiq 0obF0lT/Lx+UC7qVaaTAacYvUNWXmKLGR5LdTvgBXDEuYI1ipEj4Nu5tPXNjKn73tuct 1LCwZLJehaBvtGPpwN3ScAx4LFQJaj1KjNrMxS1WEL3xUWkaOXwi+ZTK1I19D6RrW8PV pCOLRSNQzh32tueJQk8FYuNcLH4m2vw1zw3cLHy6Mk5Vcqu2wzKfxlbTFbuHU0o1rLYJ Dx7i1Grbe4PyBlp3AejdO7gKUa0g6jDJmBv3wGMQnZnI77tj2QJEVsvo9sHeANxb0WsY XesQ== X-Gm-Message-State: APjAAAVjJB1VANfsZwFPrqVVFfO74qaKcm1h0dPGX/NR6HHPpFxfee6x otjDNJXY95p9ew6kgtwpshM= X-Received: by 2002:a63:6fcf:: with SMTP id k198mr15007946pgc.276.1562036325159; Mon, 01 Jul 2019 19:58:45 -0700 (PDT) Received: from huyue2.ccdomain.com ([218.189.10.173]) by smtp.gmail.com with ESMTPSA id r198sm14506893pfc.149.2019.07.01.19.58.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Jul 2019 19:58:44 -0700 (PDT) From: Yue Hu To: gaoxiang25@huawei.com, yuchao0@huawei.com, gregkh@linuxfoundation.org Cc: linux-erofs@lists.ozlabs.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, huyue2@yulong.com Subject: [PATCH RESEND v3] staging: erofs: remove unsupported ->datamode check in fill_inline_data() Date: Tue, 2 Jul 2019 10:56:01 +0800 Message-Id: <20190702025601.7976-1-zbestahu@gmail.com> X-Mailer: git-send-email 2.17.1.windows.2 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yue Hu Already check if ->datamode is supported in read_inode(), no need to check again in the next fill_inline_data() only called by fill_inode(). Signed-off-by: Yue Hu Reviewed-by: Gao Xiang Reviewed-by: Chao Yu --- no change drivers/staging/erofs/inode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c index e51348f..d6e1e16 100644 --- a/drivers/staging/erofs/inode.c +++ b/drivers/staging/erofs/inode.c @@ -129,8 +129,6 @@ static int fill_inline_data(struct inode *inode, void *data, struct erofs_sb_info *sbi = EROFS_I_SB(inode); const int mode = vi->datamode; - DBG_BUGON(mode >= EROFS_INODE_LAYOUT_MAX); - /* should be inode inline C */ if (mode != EROFS_INODE_LAYOUT_INLINE) return 0; -- 1.9.1