Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: Us4pqmTYFLiO0cRbSQh8CyEnoQIfX7/aNy76h2GNOwTJ6WnqAxMpumNVSlRJJzidu2mfGsA2ou
 DYGuX771ZVIu7MI7qOXeeifzTeBW6TkS7lliCkvCFl6VJppfaN6kSxNagLJtksPIPfVbW9VAHx
 WqY8egbnNiX5a/B67ZB0xtnw1wkrEApzwmV2m2DHPi/rJ7uFt410Al93cE9hYFABfaVLfA4zZw
 eJxLEucuYO9YFv1PtS5PXMgD5jfAUEwwHRXUgSUpjYTb//9gDul04Z2NAaAeb/LM2W6gPwmI8e
 c58=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Florian Knauf <florian.knauf@stud.uni-hannover.de>
CC:     "linux-kernel@i4.cs.fau.de" <linux-kernel@i4.cs.fau.de>,
        Jens Axboe <axboe@kernel.dk>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Christian Ewert <christian.ewert@stud.uni-hannover.de>
Subject: Re: [PATCH v2] drivers/block/loop: Replace deprecated function in
 option parsing code
Thread-Topic: [PATCH v2] drivers/block/loop: Replace deprecated function in
 option parsing code
Thread-Index: AQHVK386Ta6SMRAy8UW37kTixSPwpqazD5KAgAPAtgc=
Date:   Tue, 2 Jul 2019 05:04:33 +0000
Message-ID: <AF943092-D561-4257-A035-9E2F53F1E347@wdc.com>
References: <BYAPR04MB574936B98A60EB42B9A7C97886E30@BYAPR04MB5749.namprd04.prod.outlook.com>
 <20190625175517.31133-1-florian.knauf@stud.uni-hannover.de>
 <BYAPR04MB574963E31CE0DB5581F5311F86E30@BYAPR04MB5749.namprd04.prod.outlook.com>,<eb0b0981-aba3-93dc-5ae5-d36f1f728024@stud.uni-hannover.de>
In-Reply-To: <eb0b0981-aba3-93dc-5ae5-d36f1f728024@stud.uni-hannover.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 30c86c33-1b0c-46a5-e88b-08d6feaac60d
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2019 05:04:33.8190
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Chaitanya.Kulkarni@wdc.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4392
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

You are welcome.
> On Jun 29, 2019, at 12:46 PM, Florian Knauf <florian.knauf@stud.uni-hanno=
ver.de> wrote:
>=20
> I have now, on the latest staging master (test log attached, everything g=
reen), and also learned a lesson about looking more thoroughly for automate=
d test cases. That's a mea culpa, I suppose. :P
>=20
> Before this I'd only found the Linux Test Project, which (if I'm not mist=
aken) contains tests that use loopback devices but no tests that specifical=
ly test the loopback driver itself. Given the small scope of the change, we=
 then considered it sufficient to test manually that the loop device still =
worked and that the max_loop parameter was handled correctly. Of course, th=
e blktests way is better.
>=20
> Thanks for taking the time to answer and review.
>=20
>> Am 25.06.19 um 21:24 schrieb Chaitanya Kulkarni:
>> I believe you have tested this patch with loop testcases present in the
>> :- https://github.com/osandov/blktests/tree/master/tests/loop.
>> With that, looks good.
>> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>.
>>> On 06/25/2019 10:55 AM, Florian Knauf wrote:
>>> This patch removes the deprecated simple_strtol function from the optio=
n
>>> parsing logic in the loopback device driver. Instead kstrtoint is used =
to
>>> parse int max_loop, to ensure that input values it cannot represent are
>>> ignored.
>>>=20
>>> Signed-off-by: Florian Knauf <florian.knauf@stud.uni-hannover.de>
>>> Signed-off-by: Christian Ewert <christian.ewert@stud.uni-hannover.de>
>>> ---
>>> Thank you for your feedback.
>>>=20
>>> There's no specific reason to use kstrtol, other than the fact that we
>>> weren't yet aware that kstrtoint exists. (We're new at this, I'm afraid=
.)
>>>=20
>>> We've amended the patch to make use of kstrtoint, which is of course mu=
ch
>>> more straightforward.
>>>=20
>>> drivers/block/loop.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>=20
>>> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
>>> index 102d79575895..adfaf4ad37d1 100644
>>> --- a/drivers/block/loop.c
>>> +++ b/drivers/block/loop.c
>>> @@ -2289,7 +2289,7 @@ module_exit(loop_exit);
>>>   #ifndef MODULE
>>>   static int __init max_loop_setup(char *str)
>>>   {
>>> -    max_loop =3D simple_strtol(str, NULL, 0);
>>> +    kstrtoint(str, 0, &max_loop);
>>>       return 1;
>>>   }
>>>=20
>>>=20
> <check.log>