Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3051485ybi; Tue, 2 Jul 2019 01:10:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqxruvLsHnqAqYdxo+AqA6TgHv2RYkRXH+wPDCO74s0RpfM1gKYwfTsbanb4PLqDiT9oZrrY X-Received: by 2002:a63:4105:: with SMTP id o5mr30253345pga.308.1562055032591; Tue, 02 Jul 2019 01:10:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562055032; cv=none; d=google.com; s=arc-20160816; b=eEhO9cvoENYaoDhn9IRuY6FsV5bbGUYsxM4iirSlKCLS0WiRbK6QFpObRFIsIinoWE UPpCK1HUOgodmdHvfIUv80rn9tOdv4u+URTx8qMgoy/wm7W2jQncFVw/zHZf2XDtYWUb 7P1lAcQPLCXC74aBRXraAs7QbN3kTzujvSZodgBJQDwn/qJWSI/kbQd9+Mnq3Q2oiN36 2okNi+wlyaKakF7Aub41/90nCvVioTZCn/Z25d66qJcb81ZTx5El1Dx2PefiM0m4dRL0 BC7KkOJxpCq0lxRU+Iugo6xKiwB0y72SfkSOI/UR1AMWwJ8ltufPlm7E03VRqJYd2J90 7BTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TRsFbqyFmVRVU+05FjOGzim+o4qSeRTbxBEcqBR1BBU=; b=XkuF7Wovx9fu8XzGZ4O2QGIXSouJWZbjFISS9l7Aqjcol+9fUnZs0KKu67BQT05vff hK29Uz+1uzHXXcGOaPL4wL8E6Zkx8jwdb6+SK65JgKG6oal4SzD+7gHZoXB1sWVveuoC bQhI5GQ1/9Gyreo24z3rTVd/dIDOyAgOy21tzjx5CZiSmdlSWUT3nlt2Jzqv9dSrLRTF ic1s4bKhUvnS55YYEvxQv6J/5anB6yDeXA8/Na+6FOzFPrNA/23aFspdE8CXvTGnfoO8 B8zeW1Vk3270HOu9tpNAHrXm5oMgFyCoJDXZuKs1v3GUyG1xbK5CcIfFEY2ad/W1AI84 V7gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=B2aFo35b; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d31si12460894pla.393.2019.07.02.01.10.17; Tue, 02 Jul 2019 01:10:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=B2aFo35b; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728336AbfGBIHw (ORCPT + 99 others); Tue, 2 Jul 2019 04:07:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:55202 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727892AbfGBIHs (ORCPT ); Tue, 2 Jul 2019 04:07:48 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA9F22184C; Tue, 2 Jul 2019 08:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562054868; bh=tDnzVbDbQPPcx+I8iy29VRml9ECUTqMYGj0QLmWN2oQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B2aFo35bvpsYjW04OXYZQkCH7G8q4RtPjzsRAhcDjCmU5K2NFnDAlCyvzs0rAccCL Y14XytPmbccPqdVtWW/loWsus24E93nxqooJoKCQbN4Y7zRBH78PiVmd7yhvQ+k7k6 OIYKyYirV1kkM0q2NpmhdxIKTaeXrawxmyYvJGg8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jiri Pirko , YueHaibing , "David S. Miller" Subject: [PATCH 4.19 58/72] team: Always enable vlan tx offload Date: Tue, 2 Jul 2019 10:01:59 +0200 Message-Id: <20190702080127.615793762@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190702080124.564652899@linuxfoundation.org> References: <20190702080124.564652899@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit ee4297420d56a0033a8593e80b33fcc93fda8509 ] We should rather have vlan_tci filled all the way down to the transmitting netdevice and let it do the hw/sw vlan implementation. Suggested-by: Jiri Pirko Signed-off-by: YueHaibing Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/team/team.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -2139,12 +2139,12 @@ static void team_setup(struct net_device dev->features |= NETIF_F_NETNS_LOCAL; dev->hw_features = TEAM_VLAN_FEATURES | - NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_CTAG_FILTER; dev->hw_features |= NETIF_F_GSO_ENCAP_ALL | NETIF_F_GSO_UDP_L4; dev->features |= dev->hw_features; + dev->features |= NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_HW_VLAN_STAG_TX; } static int team_newlink(struct net *src_net, struct net_device *dev,