Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3053223ybi; Tue, 2 Jul 2019 01:12:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqwrqv78F04TUj6qNngSmmKJgHKPK5gjEYO/W/qoIjOi79ODpGweiiBne9azmmdXGKm1stD7 X-Received: by 2002:a17:902:112a:: with SMTP id d39mr23685780pla.254.1562055158528; Tue, 02 Jul 2019 01:12:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562055158; cv=none; d=google.com; s=arc-20160816; b=UVVJLuJz+DEmPIff5lY0JK0VT6T6KB1KHBjoUxxojzogeZHx1sbXltXMFcKsC+BDTg SpVhrhlEIBEhTcHW5VKOF8qxWO3OWeee7ouj5oxzEiU7iDImWJJ6OeIN1A+mjMVkCpT7 uJwlQyj2J32Ovuj12GPp4gs+UMgdzl9AGTl3Y6VpnvMnejIhVJh8gSJ9wCpOBPs1a91b Vh9+GdYQOmUdSHdEUjfArxSwBHspH0vM0wlcq2ZRCPuQTZ3oQCD0uSnvzy9Z2RCXkioD 0d6csH79tyXS7yGXEYglMBIBNWekVnzCtFWOmhkle8sJkSNvocVrIH9+wBGDCBw1FeqF MnXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=vRJccmh7UnrsUVCKsOn4xtgoai5f8n85MnS2+gAJU/w=; b=brXZf5vdRExxb+V4PmC/x+1ODzezV5tabke10qTx5vgxTELjFFN+U67mtn8CSR5h2H 52o+QP0lQPrJirOpnXV6H/oZJ2ifmd25DWXRD2VqXCN1lZ2a58ur6ozvTBIiSM88/mdm i5mM9prjHohA3Ha0nfY+361EP7fSOvPG/08uXMvf4mmyAfU2krLfycaqAn8sUnEUqEaW mKJRSfzAGO5iuVf3mrPJGtK7I2aZZ05hFNpIA59lYup7t5wqSh0OBc0nBiZyg209uWkS DeTE7AdSzjcCzouDzIdDwAvfdbEXz/0W2SiKykY0sADiHsoqT2Ia9pLAUWAuc+xABIQg UltQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lqk9+917; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31si13197938plc.356.2019.07.02.01.12.24; Tue, 02 Jul 2019 01:12:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lqk9+917; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728792AbfGBIKI (ORCPT + 99 others); Tue, 2 Jul 2019 04:10:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:58332 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728780AbfGBIKG (ORCPT ); Tue, 2 Jul 2019 04:10:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0201D21850; Tue, 2 Jul 2019 08:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562055006; bh=jBVB3WzKRU53r2hTnkZMtlZ8EDAE5zf3xnFZfNvLmJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lqk9+917YB0AWw91xOiPlAGogDlhNy3KHzVwYsr6mFnHso2Ynvr+HKcpizlaJH/c6 pxIlrFzJ0P837P9nb0U2yVUTD8u+TiOro4ojI+ofFcv3+ueMv1cObHjkm335PxTJaf znchOiL6KmOW0/U93/tFUe/EED68e7VAiEwEjRdo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jiri Pirko , YueHaibing , "David S. Miller" Subject: [PATCH 4.14 36/43] team: Always enable vlan tx offload Date: Tue, 2 Jul 2019 10:02:16 +0200 Message-Id: <20190702080125.785807949@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190702080123.904399496@linuxfoundation.org> References: <20190702080123.904399496@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit ee4297420d56a0033a8593e80b33fcc93fda8509 ] We should rather have vlan_tci filled all the way down to the transmitting netdevice and let it do the hw/sw vlan implementation. Suggested-by: Jiri Pirko Signed-off-by: YueHaibing Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/team/team.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -2131,12 +2131,12 @@ static void team_setup(struct net_device dev->features |= NETIF_F_NETNS_LOCAL; dev->hw_features = TEAM_VLAN_FEATURES | - NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_CTAG_FILTER; dev->hw_features |= NETIF_F_GSO_ENCAP_ALL; dev->features |= dev->hw_features; + dev->features |= NETIF_F_HW_VLAN_CTAG_TX; } static int team_newlink(struct net *src_net, struct net_device *dev,