Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3135686ybi; Tue, 2 Jul 2019 02:44:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqznT6rg6aW88N4sKIWdGdXiP5n3w1FuBVqbd+Iuk7y7Riah8RXCXxQmeFpcKYg/G3dg7tza X-Received: by 2002:a17:90a:d80b:: with SMTP id a11mr4327761pjv.53.1562060653984; Tue, 02 Jul 2019 02:44:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562060653; cv=none; d=google.com; s=arc-20160816; b=n+VM25CKjRFzFvYuFRprRXr6X+pYuwIMVJ6yhsPSwWmQ5H8RhedXKFtrj3e+p3xfah /kAY8NWbhBRF96Sx167sG2aUdaImSCD6OdnrEZVbZukpVAcRfaCGCjCtTXpPPSrg4VrU 3R6MvlFcvcPdFZLRnYHfMrR1tDiQpI+IcmngCok8TvntKQdcyDG2o1Pkl3MYEX3RojVH lB/IVioEqG75BRTOQVRgOU+tF5RLyco+gIoBy48SWzPTHz7EdRgiwytjaidsDwxRQ53+ CS5N3gm3zKCu6odpy61Rpksi1s+84aeYpLtCU2VCcHgJSDLF9nWD6aQ9triudGvV04ZV Ib0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:to:from:subject:message-id; bh=YgX348QX8UFfGg2uWet5/eE+42GH9Nnjj4l7QSADE8c=; b=o+dotzLJwuh9Cx43YJqMhUUSnN0EjGu5KSNjH6ANpMI3IhFQTZEMyEhTPHaWInf2AO F9vfNX81h0UqfiDfmpXh8pGK4znb/sUm1xjeMmSG1V+Tmg01bXZuv2yGvqJNQp5VvS7g FiDrGZyJsuhxHOeXcpPwk0kYHEgNCMpYh2IhVGdIfiFEd+eo8k2VLfDRMvjukfVw8U2R sasrPtSzN6QIadQADp+OhWr47FXQqdUGHuZHxK1qoUeH71Zh6K0sRyQCbB9QuffWgeZo uVX+D9LPSrzI1u8m3xUWFzERcAm0PItT8ig5E8sFc3QDXg6szgdAaeB0iYIErzWIaL02 bgWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j63si6063359pgd.493.2019.07.02.02.43.59; Tue, 02 Jul 2019 02:44:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727177AbfGBJls (ORCPT + 99 others); Tue, 2 Jul 2019 05:41:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:58984 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726252AbfGBJlr (ORCPT ); Tue, 2 Jul 2019 05:41:47 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8AE8AB039; Tue, 2 Jul 2019 09:41:46 +0000 (UTC) Message-ID: <1562059675.5819.12.camel@suse.com> Subject: Re: [PATCH] usb: image: microtek: Unneeded variable: "err". Return "0" on line 616 From: Oliver Neukum To: Hariprasad Kelam , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Tue, 02 Jul 2019 11:27:55 +0200 In-Reply-To: <20190701175958.GA9826@hari-Inspiron-1545> References: <20190701175958.GA9826@hari-Inspiron-1545> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, den 01.07.2019, 23:29 +0530 schrieb Hariprasad Kelam: > Fix below issue reported by coccicheck > drivers/usb/image/microtek.c:569:5-8: Unneeded variable: "err". Return > "0" on line 616 > > We can not change return type of mts_scsi_queuecommand_lck as it is part > of DEF_SCSI_QCMD > > Signed-off-by: Hariprasad Kelam Acked-by: Oliver Neukum