Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3370384ybi; Tue, 2 Jul 2019 06:42:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqwnL4sXBoD5vH/zEIM04NEKNtdKoYZeJe4gmBUQPaDeOyTut+rPzFjpF4r18Z4ItMTIlavW X-Received: by 2002:a63:7a4f:: with SMTP id j15mr31524815pgn.427.1562074944139; Tue, 02 Jul 2019 06:42:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562074944; cv=none; d=google.com; s=arc-20160816; b=SCeCImTipUr4BjfKQbU5CwNbLQ33ebbLeUNDFEmMxnWto2/X1dQO/rM4Pr8iq6lBkI 6TskH8GqJ9ET6EIqw/kKuAela+ZRI0+VJIvVX2gI4zXFWSCxtV8u2EXZPstK+o8PyB+2 VY+hQha2is76lGmJ3gnTcOh0l2TGoFSenxk7FwnQB4O0vPqhR1Gd2fYn8KLn6Dp4PFDg 6Mtu2HEbpZWEnZcYNXVvnUtmyILWUWLBNn7s/181FaX7Qdq8EeoObfLsi86tcEoq23m5 9B9f6S0XTEExw3rvkRkCRBG8yaO4qD/+aG6ovKbyrFQ4DMzFU/35mc0/hq8Q5EwcEPUs USLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=oUgLhVtZt+epnYVVZmnX84R+rFX+CGt8GGlI2/HhW4k=; b=r7WrD8IdvckpW40HEU/K5e+XDPAKMcaxQCGg7suizs35mMwsjyfa69qK7Yl4m9acIl nQ/tlzqZdh9vbDUGcVLe5woroq/nWmkTmE7jD1/KoMhw+V4//6ZIERC4HGJIMWKhv5Ys 6bAzVqPMNkWCZDbVUT7IjSRkk3lmRilpGdX29rZqrqIpoofb/rgwpKjGsp/otQZlston WPhxGFQ1x4KUJYllNwDDD9Sj+cO8+0KcjsW7JAQVKh0lBRFCC73KCnqzo5s6PXo7Oyb4 wwlwpunvZinq50Hsb5xsXyoTn0cgn0dnVacE55eo0pP/b3d5pz2Zjrt1ejhV9NOl6lDj PmHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=oX61GCS4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q23si2222751pjp.63.2019.07.02.06.42.09; Tue, 02 Jul 2019 06:42:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=oX61GCS4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727089AbfGBNlk (ORCPT + 99 others); Tue, 2 Jul 2019 09:41:40 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:18603 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726430AbfGBNlk (ORCPT ); Tue, 2 Jul 2019 09:41:40 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 02 Jul 2019 06:41:37 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Tue, 02 Jul 2019 06:41:38 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 02 Jul 2019 06:41:38 -0700 Received: from [10.21.132.148] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 2 Jul 2019 13:41:35 +0000 Subject: Re: [PATCH v3] dmaengine: tegra-apb: Support per-burst residue granularity To: Dmitry Osipenko , Laxman Dewangan , Vinod Koul , Thierry Reding , Ben Dooks CC: , , References: <20190627194728.8948-1-digetx@gmail.com> <3a5403fe-b81f-993c-e7c0-407387e001d9@gmail.com>

From: Jon Hunter Message-ID: Date: Tue, 2 Jul 2019 14:41:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL106.nvidia.com (172.18.146.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1562074897; bh=oUgLhVtZt+epnYVVZmnX84R+rFX+CGt8GGlI2/HhW4k=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=oX61GCS4lX8/4mID96beL2doeqzWM/L61oxnIEXDzmKyO4T9rQKQVow59wE2od7fX my3/lmtVJrNh8wzRNlDu6RXNXByJwII2Ml87fZmJ5FtiN8F55itL6Ok/aZG7AQIvFz JREX6h2x/9gWdBPzFCDfPpfDXQa+8wCcLx/lP8hH1MSw1FNZ+hsN3pxBAnsynLY3yp DSFmhoTe8QroFakLd1nw5u/jyOfjUgGBiMtLZg7C1yXAY94aJodR4gxfIT8JiolReL 5YP/8w9MMePAgkQUf1W4zZHHgRzrXRkgVA5ZagrpDyqruaX8usycy3tqLtke1pW1C4 70elBu6cYlMtQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/07/2019 14:22, Dmitry Osipenko wrote: > 02.07.2019 15:54, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >> On 02/07/2019 12:37, Dmitry Osipenko wrote: >>> 02.07.2019 14:20, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> >>>> On 27/06/2019 20:47, Dmitry Osipenko wrote: >>>>> Tegra's APB DMA engine updates words counter after each transferred b= urst >>>>> of data, hence it can report transfer's residual with more fidelity w= hich >>>>> may be required in cases like audio playback. In particular this fixe= s >>>>> audio stuttering during playback in a chromium web browser. The patch= is >>>>> based on the original work that was made by Ben Dooks and a patch fro= m >>>>> downstream kernel. It was tested on Tegra20 and Tegra30 devices. >>>>> >>>>> Link: https://lore.kernel.org/lkml/20190424162348.23692-1-ben.dooks@c= odethink.co.uk/ >>>>> Link: https://nv-tegra.nvidia.com/gitweb/?p=3Dlinux-4.4.git;a=3Dcommi= t;h=3Dc7bba40c6846fbf3eaad35c4472dcc7d8bbc02e5 >>>>> Inspired-by: Ben Dooks >>>>> Signed-off-by: Dmitry Osipenko >>>>> --- >>>>> >>>>> Changelog: >>>>> >>>>> v3: Added workaround for a hardware design shortcoming that results >>>>> in a words counter wraparound before end-of-transfer bit is set >>>>> in a cyclic mode. >>>>> >>>>> v2: Addressed review comments made by Jon Hunter to v1. We won't try >>>>> to get words count if dma_desc is on free list as it will result >>>>> in a NULL dereference because this case wasn't handled properly. >>>>> >>>>> The residual value is now updated properly, avoiding potential >>>>> integer overflow by adding the "bytes" to the "bytes_transferred= " >>>>> instead of the subtraction. >>>>> >>>>> drivers/dma/tegra20-apb-dma.c | 69 +++++++++++++++++++++++++++++++--= -- >>>>> 1 file changed, 62 insertions(+), 7 deletions(-) >>>>> >>>>> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-= dma.c >>>>> index 79e9593815f1..71473eda28ee 100644 >>>>> --- a/drivers/dma/tegra20-apb-dma.c >>>>> +++ b/drivers/dma/tegra20-apb-dma.c >>>>> @@ -152,6 +152,7 @@ struct tegra_dma_sg_req { >>>>> bool last_sg; >>>>> struct list_head node; >>>>> struct tegra_dma_desc *dma_desc; >>>>> + unsigned int words_xferred; >>>>> }; >>>>> =20 >>>>> /* >>>>> @@ -496,6 +497,7 @@ static void tegra_dma_configure_for_next(struct t= egra_dma_channel *tdc, >>>>> tdc_write(tdc, TEGRA_APBDMA_CHAN_CSR, >>>>> nsg_req->ch_regs.csr | TEGRA_APBDMA_CSR_ENB); >>>>> nsg_req->configured =3D true; >>>>> + nsg_req->words_xferred =3D 0; >>>>> =20 >>>>> tegra_dma_resume(tdc); >>>>> } >>>>> @@ -511,6 +513,7 @@ static void tdc_start_head_req(struct tegra_dma_c= hannel *tdc) >>>>> typeof(*sg_req), node); >>>>> tegra_dma_start(tdc, sg_req); >>>>> sg_req->configured =3D true; >>>>> + sg_req->words_xferred =3D 0; >>>>> tdc->busy =3D true; >>>>> } >>>>> =20 >>>>> @@ -797,6 +800,61 @@ static int tegra_dma_terminate_all(struct dma_ch= an *dc) >>>>> return 0; >>>>> } >>>>> =20 >>>>> +static unsigned int tegra_dma_sg_bytes_xferred(struct tegra_dma_chan= nel *tdc, >>>>> + struct tegra_dma_sg_req *sg_req) >>>>> +{ >>>>> + unsigned long status, wcount =3D 0; >>>>> + >>>>> + if (!list_is_first(&sg_req->node, &tdc->pending_sg_req)) >>>>> + return 0; >>>>> + >>>>> + if (tdc->tdma->chip_data->support_separate_wcount_reg) >>>>> + wcount =3D tdc_read(tdc, TEGRA_APBDMA_CHAN_WORD_TRANSFER); >>>>> + >>>>> + status =3D tdc_read(tdc, TEGRA_APBDMA_CHAN_STATUS); >>>>> + >>>>> + if (!tdc->tdma->chip_data->support_separate_wcount_reg) >>>>> + wcount =3D status; >>>>> + >>>>> + if (status & TEGRA_APBDMA_STATUS_ISE_EOC) >>>>> + return sg_req->req_len; >>>>> + >>>>> + wcount =3D get_current_xferred_count(tdc, sg_req, wcount); >>>>> + >>>>> + if (!wcount) { >>>>> + /* >>>>> + * If wcount wasn't ever polled for this SG before, then >>>>> + * simply assume that transfer hasn't started yet. >>>>> + * >>>>> + * Otherwise it's the end of the transfer. >>>>> + * >>>>> + * The alternative would be to poll the status register >>>>> + * until EOC bit is set or wcount goes UP. That's so >>>>> + * because EOC bit is getting set only after the last >>>>> + * burst's completion and counter is less than the actual >>>>> + * transfer size by 4 bytes. The counter value wraps around >>>>> + * in a cyclic mode before EOC is set(!), so we can't easily >>>>> + * distinguish start of transfer from its end. >>>>> + */ >>>>> + if (sg_req->words_xferred) >>>>> + wcount =3D sg_req->req_len - 4; >>>>> + >>>>> + } else if (wcount < sg_req->words_xferred) { >>>>> + /* >>>>> + * This case shall not ever happen because EOC bit >>>>> + * must be set once next cyclic transfer is started. >>>> >>>> I am not sure I follow this and why this condition cannot happen for >>>> cyclic transfers. What about non-cyclic transfers? >>> >>> It cannot happen because the EOC bit will be set in that case. The coun= ter wraps >>> around when the transfer of a last burst happens, EOC bit is guaranteed= to be set >>> after completion of the last burst. That's my observation after a thoro= ugh testing, >>> it will be very odd if EOC setting happened completely asynchronously. >> >> I see how you know that the EOC is set. Anyway, you check if the EOC is >> set before and if so return sg_req->req_len prior to this test. >> >> Maybe I am missing something, but what happens if we are mid block when >> dmaengine_tx_status() is called? That happen asynchronously right? >=20 >=20 > Do you mean asynchronously in regards to the ISR? Or something else? In the sense that the client can call dmaengine_tx_status() at anytime to check the status of a transfer. Cheers Jon --=20 nvpublic