Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\))
Subject: Re: [PATCH 1/3] KVM: nVMX: include conditional controls in /dev/kvm
 KVM_GET_MSRS
From:   Liran Alon <liran.alon@oracle.com>
In-Reply-To: <1562079876-20756-2-git-send-email-pbonzini@redhat.com>
Date:   Tue, 2 Jul 2019 18:17:33 +0300
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <8EF461F9-3243-446F-9AF7-C8FFDC58B467@oracle.com>
References: <1562079876-20756-1-git-send-email-pbonzini@redhat.com>
 <1562079876-20756-2-git-send-email-pbonzini@redhat.com>
To:     Paolo Bonzini <pbonzini@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On 2 Jul 2019, at 18:04, Paolo Bonzini <pbonzini@redhat.com> wrote:
>=20
> Some secondary controls are automatically enabled/disabled based on =
the CPUID
> values that are set for the guest.  However, they are still available =
at a
> global level and therefore should be present when KVM_GET_MSRS is sent =
to
> /dev/kvm.
>=20
> Fixes: 1389309c811 ("KVM: nVMX: expose VMX capabilities for nested =
hypervisors to userspace", 2018-02-26)
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Liran Alon <liran.alon@oracle.com>

> ---
> arch/x86/kvm/vmx/nested.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>=20
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index 990e543f4531..c4e29ef0b21e 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -5750,10 +5750,15 @@ void nested_vmx_setup_ctls_msrs(struct =
nested_vmx_msrs *msrs, u32 ept_caps,
> 	msrs->secondary_ctls_low =3D 0;
> 	msrs->secondary_ctls_high &=3D
> 		SECONDARY_EXEC_DESC |
> +		SECONDARY_EXEC_RDTSCP |
> 		SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE |
> +		SECONDARY_EXEC_WBINVD_EXITING |
> 		SECONDARY_EXEC_APIC_REGISTER_VIRT |
> 		SECONDARY_EXEC_VIRTUAL_INTR_DELIVERY |
> -		SECONDARY_EXEC_WBINVD_EXITING;
> +		SECONDARY_EXEC_RDRAND_EXITING |
> +		SECONDARY_EXEC_ENABLE_INVPCID |
> +		SECONDARY_EXEC_RDSEED_EXITING |
> +		SECONDARY_EXEC_XSAVES;
>=20
> 	/*
> 	 * We can emulate "VMCS shadowing," even if the hardware
> --=20
> 1.8.3.1
>=20
>=20