Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\))
Subject: Re: [PATCH 2/3] KVM: nVMX: allow setting the VMFUNC controls MSR
From:   Liran Alon <liran.alon@oracle.com>
In-Reply-To: <1562079876-20756-3-git-send-email-pbonzini@redhat.com>
Date:   Tue, 2 Jul 2019 18:27:49 +0300
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        stable@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <3E09BABA-FADF-41AD-8524-68A587197DBC@oracle.com>
References: <1562079876-20756-1-git-send-email-pbonzini@redhat.com>
 <1562079876-20756-3-git-send-email-pbonzini@redhat.com>
To:     Paolo Bonzini <pbonzini@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On 2 Jul 2019, at 18:04, Paolo Bonzini <pbonzini@redhat.com> wrote:
>=20
> Allow userspace to set a custom value for the VMFUNC controls MSR, as =
long
> as the capabilities it advertises do not exceed those of the host.
>=20
> Fixes: 27c42a1bb ("KVM: nVMX: Enable VMFUNC for the L1 hypervisor", =
2017-08-03)
> Cc: stable@vger.kernel.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Liran Alon <liran.alon@oracle.com>

> ---
> arch/x86/kvm/vmx/nested.c | 5 +++++
> 1 file changed, 5 insertions(+)
>=20
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index c4e29ef0b21e..163d226efa96 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -1234,6 +1234,11 @@ int vmx_set_vmx_msr(struct kvm_vcpu *vcpu, u32 =
msr_index, u64 data)
> 	case MSR_IA32_VMX_VMCS_ENUM:
> 		vmx->nested.msrs.vmcs_enum =3D data;
> 		return 0;
> +	case MSR_IA32_VMX_VMFUNC:
> +		if (data & ~vmx->nested.msrs.vmfunc_controls)
> +			return -EINVAL;
> +		vmx->nested.msrs.vmfunc_controls =3D data;
> +		return 0;
> 	default:
> 		/*
> 		 * The rest of the VMX capability MSRs do not support =
restore.
> --=20
> 1.8.3.1
>=20
>=20