Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 2 Jul 2019 20:12:48 +0300
From:   Alexey Dobriyan <adobriyan@gmail.com>
To:     mcroce@redhat.com
Cc:     linux-kernel@vger.kernel.org, keescook@chromium.org,
        atomlin@redhat.com, akpm@linux-foundation.org
Subject: Re: [PATCH] proc/sysctl: add shared variables for range check
Message-ID: <20190702170228.GA4404@avx2>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> -static long zero;
>  static long long_max = LONG_MAX;
> 
>  struct ctl_table epoll_table[] = {
> @@ -301,7 +300,7 @@ struct ctl_table epoll_table[] = {
>                 .maxlen         = sizeof(max_user_watches),
>                 .mode           = 0644,
>                 .proc_handler   = proc_doulongvec_minmax,
> -               .extra1         = &zero,
> +               .extra1         = SYSCTL_ZERO,
>                 .extra2         = &long_max,

This looks wrong: proc_doulongvec_minmax() expects "long"s.
The whole patch needs rechecking.

> +/* shared constants to be used in various sysctls */
> +const =======>int<========== sysctl_vals[] = { 0, 1, INT_MAX };
> +EXPORT_SYMBOL(sysctl_vals);